From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WHNyJQs8VV+/SAAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 19:44:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sHr/IAs8VV+aHgAAbx9fmQ (envelope-from ) for ; Sun, 06 Sep 2020 19:44:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D635F940142 for ; Sun, 6 Sep 2020 19:44:10 +0000 (UTC) Received: from localhost ([::1]:39060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF0a8-0004XR-Jf for larch@yhetil.org; Sun, 06 Sep 2020 15:44:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF0a2-0004XL-BT for bug-guix@gnu.org; Sun, 06 Sep 2020 15:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF0a2-0002nh-16 for bug-guix@gnu.org; Sun, 06 Sep 2020 15:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF0a1-000741-Ub for bug-guix@gnu.org; Sun, 06 Sep 2020 15:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43228: r-v8 doesn't build since node 10.22 update Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 06 Sep 2020 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43228 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Pierre Langlois Received: via spool by 43228-submit@debbugs.gnu.org id=B43228.159942143927138 (code B ref 43228); Sun, 06 Sep 2020 19:44:01 +0000 Received: (at 43228) by debbugs.gnu.org; 6 Sep 2020 19:43:59 +0000 Received: from localhost ([127.0.0.1]:47198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0Zy-00073d-QC for submit@debbugs.gnu.org; Sun, 06 Sep 2020 15:43:59 -0400 Received: from world.peace.net ([64.112.178.59]:35650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0Zq-00073I-0r for 43228@debbugs.gnu.org; Sun, 06 Sep 2020 15:43:57 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF0Zj-00037R-FY; Sun, 06 Sep 2020 15:43:43 -0400 From: Mark H Weaver In-Reply-To: <87pn6z5f4j.fsf@gmx.com> References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> <87o8mjrf3u.fsf@netris.org> <87pn6z5f4j.fsf@gmx.com> Date: Sun, 06 Sep 2020 15:42:27 -0400 Message-ID: <878sdmr8sh.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43228@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 1t1LmKMKc4Dr Hi Pierre, Your new patch looks good to me, but the node-10.22 source field could be simplified to avoid repeating the unchanged field (especially the snippet), by inheriting from (package-source node) like this: --8<---------------cut here---------------start------------->8--- (source (origin (inherit (package-source node)) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.xz")) (sha256 (base32 "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")))) --8<---------------cut here---------------end--------------->8--- Also, it would be great to find a way to fit in the subject line that 10.22 is also being kept as a separate binding, especially since "guix build node" and most other user commands will still build 10.22. Maybe something like this: gnu: node: Downgrade to 10.20.0; add separate 'node-10.22' binding. What do you think? Anyway, feel free to push this, preferably after incorporating these suggestions. If I'm not mistaken, the simplification suggested above should not change the .drv file, and therefore not entail a rebuild, so testing it should be very quick. Thanks! Mark