From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AEkZIH1AYV85EQAA0tVLHw (envelope-from ) for ; Tue, 15 Sep 2020 22:30:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iASfGn1AYV9tPgAA1q6Kng (envelope-from ) for ; Tue, 15 Sep 2020 22:30:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A40DA9403EE for ; Tue, 15 Sep 2020 22:30:20 +0000 (UTC) Received: from localhost ([::1]:43598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIJSt-0003gN-Ds for larch@yhetil.org; Tue, 15 Sep 2020 18:30:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIJSc-0003fs-Nd for bug-guix@gnu.org; Tue, 15 Sep 2020 18:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIJSc-0001CQ-AC for bug-guix@gnu.org; Tue, 15 Sep 2020 18:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIJSc-0005RR-57 for bug-guix@gnu.org; Tue, 15 Sep 2020 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. Resent-From: Mike Rosset Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 15 Sep 2020 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43232 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 43232-submit@debbugs.gnu.org id=B43232.160020894920818 (code B ref 43232); Tue, 15 Sep 2020 22:30:02 +0000 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 22:29:09 +0000 Received: from localhost ([127.0.0.1]:60773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIJRk-0005Ph-Qd for submit@debbugs.gnu.org; Tue, 15 Sep 2020 18:29:09 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:32816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIJRh-0005PA-HI for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 18:29:08 -0400 Received: by mail-pf1-f193.google.com with SMTP id z18so248958pfg.0 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 15:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=HQL2rmaekPwjvs9z3Wp9C9XI9rjIDDMiRkD26lrzyUM=; b=BG/fmJ0pgetU8qkb0rXfoDQP6HqgWWpogDdjwBjjWddvGPmeXzD+f6wQ7jNokRkuSD F3xfFLwsac95GVD8DT2gzzh3x7Skgl8d+gNrmdihM+9w+5d8Lv3IdndjUfkSZoFfio+I pv9Jdkrz5UjSYLt778vE1WG8SW92UHdwW8Wv6wxXRCubDUFgE2hFmsTqdC3BKFrYCRqZ 3+oyfP1M9gmaQcMJf9cGUC/OzICPnAyjakjidAF+r0lneqjRXloN6/TemBlyU4Suv7un 4hXIS7RPGgOY3USza/eO2wWlKG+KxuKSb9SCedg8syR35z2WwSyX1bhl+yHE+muHS6Bp Krig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=HQL2rmaekPwjvs9z3Wp9C9XI9rjIDDMiRkD26lrzyUM=; b=UhsuxeE3NbisaxZXR5rJDe9LbqPFIO1Q6C/sXujY3sxBwiyX4JAnTwHzI9FrR5+OQJ EcpflbtAXEqx2fTh89jfcE1KPG7f0qmW96Lj95OlXIQZCFINuAtbeaf0ELs3zh7wLeKm J53Vb5BKd9K6Gy6RvpBBFlcYX/x6REUvbvTe2wAHt33NafA/BSaRuMh5iLQfEBu6rndz rVplusfr9FbYr0d5fYURxfl+4Wf96EsgANaN9gKAg5CnjzyCpXmAFlOCweRZUtv1e/b3 baH6W1R8Osxaqd7fJtwiqdd+yhiYWcx2Fs/IEWAbkikaXXSH9iQwMeOwLonOjSj1sdVw fvgw== X-Gm-Message-State: AOAM5330oQJsCFUXo46T9QGTXCKq1/rb17dcaP9pN+0TD0q4EF6tsNrP dWaFyz+2YwFn0DLFS2BlfhmrxF/VzZo= X-Google-Smtp-Source: ABdhPJw4VfPlGDGXAQQmTF/EcBLjvcCGsmMaYuyTYTs66y0R3GHySV5VYIkGRD3YPlr3HwNwG+QSig== X-Received: by 2002:a65:5902:: with SMTP id f2mr2582515pgu.379.1600208939259; Tue, 15 Sep 2020 15:28:59 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id 138sm15312596pfu.180.2020.09.15.15.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 15:28:58 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> <87d02mbwb7.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset In-reply-to: <87d02mbwb7.fsf@netris.org> Date: Tue, 15 Sep 2020 15:28:57 -0700 Message-ID: <878sday8ra.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43232@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=BG/fmJ0p; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: voHtM6kfCKCv Mark H Weaver writes: > Earlier, I wrote: >> In contrast, a call to 'substitute*' will silently start doing nothing, >> and may easily be forgotten. To make matters worse, a future version of >> jack-2 might add another 'for' loop in that file, matching the same >> pattern but where it is important that 'i' _not_ be initialized to 0. > > Sorry, I made a mistake in the details here, since the pattern applies > only when 'i' is already initialized to 0, but the more general point > still stands, namely that patches are more robust than 'substitute*' for > fixing bugs, and less likely to be misapplied or left forgotten in a > vestigial state after they are no longer needed. > > Mark That change was not quite fitting right with me either. So I appreciate the review and comments. Thankful it's not needed with 1.9.14 and I'll take your comments into account in the future. Mike