From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iL6eFff1jl9vQgAA0tVLHw (envelope-from ) for ; Tue, 20 Oct 2020 14:36:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OMRWEff1jl8xTgAAbx9fmQ (envelope-from ) for ; Tue, 20 Oct 2020 14:36:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F5159401BE for ; Tue, 20 Oct 2020 14:36:38 +0000 (UTC) Received: from localhost ([::1]:54522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUske-0008B8-Jc for larch@yhetil.org; Tue, 20 Oct 2020 10:36:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUsk8-00089i-6y for bug-guix@gnu.org; Tue, 20 Oct 2020 10:36:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUsk6-0001Mp-FR for bug-guix@gnu.org; Tue, 20 Oct 2020 10:36:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUsk6-0001Gb-DQ for bug-guix@gnu.org; Tue, 20 Oct 2020 10:36:02 -0400 Subject: bug#43890: =?UTF-8?Q?=E2=80=98package-input-rewriting/spec=E2=80=99?= can introduce unnecessary variants Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Tue, 20 Oct 2020 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43890 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 43890-done@debbugs.gnu.org Mail-Followup-To: 43890@debbugs.gnu.org, ludo@gnu.org, ludovic.courtes@inria.fr Received: via spool by 43890-done@debbugs.gnu.org id=D43890.16032045514845 (code D ref 43890); Tue, 20 Oct 2020 14:36:02 +0000 Received: (at 43890-done) by debbugs.gnu.org; 20 Oct 2020 14:35:51 +0000 Received: from localhost ([127.0.0.1]:46264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUsjq-0001G0-T4 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 10:35:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUsjm-0001Fl-DF for 43890-done@debbugs.gnu.org; Tue, 20 Oct 2020 10:35:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56569) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUsjh-0001K3-47 for 43890-done@debbugs.gnu.org; Tue, 20 Oct 2020 10:35:37 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46088 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUsjg-0006dm-IF for 43890-done@debbugs.gnu.org; Tue, 20 Oct 2020 10:35:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87v9fji2cv.fsf@inria.fr> Date: Tue, 20 Oct 2020 16:35:33 +0200 In-Reply-To: <87v9fji2cv.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 09 Oct 2020 22:14:08 +0200") Message-ID: <878sc1dky2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: rIGfHEidYDhT Ludovic Court=C3=A8s skribis: > Consider this example: > > $ guix describe > Generacio 162 Oct 01 2020 00:23:38 (nuna) > guix 7607ace > repository URL: https://git.savannah.gnu.org/git/guix.git > branch: master > commit: 7607ace5091aea0157ba5c8a508129cc5fc4f931 > $ guix build inkscape --no-grafts -d > /gnu/store/arjs5hb4wmy6dh5d3y8bbs808ki9abf8-inkscape-1.0.1.drv > $ guix build inkscape --no-grafts -d --with-graft=3Dglib=3Dglib-networking > /gnu/store/zd8mm3w6x9c97anfaly77fz28s5y3i5h-inkscape-1.0.1.drv > $ guix build inkscape --no-grafts -d --with-graft=3Dlibreoffice=3Dabiword > /gnu/store/arjs5hb4wmy6dh5d3y8bbs808ki9abf8-inkscape-1.0.1.drv > > The last one is fine: it has no effect. > > The second one is problematic: since we=E2=80=99re using =E2=80=98--no-gr= afts=E2=80=99, the > =E2=80=98--with-graft=E2=80=99 option should have absolutely no effect; y= et, it yields a > different derivation. Fixed in 8db4ebb0cd9bfdcf1aea63eb8d20eb6af0c87c93. \o/ It makes =E2=80=98--with-debug-info=E2=80=99 more practical. The difficulty is to find out where the difference is and what piece of code introduced a non-eq?-but-equal package. Likewise, the test suite catches corner cases that can take a while to address. Related to that, commit 6b4663363c061071c10209f71aed1017a241af6c deletes duplicates in =E2=80=98bag->derivation=E2=80=99, which should make the whol= e thing less sensitive to the introduction of non-eq?-but-equal packages in the graph. Ludo=E2=80=99.