From: "Ludovic Courtès" <ludo@gnu.org>
To: 43890-done@debbugs.gnu.org
Subject: bug#43890: ‘package-input-rewriting/spec’ can introduce unnecessary variants
Date: Tue, 20 Oct 2020 16:35:33 +0200 [thread overview]
Message-ID: <878sc1dky2.fsf@gnu.org> (raw)
In-Reply-To: <87v9fji2cv.fsf@inria.fr> ("Ludovic Courtès"'s message of "Fri, 09 Oct 2020 22:14:08 +0200")
Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
> Consider this example:
>
> $ guix describe
> Generacio 162 Oct 01 2020 00:23:38 (nuna)
> guix 7607ace
> repository URL: https://git.savannah.gnu.org/git/guix.git
> branch: master
> commit: 7607ace5091aea0157ba5c8a508129cc5fc4f931
> $ guix build inkscape --no-grafts -d
> /gnu/store/arjs5hb4wmy6dh5d3y8bbs808ki9abf8-inkscape-1.0.1.drv
> $ guix build inkscape --no-grafts -d --with-graft=glib=glib-networking
> /gnu/store/zd8mm3w6x9c97anfaly77fz28s5y3i5h-inkscape-1.0.1.drv
> $ guix build inkscape --no-grafts -d --with-graft=libreoffice=abiword
> /gnu/store/arjs5hb4wmy6dh5d3y8bbs808ki9abf8-inkscape-1.0.1.drv
>
> The last one is fine: it has no effect.
>
> The second one is problematic: since we’re using ‘--no-grafts’, the
> ‘--with-graft’ option should have absolutely no effect; yet, it yields a
> different derivation.
Fixed in 8db4ebb0cd9bfdcf1aea63eb8d20eb6af0c87c93. \o/
It makes ‘--with-debug-info’ more practical.
The difficulty is to find out where the difference is and what piece of
code introduced a non-eq?-but-equal package. Likewise, the test suite
catches corner cases that can take a while to address.
Related to that, commit 6b4663363c061071c10209f71aed1017a241af6c deletes
duplicates in ‘bag->derivation’, which should make the whole thing less
sensitive to the introduction of non-eq?-but-equal packages in the
graph.
Ludo’.
prev parent reply other threads:[~2020-10-20 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 20:14 bug#43890: ‘package-input-rewriting/spec’ can introduce unnecessary variants Ludovic Courtès
2020-10-11 13:09 ` Ludovic Courtès
2020-10-20 14:35 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sc1dky2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43890-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).