bug#31602: libreoffice not reproducible

bug#31602: libreoffice not reproducible

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

libreoffice 5.4.7.2 is not reproducible:

│ │ ├── presets
│ │ │ ├── autotext
│ │ │ │ ├── mytexts.bau

and similar bau files

│ │ │ ├── autocorr
│ │ │ │ ├── acor_af-ZA.dat

and similar dat files

│ │ │ ├── config
│ │ │ │ ├── images_breeze.zip

and similar zip files

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#31602: libreoffice not reproducible

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

These are actually all zip files.  The reason for the non-reproducibility is
that something copies the contents from the source to a mktemp'ed directory
without preserving timestamps.  Then this directory is zipped up.

So the zip file now contains non-constant timestamps.

I think it's somewhere in postprocess, but I can't find it so far.

I found packimages.pl but I'm not sure whether this does the copying, too.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#31602: libreoffice not reproducible

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> These are actually all zip files.  The reason for the non-reproducibility is
> that something copies the contents from the source to a mktemp'ed directory
> without preserving timestamps.  Then this directory is zipped up.

Without *clearing* timestamps?

> So the zip file now contains non-constant timestamps.
>
> I think it's somewhere in postprocess, but I can't find it so far.

Perhaps we could add a phase that unpacks-resets-repacks these?  Or,
alternately, something like the Debian/R-B tool (I forgot the name) that
does that automatically.

Thanks,
Ludo’.

bug#31602: libreoffice not reproducible

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Hi Ludo,

On Tue, 29 May 2018 19:21:40 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Danny Milosavljevic <dannym@scratchpost.org> skribis:
> 
> > These are actually all zip files.  The reason for the non-reproducibility is
> > that something copies the contents from the source to a mktemp'ed directory
> > without preserving timestamps.  Then this directory is zipped up.  
> 
> Without *clearing* timestamps?

I think it's something like this:

src/foo.png exists with the source timestamp (which is constant for this version).

Something does mktemp, then copies the src/foo.png there without preserving timestamps.

Then this temp directory is zipped up.  Now it has the wrong (different, more current)
timestamps in it.

> Perhaps we could add a phase that unpacks-resets-repacks these?  Or,
> alternately, something like the Debian/R-B tool (I forgot the name) that
> does that automatically.

As a fallback - sure.

For now I've been trying to find the place in libreoffice where
it does the copying and patch that and upstream it.

I tried Zip.mk but seems that's not actually used (?).


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#31602: libreoffice not reproducible

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> libreoffice 5.4.7.2 is not reproducible:

It’s still the case, here’s a complete list of files:

--8<---------------cut here---------------start------------->8---
$ guix challenge libreoffice --substitute-urls='https://ci.guix.gnu.org https://bayfront.guix.gnu.org'
/gnu/store/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2 contents differ:
  no local build for '/gnu/store/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2'
  https://ci.guix.gnu.org/nar/lzip/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2: 0fa8az4i1msscynapb9a8rn07w1q7j2bq441xwd4a38xvs3qrmz6
  https://bayfront.guix.gnu.org/nar/lzip/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2: 0mbh0ibhy548gln9a4b9q62w8y3pndils24g04wbpx92ysc7jidr
  differing files:
    /lib/libreoffice/share/template/common/styles/Modern.ott
    /lib/libreoffice/share/template/common/styles/Default.ott
    /lib/libreoffice/share/template/common/presnt/Vivid.otp
    /lib/libreoffice/share/template/common/presnt/Vintage.otp
    /lib/libreoffice/share/template/common/presnt/Sunset.otp
    /lib/libreoffice/share/template/common/presnt/Progress.otp
    /lib/libreoffice/share/template/common/presnt/Portfolio.otp
    /lib/libreoffice/share/template/common/presnt/Piano.otp
    /lib/libreoffice/share/template/common/presnt/Pencil.otp
    /lib/libreoffice/share/template/common/presnt/Nature_Illustration.otp
    /lib/libreoffice/share/template/common/presnt/Midnightblue.otp
    /lib/libreoffice/share/template/common/presnt/Metropolis.otp
    /lib/libreoffice/share/template/common/presnt/LushGreen.otp
    /lib/libreoffice/share/template/common/presnt/Lights.otp
    /lib/libreoffice/share/template/common/presnt/Inspiration.otp
    /lib/libreoffice/share/template/common/presnt/Impress.otp
    /lib/libreoffice/share/template/common/presnt/Forestbird.otp
    /lib/libreoffice/share/template/common/presnt/Focus.otp
    /lib/libreoffice/share/template/common/presnt/DNA.otp
    /lib/libreoffice/share/template/common/presnt/Classy_Red.otp
    /lib/libreoffice/share/template/common/presnt/BrightBlue.otp
    /lib/libreoffice/share/template/common/presnt/Blueprint_Plans.otp
    /lib/libreoffice/share/template/common/presnt/Blue_Curve.otp
    /lib/libreoffice/share/template/common/presnt/Beehive.otp
    /lib/libreoffice/share/template/common/presnt/Alizarin.otp
    /lib/libreoffice/share/template/common/personal/Resume1page.ott
    /lib/libreoffice/share/template/common/personal/CV.ott
    /lib/libreoffice/share/template/common/offimisc/Businesscard-with-logo.ott
    /lib/libreoffice/share/template/common/officorr/Modern_business_letter_serif.ott
    /lib/libreoffice/share/template/common/officorr/Modern_business_letter_sans_serif.ott
    /lib/libreoffice/share/config/images_tango.zip
    /lib/libreoffice/share/config/images_sifr_svg.zip
    /lib/libreoffice/share/config/images_sifr_dark_svg.zip
    /lib/libreoffice/share/config/images_sifr_dark.zip
    /lib/libreoffice/share/config/images_sifr.zip
    /lib/libreoffice/share/config/images_karasa_jaga_svg.zip
    /lib/libreoffice/share/config/images_karasa_jaga.zip
    /lib/libreoffice/share/config/images_elementary_svg.zip
    /lib/libreoffice/share/config/images_elementary.zip
    /lib/libreoffice/share/config/images_colibre_svg.zip
    /lib/libreoffice/share/config/images_colibre.zip
    /lib/libreoffice/share/config/images_breeze_svg.zip
    /lib/libreoffice/share/config/images_breeze_dark_svg.zip
    /lib/libreoffice/share/config/images_breeze_dark.zip
    /lib/libreoffice/share/config/images_breeze.zip
    /lib/libreoffice/share/autotext/en-US/template.bau
    /lib/libreoffice/share/autotext/en-US/standard.bau
    /lib/libreoffice/share/autotext/en-US/crdbus50.bau
    /lib/libreoffice/share/autocorr/acor_zh-TW.dat
    /lib/libreoffice/share/autocorr/acor_zh-CN.dat
    /lib/libreoffice/share/autocorr/acor_vi-VN.dat
    /lib/libreoffice/share/autocorr/acor_tr-TR.dat
    /lib/libreoffice/share/autocorr/acor_sv-SE.dat
    /lib/libreoffice/share/autocorr/acor_sr-RS.dat
    /lib/libreoffice/share/autocorr/acor_sr-ME.dat
    /lib/libreoffice/share/autocorr/acor_sr-Latn-RS.dat
    /lib/libreoffice/share/autocorr/acor_sr-Latn-ME.dat
    /lib/libreoffice/share/autocorr/acor_sr-Latn-CS.dat
    /lib/libreoffice/share/autocorr/acor_sr-CS.dat
    /lib/libreoffice/share/autocorr/acor_sl-SI.dat
    /lib/libreoffice/share/autocorr/acor_sk-SK.dat
    /lib/libreoffice/share/autocorr/acor_ru-RU.dat
    /lib/libreoffice/share/autocorr/acor_ro-RO.dat
    /lib/libreoffice/share/autocorr/acor_pt-PT.dat
    /lib/libreoffice/share/autocorr/acor_pt-BR.dat
    /lib/libreoffice/share/autocorr/acor_pl-PL.dat
    /lib/libreoffice/share/autocorr/acor_nl-NL.dat
    /lib/libreoffice/share/autocorr/acor_nl-BE.dat
    /lib/libreoffice/share/autocorr/acor_mn-MN.dat
    /lib/libreoffice/share/autocorr/acor_lt-LT.dat
    /lib/libreoffice/share/autocorr/acor_lb-LU.dat
    /lib/libreoffice/share/autocorr/acor_ko-KR.dat
    /lib/libreoffice/share/autocorr/acor_ja-JP.dat
    /lib/libreoffice/share/autocorr/acor_it.dat
    /lib/libreoffice/share/autocorr/acor_is-IS.dat
    /lib/libreoffice/share/autocorr/acor_hu-HU.dat
    /lib/libreoffice/share/autocorr/acor_hsb.dat
    /lib/libreoffice/share/autocorr/acor_hr-HR.dat
    /lib/libreoffice/share/autocorr/acor_ga-IE.dat
    /lib/libreoffice/share/autocorr/acor_fr.dat
    /lib/libreoffice/share/autocorr/acor_fi-FI.dat
    /lib/libreoffice/share/autocorr/acor_fa-IR.dat
    /lib/libreoffice/share/autocorr/acor_es.dat
    /lib/libreoffice/share/autocorr/acor_en-ZA.dat
    /lib/libreoffice/share/autocorr/acor_en-US.dat
    /lib/libreoffice/share/autocorr/acor_en-GB.dat
    /lib/libreoffice/share/autocorr/acor_en-AU.dat
    /lib/libreoffice/share/autocorr/acor_el-GR.dat
    /lib/libreoffice/share/autocorr/acor_dsb.dat
    /lib/libreoffice/share/autocorr/acor_de.dat
    /lib/libreoffice/share/autocorr/acor_da-DK.dat
    /lib/libreoffice/share/autocorr/acor_cs-CZ.dat
    /lib/libreoffice/share/autocorr/acor_ca-ES.dat
    /lib/libreoffice/share/autocorr/acor_bg-BG.dat
    /lib/libreoffice/share/autocorr/acor_af-ZA.dat
    /lib/libreoffice/presets/autotext/mytexts.bau
--8<---------------cut here---------------end--------------->8---

And indeed, all the template files as well as *.dat files are actually
zip files with embedded timestamps.

Ludo’.

bug#31602: libreoffice not reproducible

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Finally fixed in commit 0d5578c12beec105f5ec113cc50deab703270a82:

  ~$ guix environment --pure guix -- ./pre-inst-env guix build \
     --{check,no-grafts} libreoffice
  successfully built /gnu/store/...-libreoffice-6.4.6.2.drv
  successfully built /gnu/store/...-libreoffice-6.4.6.2.drv
  /gnu/store/25q6nl2l2k3nks0rrh2ah5qsxr3mqy3a-libreoffice-6.4.6.2

Closing, though it remains to be seen whether it works across file 
systems.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]