unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Jonathan Brielmaier <jonathan.brielmaier@web.de>
Cc: 51425-done@debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#51425: file-system: validate flags
Date: Sun, 07 Nov 2021 23:16:17 +0100	[thread overview]
Message-ID: <878rxzk3wu.fsf@gnu.org> (raw)
In-Reply-To: <87cznny78b.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 29 Oct 2021 21:13:40 +0200")

Hi,

Ludovic Courtès <ludo@gnu.org> skribis:

> Jonathan Brielmaier <jonathan.brielmaier@web.de> skribis:
>
>> Imagine the following file system definition in your config.scm:
>>
>> ```
>> (file-system
>>   (device (uuid "UUID-123"))
>>   (flags '((create-mount-point? #t)))
>>   (mount-point "/mnt")
>>   (type "ext4")))
>> ```
>>
>> When you reconfigure there will be no complain, but when you reboot your
>> system wont boot.
>
> I suppose it fails to boot because of a match error in
> ‘mount-flags->bit-mask’, right?
>
>> The parameter to flags is nonsense, it should be something like:
>> `read-only`. So mounting of the file system will fail...
>
> That’s a good use case for the recently-added ‘sanitize’ record field
> property.

Done in 5eb5c0789f34e87ee417a53ddfcfa3b6521bb337.

Thanks,
Ludo’.




      reply	other threads:[~2021-11-07 22:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 22:24 bug#51425: file-system: validate flags Jonathan Brielmaier
2021-10-28  1:31 ` Maxim Cournoyer
2021-10-29 19:41   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-10-30  0:45     ` Maxim Cournoyer
2021-10-30  0:48       ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-10-31  2:31         ` Maxim Cournoyer
2021-10-29 19:13 ` Ludovic Courtès
2021-11-07 22:16   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rxzk3wu.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=51425-done@debbugs.gnu.org \
    --cc=jonathan.brielmaier@web.de \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).