From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cOwHLQW27mFkcwAAgWs5BA (envelope-from ) for ; Mon, 24 Jan 2022 15:21:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kOGuJQW27mH1LgAAG6o9tA (envelope-from ) for ; Mon, 24 Jan 2022 15:21:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 429173BB20 for ; Mon, 24 Jan 2022 15:21:57 +0100 (CET) Received: from localhost ([::1]:44804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nC0EG-00056x-7H for larch@yhetil.org; Mon, 24 Jan 2022 09:21:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nC0BS-0002kI-I3 for bug-guix@gnu.org; Mon, 24 Jan 2022 09:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nC0BS-00057D-8L for bug-guix@gnu.org; Mon, 24 Jan 2022 09:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nC0BS-0005us-47 for bug-guix@gnu.org; Mon, 24 Jan 2022 09:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53406: union-build incorrectly handles grafts Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 24 Jan 2022 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: John Kehayias Received: via spool by 53406-submit@debbugs.gnu.org id=B53406.164303393422725 (code B ref 53406); Mon, 24 Jan 2022 14:19:02 +0000 Received: (at 53406) by debbugs.gnu.org; 24 Jan 2022 14:18:54 +0000 Received: from localhost ([127.0.0.1]:42663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nC0BJ-0005uR-OO for submit@debbugs.gnu.org; Mon, 24 Jan 2022 09:18:54 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:49168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nC0BH-0005uB-Ej for 53406@debbugs.gnu.org; Mon, 24 Jan 2022 09:18:53 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D2BEE2FE; Mon, 24 Jan 2022 15:18:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gtxcu_X0z0SL; Mon, 24 Jan 2022 15:18:43 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 5E6D78B; Mon, 24 Jan 2022 15:18:43 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 24 Jan 2022 15:18:42 +0100 In-Reply-To: (John Kehayias's message of "Fri, 21 Jan 2022 06:48:38 +0000") Message-ID: <878rv5ushp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: D2BEE2FE X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[protonmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[protonmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 53406@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643034117; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=h2UICTxMQdxFvN0/1YR7V7HG4mvNUqzjYF/o7F9ADgo=; b=mz0LntY2P3G4IrFEjxHEENqgHYRd2UMP4pL8CmkUd3Xu+QpF92zn2BBEbxEKmZ2yVI1h4V /yJ09Hn7vaJK93ljEmGxjCPhHlUOn67pkRF0tspBhQYP+oYYC++sMZMPJVC7SH5+Xe7Era wl/0imQ/l2soD9inldA0CUncY+pxuEveBVLDBVIZoyOc7yDx8lWplFw38nQV5DOJd0GA3U AmE/FRfJkduyTnIusHgDz4ov6Qe2bSFpKAernOGAkhLLVkeyUbToxLBZXsFYH6hTOaO+s9 gV6sJuIxzurWN9p06cyKzVBb1FtQ4Cp4xh9FXxkNzZCw8z/RU5Ls5xCHLlBR6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643034117; a=rsa-sha256; cv=none; b=kFED6nB2FNbq4RekGN5hEhrN6jddrFj0YM4/Ayok/rV4oOSJL7uaA+o09121MBO+JfW5EL Pe0uf8GrQ1SMTyD8u8ZU1ZlCANyAN6hOL2WCnzYmve/bOIyOAwi9sqGmNlbX7xIZ6BG0eX OK/TPomEX3nW2dKJSkmd0hmi3Yt9BtKIKSUfvgtbM1d2dhJAVPYyy9MDWw1BduCYWsg3VT /PlsOJq3zR98preUrd/LM3HPCqpwoL/sc6m9eCZ9K9fxh8AMmAnfOQqHCxab27RXHPZeIA zEg8IuP3VHRK73bF9VdfQoYUvLSSpQcISlOQ9fa5jqOqUeCVc5R5TKGNMbF0dA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.13 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 429173BB20 X-Spam-Score: -4.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: OCCLQhluA5Je Hi, John Kehayias skribis: > If I run the attached file with guix build -f graft-test.scm and look at = libexpat in the created package with, e.g. > > ls -la $(guix build -f graft-test.scm)/lib/libexpat* > > I get > > lrwxrwxrwx 1 root root 71 Dec 31 1969 /gnu/store/a3ixqfx1cfjgbz5gb925fv7= dwy2h55gs-fhs-union-0.0/lib/libexpat.la -> /gnu/store/2q8wwhd3prib0swky68rb= x9hl0xxs6hf-expat-2.4.3/lib/libexpat.la* > lrwxrwxrwx 1 root root 71 Dec 31 1969 /gnu/store/a3ixqfx1cfjgbz5gb925fv7= dwy2h55gs-fhs-union-0.0/lib/libexpat.so -> /gnu/store/2q8wwhd3prib0swky68rb= x9hl0xxs6hf-expat-2.4.3/lib/libexpat.so* > lrwxrwxrwx 1 root root 73 Dec 31 1969 /gnu/store/a3ixqfx1cfjgbz5gb925fv7= dwy2h55gs-fhs-union-0.0/lib/libexpat.so.1 -> /gnu/store/2q8wwhd3prib0swky68= rbx9hl0xxs6hf-expat-2.4.3/lib/libexpat.so.1* > lrwxrwxrwx 1 root root 77 Dec 31 1969 /gnu/store/a3ixqfx1cfjgbz5gb925fv7= dwy2h55gs-fhs-union-0.0/lib/libexpat.so.1.8.1 -> /gnu/store/2q8wwhd3prib0sw= ky68rbx9hl0xxs6hf-expat-2.4.3/lib/libexpat.so.1.8.1 > > Note that the last link is broken: looking at this expat library (2.4.3, = the replacement) it has > > -r-xr-xr-x 1 root root 961 Dec 31 1969 /gnu/store/2q8wwhd3prib0swky68rb= x9hl0xxs6hf-expat-2.4.3/lib/libexpat.la* > lrwxrwxrwx 1 root root 17 Dec 31 1969 /gnu/store/2q8wwhd3prib0swky68rb= x9hl0xxs6hf-expat-2.4.3/lib/libexpat.so -> libexpat.so.1.8.3* > lrwxrwxrwx 1 root root 17 Dec 31 1969 /gnu/store/2q8wwhd3prib0swky68rb= x9hl0xxs6hf-expat-2.4.3/lib/libexpat.so.1 -> libexpat.so.1.8.3* > -r-xr-xr-x 2 root root 191K Dec 31 1969 /gnu/store/2q8wwhd3prib0swky68rb= x9hl0xxs6hf-expat-2.4.3/lib/libexpat.so.1.8.3* > > This is why the last link from the union-build package is broken, it trie= s to point to libexpat.so.1.8.1 (the previous version, but in the newer ver= sion's directory). Grafting is a pretty basic process: in this case it replaces occurrences of /gnu/store/=E2=80=A6-expat-2.4.1 with /gnu/store/=E2=80=A6-expat-2.4.3, = nothing more. It cannot guess that libexpat.so.1.8.1 was renamed to libexpat.so.1.8.3 or anything like that. Is it a problem? Normally no, because users of shared libraries don=E2=80= =99t refer to libraries by their fully-qualified name: --8<---------------cut here---------------start------------->8--- $ objdump -x $(guix build dbus-glib)/bin/dbus-binding-tool|grep NEED.*expat NEEDED libexpat.so.1 $ objdump -x $(guix build dbus-glib)/bin/dbus-binding-tool|grep RUNPATH RUNPATH /gnu/store/wwmxxlmlhwljn39z0gsj6iai3zk67a2g-dbus-gli= b-0.110/lib:/gnu/store/5s6iz5f777rh23q4kv8gvqrsyy61cbjh-dbus-1.12.20/lib:/g= nu/store/s0w7szfsajdy6cnrz2w7z4h5spyl4aaj-expat-2.4.1/lib:/gnu/store/2fk1gz= 2s7ppdicynscra9b19byrrr866-glibc-2.33/lib:/gnu/store/90lbavffg0csrf208nw0ay= j1bz5knl47-gcc-10.3.0-lib/lib:/gnu/store/qqs98rxwjrji6aaf6dqwp7q4m545g2sn-g= lib-2.70.0/lib:/gnu/store/90lbavffg0csrf208nw0ayj1bz5knl47-gcc-10.3.0-lib/l= ib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../.. --8<---------------cut here---------------end--------------->8--- Likewise, =E2=80=98etc/ld.so.cache=E2=80=99 contains a reference to =E2=80= =98libexpat.so.1=E2=80=99, not to =E2=80=98libexpat.so.1.8.1=E2=80=99. Does that make sense? Or am I overlooking something? Thanks, Ludo=E2=80=99.