From: "Feng Shu" <tumashu@163.com>
To: 54558@debbugs.gnu.org
Cc: Feng Shu <tumashu@163.com>
Subject: bug#54558: Mcomix 2.0.1 do not install locale data.
Date: Sun, 27 Mar 2022 17:52:04 +0800 [thread overview]
Message-ID: <878rsvg1tn.fsf@163.com> (raw)
In-Reply-To: <87sfr3zqdg.fsf@163.com> (Feng Shu's message of "Sun, 27 Mar 2022 17:39:07 +0800")
[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]
"Feng Shu" <tumashu@163.com> writes:
> "Feng Shu" <tumashu@163.com> writes:
>
>> I think Mcomix 2.0.1 do not install locale date.
>
> I try to code a patch:
>
> From bc1627e85cde9569b96057daa863184566863858 Mon Sep 17 00:00:00 2001
> From: Feng Shu <tumashu@163.com>
> Date: Sun, 27 Mar 2022 17:35:13 +0800
> Subject: [PATCH] gnu: mcomix: Install messages directory.
>
> * gnu/packages/image-viewers.scm (mcomix)
> [arguments]: Install messages directory.
> ---
> gnu/packages/image-viewers.scm | 51 +++++++++++++++++-----------------
> 1 file changed, 26 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
> index 05a8151c29..7410605077 100644
> --- a/gnu/packages/image-viewers.scm
> +++ b/gnu/packages/image-viewers.scm
> @@ -695,31 +695,32 @@ (define-public mcomix
> (substitute* "mcomix/image_tools.py"
> (("assert name not in supported_formats_gdk")
> "if name in supported_formats_gdk: continue"))))
> - (add-after 'install 'install-data
> - (lambda* (#:key outputs #:allow-other-keys)
> - (copy-recursively
> - "mcomix/images"
> - (string-append (assoc-ref outputs "out")
> - "/lib/python"
> - #$(version-major+minor
> - (package-version (this-package-input "python")))
> - "/site-packages/mcomix/images"))))
> - (add-after 'install 'install-messages
> - (lambda* (#:key outputs #:allow-other-keys)
> - (copy-recursively
> - "mcomix/messages"
> - (string-append (assoc-ref outputs "out")
> - "/share/locale"))))
> - (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
> - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
> - (add-after 'wrap 'gi-wrap
> - (lambda* (#:key outputs #:allow-other-keys)
> - (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> - (for-each
> - (lambda (prog)
> - (wrap-program prog
> - `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> - (list (string-append bin "/mcomix")))))))))
> + (add-after 'install 'install-data
> + (lambda* (#:key outputs #:allow-other-keys)
> + (copy-recursively
> + "mcomix/images"
> + (string-append (assoc-ref outputs "out")
> + "/lib/python"
> + #$(version-major+minor
> + (package-version (this-package-input "python")))
> + "/site-packages/mcomix/images"))
> + (copy-recursively
> + "mcomix/messages"
> + (string-append (assoc-ref outputs "out")
> + "/lib/python"
> + #$(version-major+minor
> + (package-version (this-package-input "python")))
> + "/site-packages/mcomix/messages"))))
> + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
> + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
> + (add-after 'wrap 'gi-wrap
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (for-each
> + (lambda (prog)
> + (wrap-program prog
> + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> + (list (string-append bin "/mcomix")))))))))
> (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
> (synopsis "Image viewer for comics")
> (description "MComix is a customizable image viewer that specializes as
> --
> 2.34.0
Sorry, the above is wrong patch, please see below:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-mcomix-Install-messages-directory.patch --]
[-- Type: text/x-patch, Size: 3418 bytes --]
From a84f1c8d1ad923f2b90fdf40a0655f8015f122a8 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Sun, 27 Mar 2022 17:47:52 +0800
Subject: [PATCH] gnu: mcomix: Install messages directory.
* gnu/packages/image-viewers.scm (mcomix)
[arguments]: Install messages directory.
---
gnu/packages/image-viewers.scm | 45 ++++++++++++++++++++--------------
1 file changed, 26 insertions(+), 19 deletions(-)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 09c448e8f5..7410605077 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -695,25 +695,32 @@ (define-public mcomix
(substitute* "mcomix/image_tools.py"
(("assert name not in supported_formats_gdk")
"if name in supported_formats_gdk: continue"))))
- (add-after 'install 'install-data
- (lambda* (#:key outputs #:allow-other-keys)
- (copy-recursively
- "mcomix/images"
- (string-append (assoc-ref outputs "out")
- "/lib/python"
- #$(version-major+minor
- (package-version (this-package-input "python")))
- "/site-packages/mcomix/images"))))
- (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
- (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
- (add-after 'wrap 'gi-wrap
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
- (for-each
- (lambda (prog)
- (wrap-program prog
- `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
- (list (string-append bin "/mcomix")))))))))
+ (add-after 'install 'install-data
+ (lambda* (#:key outputs #:allow-other-keys)
+ (copy-recursively
+ "mcomix/images"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/images"))
+ (copy-recursively
+ "mcomix/messages"
+ (string-append (assoc-ref outputs "out")
+ "/lib/python"
+ #$(version-major+minor
+ (package-version (this-package-input "python")))
+ "/site-packages/mcomix/messages"))))
+ (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap
+ (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
+ (add-after 'wrap 'gi-wrap
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
+ (for-each
+ (lambda (prog)
+ (wrap-program prog
+ `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
+ (list (string-append bin "/mcomix")))))))))
(home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
(synopsis "Image viewer for comics")
(description "MComix is a customizable image viewer that specializes as
--
2.34.0
[-- Attachment #3: Type: text/plain, Size: 7 bytes --]
--
prev parent reply other threads:[~2022-03-27 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 20:08 bug#54558: mcomix refuses to run, missing GTK libraries Natalie
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
2022-03-26 2:57 ` bug#54558: mcomix refuses to run, missing GTK libraries Maxim Cournoyer
2022-03-26 8:01 ` Liliana Marie Prikler
2022-03-25 22:45 ` bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths Liliana Marie Prikler
2022-03-27 2:26 ` bug#54558: Mcomix 2.0.1 do not install locale data Feng Shu
2022-03-27 9:39 ` Feng Shu
2022-03-27 9:52 ` Feng Shu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsvg1tn.fsf@163.com \
--to=tumashu@163.com \
--cc=54558@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).