From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SIjyGZ+UkmLLZwEAbAwnHQ (envelope-from ) for ; Sat, 28 May 2022 23:31:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CBQbGZ+UkmI7LAEAG6o9tA (envelope-from ) for ; Sat, 28 May 2022 23:31:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD34F17534 for ; Sat, 28 May 2022 23:31:10 +0200 (CEST) Received: from localhost ([::1]:54350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nv41e-0000NA-0j for larch@yhetil.org; Sat, 28 May 2022 17:31:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nv41W-0000Ml-GG for bug-guix@gnu.org; Sat, 28 May 2022 17:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nv41W-00027i-7s for bug-guix@gnu.org; Sat, 28 May 2022 17:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nv41W-0008HD-1v for bug-guix@gnu.org; Sat, 28 May 2022 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54786: Installation tests are failing Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 28 May 2022 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54786 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: Mathieu Othacehe , 54786@debbugs.gnu.org Received: via spool by 54786-submit@debbugs.gnu.org id=B54786.165377340531675 (code B ref 54786); Sat, 28 May 2022 21:31:02 +0000 Received: (at 54786) by debbugs.gnu.org; 28 May 2022 21:30:05 +0000 Received: from localhost ([127.0.0.1]:38996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nv40a-0008Eo-Ir for submit@debbugs.gnu.org; Sat, 28 May 2022 17:30:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nv40X-0008Dr-BN for 54786@debbugs.gnu.org; Sat, 28 May 2022 17:30:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nv40S-0001m7-45; Sat, 28 May 2022 17:29:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cALznP336b0XzYnr8OoUIaupIzl/sSXL44N3jg0JGsE=; b=kT0d84/nq5832BSr4VKV d89sr4JZxm6ny/2vHTeVTErXZzl84CLl7mvcLW9sZxFN+FGkmqGdqxT7OHlW+IMdoA8uPd00h/wQm tDG9SSiGJ9fDUM7JoFYxyh0Mmmsna1NZKEmTbCbzg8p6RgXuBnD00nNFyFLw04rkfT64dh5K8Bjkg woPswpFaU/q/amcO2K6YAsZ6guZaFTBCO+EvL6GUn/m6sSE6/WnTjsEIMvO2der1gmSjepmOSymRH FiJqXyUkt2n80Y1FOXFSgeOhMzRtc/6/CY/FByZg2IQJuquAq2qBY9xMc8x8JGBBzpAdsF6NTf+Bl Qm/bifetpcCMig==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56035 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nv40R-0003SK-N4; Sat, 28 May 2022 17:29:55 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87r167rjhv.fsf@gnu.org> <87v8vjwqzk.fsf@gnu.org> <87zgk5brkd.fsf@gnu.org> <87y1zpaud6.fsf@gnu.org> <87mtg3655a.fsf@gnu.org> <875ymqwwq8.fsf@gnu.org> <875ymp4c5f.fsf@gnu.org> <87a6b646qs.fsf@gmail.com> Date: Sat, 28 May 2022 23:29:54 +0200 In-Reply-To: <87a6b646qs.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 24 May 2022 23:43:23 -0400") Message-ID: <878rql9wh9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653773471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cALznP336b0XzYnr8OoUIaupIzl/sSXL44N3jg0JGsE=; b=pQB2MYhfcwjeMeS8W/xovHYzmGn4Kxy5qjUVdjbikxdCUTXeH6kQ/oowUrX8gkizdKSV01 bLKuIORjiI34taE+/DgXBpuVC8em1r1k71hEZMWp1e7pqQZCBCXEpHCG6J8x1T53DQ2b5I MvOw62B/sXTlhbPqimXREXEzOaYq7+8pWhc89DdGF2iB3D3CLS87obkDiS2Pz/ccuQRmeV zggTn+XTUvyK92Dezbq0ezbJzSi99dedswdX/AbVEoWiiBz8KP29iQU6Z01syvwW54lDN3 5bboVgMAtTExnxJsWu5KRAOtLb1ld3DOh2g5vJ0XuOjf+Xy2KN0KSHWMomT/iQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653773471; a=rsa-sha256; cv=none; b=KvhNgrh24CbTEpw1yGT+SwDQwRbM5Xl8nDGYZebqV/kB28elFljw7tEJy3qKBRZ9V3k5QE P5iKudHTsTa2O2ixCP/W7JHvaK6G4YO9dwvB1CSbALojuusVmTaoukJKMZv8FaMzbdzkAq ETzrgfFR1kYKTicGQBuAGVStMZRjF2d511FRBuX/aauE9IY8a+6Md144jJOFMEPsidqXVb liOUVI/SqNSjNmlrHsTrD0fRcgrEJGDotZ7NacqmR42kyxDOqv8xyqEw6mLvz9I7Jm0U1K jUL7hcXZkLd2QyXONsnvLjcznhJpRME5VjmkWNrUI3AeQGxDtDD0FJ9yurHdmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="kT0d84/n"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="kT0d84/n"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CD34F17534 X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: /IZrJo86F64a --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> Hi, >> >> Mathieu Othacehe skribis: >> >>> Thanks for the fix! The jami and jami-provisioning tests are also broken >>> because of what looks like to be the same issue: >>> >>> One does not simply initialize the client: Another daemon is detected >>> /gnu/store/01phrvxnxrg1q0gxa35g7f77q06crf6v-shepherd-marionette.scm:1:1= 718: ERROR: >>> 1. &action-exception-error: >>> service: jami >>> action: start >>> key: match-error >>> args: ("match" "no matching pattern" #f) >>> Jami Daemon 11.0.0, by Savoir-faire Linux 2004-2019 >>> https://jami.net/ >>> [Video support enabled] >>> [Plugins support enabled] >> >> Yes, I noticed that, but I=E2=80=99m not sure how to apply a similar wor= karound. > > I tried fixing that today, but so far I've only managed to understand > what seems to be going wrong, with this (not so great) workflow: While working on , I figured =E2=80=98wait-for-service=E2=80=99 could be useful for system tests that we= re previously using =E2=80=98start-service=E2=80=99 as a way to wait for a service to be = up and running. I tried the following change, which should be semantically equivalent to what was happening with the Shepherd 0.8. However, it doesn=E2=80=99t seem= to work, for reasons that escape me. Thoughts? Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/tests/telephony.scm b/gnu/tests/telephony.scm index bc464a431a..c219868859 100644 --- a/gnu/tests/telephony.scm +++ b/gnu/tests/telephony.scm @@ -145,11 +145,7 @@ (define marionette (marionette-eval '(begin (use-modules (gnu services herd)) - (match (start-service 'jami) - (#f #f) - (('service response-parts ...) - (match (assq-ref response-parts 'running) - ((pid) (number? pid)))))) + (wait-for-service 'jami #:timeout 60)) marionette)) (test-assert "service can be stopped" @@ -158,12 +154,7 @@ (define marionette (use-modules (gnu services herd) (rnrs base)) (setenv "PATH" "/run/current-system/profile/bin") - (let ((pid (match (start-service 'jami) - (#f #f) - (('service response-parts ...) - (match (assq-ref response-parts 'running) - ((pid) pid)))))) - + (let ((pid (wait-for-service 'jami))) (assert (number? pid)) (match (stop-service 'jami) @@ -193,14 +184,10 @@ (define pid (match (start-service 'jami) ;; Restart the service. (restart-service 'jami) - (define new-pid (match (start-service 'jami) - (#f #f) - (('service response-parts ...) - (match (assq-ref response-parts 'running) - ((pid) pid))))) + (define new-pid (wait-for-service 'jami)) (assert (number? new-pid)) - (not (eq? pid new-pid))) + (not (= pid new-pid))) marionette)) (unless #$provisioning? (test-skip 1)) --=-=-=--