From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CLfHHtDwx2KcVgAAbAwnHQ (envelope-from ) for ; Fri, 08 Jul 2022 10:54:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kC5kHtDwx2IHPQAAauVa8A (envelope-from ) for ; Fri, 08 Jul 2022 10:54:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03DC816D74 for ; Fri, 8 Jul 2022 10:54:40 +0200 (CEST) Received: from localhost ([::1]:57102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9jl1-0006Pu-3m for larch@yhetil.org; Fri, 08 Jul 2022 04:54:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9jkQ-0006Me-AZ for bug-guix@gnu.org; Fri, 08 Jul 2022 04:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9jkQ-0003dJ-1D for bug-guix@gnu.org; Fri, 08 Jul 2022 04:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9jkP-0000s9-VM for bug-guix@gnu.org; Fri, 08 Jul 2022 04:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#40641: Building from git breaks when /bin/sh isn't bash Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 08 Jul 2022 08:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40641 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 40641@debbugs.gnu.org, elaexuotee@wilsonb.com Received: via spool by 40641-submit@debbugs.gnu.org id=B40641.16572704123266 (code B ref 40641); Fri, 08 Jul 2022 08:54:01 +0000 Received: (at 40641) by debbugs.gnu.org; 8 Jul 2022 08:53:32 +0000 Received: from localhost ([127.0.0.1]:58775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jjw-0000qc-Dr for submit@debbugs.gnu.org; Fri, 08 Jul 2022 04:53:32 -0400 Received: from relay.yourmailgateway.de ([188.68.61.102]:36469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jjs-0000qO-WF for 40641@debbugs.gnu.org; Fri, 08 Jul 2022 04:53:31 -0400 Received: from mors-relay-8403.netcup.net (localhost [127.0.0.1]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4LfRrl4Fngz80CR; Fri, 8 Jul 2022 10:53:27 +0200 (CEST) Received: from policy02-mors.netcup.net (unknown [46.38.225.53]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4LfRrl3tKVz80CQ; Fri, 8 Jul 2022 10:53:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4LfRrj21SXz8sb1; Fri, 8 Jul 2022 10:53:25 +0200 (CEST) Received: from florianrock64 (ip5b40552a.dynamic.kabel-deutschland.de [91.64.85.42]) by mxe217.netcup.net (Postfix) with ESMTPSA id 9A6DB8291C; Fri, 8 Jul 2022 10:53:22 +0200 (CEST) From: "pelzflorian (Florian Pelz)" References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@wilsonb.com> <20200415122149.j7b6bcgvrp5cpq5l@pelzflorian.localdomain> <38M8QJ1PDKHCI.2ZBQF20W9BE03@wilsonb.com> <87h74tgxui.fsf@gmail.com> <20220613144005.gv2j5igdmisnaiqv@pelzflorian.localdomain> <874k0nfcq6.fsf@gmail.com> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM> <20220621090254.kyskzwkliku53mob@pelzflorian.localdomain> <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@mx.google.com> <87edywvbdz.fsf@gmail.com> Date: Fri, 08 Jul 2022 10:53:21 +0200 In-Reply-To: <87edywvbdz.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 07 Jul 2022 17:52:24 -0400") Message-ID: <878rp4c7em.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NC-CID: 8lqXCD3C//hJrSAnMyKx0p/BDHk8vu1zQ8I7RBUyMMTsUTf1F/lceXEO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657270480; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=oJYnxzItYwOwSdCrDfyIc71MiJTuJjQKeFnU2VB44/g=; b=jhHyF/WHRXOdOEdWZynWcsP7an7h9xp21JTIkAWQfNJhLUNKPZOwH3htxfokM3X07KFz5Z OBYlWmiuhXVjsKh6hPPQy/j8VAMHBazHQkFDYvN3/ge1TWUevk1X96oAa/w676dqmfLlYB ay7Yvn8Jc2deylvy7bkcK5olUfocMfyGiGFDNaA2PG797QFIZJpCOeYbL5bsjugCGZuM8k +ZtlfO029emhOPeqbOxrXYYNJ7NCAaSe1rW8BysfAcQD834b3q0qRMzjRraV0Fe7ZcUiUf UVdS0/wa+l54HFab0o5Emkuqb4Ob3Xpgmh4YDEAaEHV6X4ydJQHBqpqvGrKk5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657270480; a=rsa-sha256; cv=none; b=Cz+RHA9jITYTmrSOnngFkUoF87Nk5dSCVHNBg8aTPGoS4omQVgXRNZ+ueo7jl5ErHnz0Jj C/Mn+5g9ln2NGaJLIzv9EQbq1KoIZxtHmN+1cYyAIUnsGr9OhxF4OqtQlF9ulkQ8gzOAua bLtFfAr1q9+KIsu4AYS2CONTG4BuQ5qNX9khIK5rC8uLnaLaaJzKhzFbPkSFxH2g1+/XQm 7QeGTbIzRhPIaocGhrqPloK6+XRXxxuYXagX1BtoQnGJ8fNFL1ksiW8Bho5x5MtyZZkU20 rh1IoeyBrHAefhuE+UMZyM2vMnCrDC7DJnaOAU+F7axlttrUGLXp7eWZ01+OEA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03DC816D74 X-Spam-Score: -4.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9WlstxGv/jkQ Wait wait Maxim, the discussion was that "B. Wilson" proposed > [PATCH] build: Let make use its hard-coded default shell > To: guix-patches@gnu.org > > * configure.ac: Set AM_SUBST_NOTMAKE([SHELL]) > +# Use make's hard-coded default shell. The make in a guix profile > +# defaults to the Right Thing, e.g. $GUIX_ENVIRONMENT/bin/sh > +AM_SUBST_NOTMAKE([SHELL]) =20 Then Maxim Cournoyer writes: > This seems odd to me. Perhaps it'd be cleaner to detect which shell is > used at configure time to detect when /bin/sh !=3D Bash, and warn that if > there are issues, the user should set the SHELL variable to Bash. elaexuotee@wilsonb.com writes: > Excellent. I agree it's probably not worth POSIXifying the scripts. Forci= ng > make to default to guix's bash seems like the right approach IMHO, so +1 = for > that fix. I think we=E2=80=99re not on the same page. Is AM_SUBST_NOTMAKE([SHELL]) r= eally problematic? Is seems like there is a legitimate use-case that foreign distro users with /bin/sh =3D dash would want =E2=80=9Cguix shell -D guix -= - make=E2=80=9D to just work without workaround? We could use elaexuotee=E2=80=99s AM_SUBST_NOTMAKE([SHELL]) patch, could we not? Regards, Florian