From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wJuiBvUz8WPTCwAAbAwnHQ (envelope-from ) for ; Sat, 18 Feb 2023 21:24:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kNiuBvUz8WNJegAA9RJhRA (envelope-from ) for ; Sat, 18 Feb 2023 21:24:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B3D0C3EA25 for ; Sat, 18 Feb 2023 21:24:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTTkZ-0006uf-Hp; Sat, 18 Feb 2023 15:24:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTTkY-0006uU-H2 for bug-guix@gnu.org; Sat, 18 Feb 2023 15:24:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTTkX-000635-Sl for bug-guix@gnu.org; Sat, 18 Feb 2023 15:24:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTTkX-0001AX-Nr for bug-guix@gnu.org; Sat, 18 Feb 2023 15:24:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH 05/10] gnu: Add icecat-l10n and icedove-l10n. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 18 Feb 2023 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 32026@debbugs.gnu.org, ludo@gnu.org, Jonathan Brielmaier Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16767518114453 (code B ref 32026); Sat, 18 Feb 2023 20:24:01 +0000 Received: (at 32026) by debbugs.gnu.org; 18 Feb 2023 20:23:31 +0000 Received: from localhost ([127.0.0.1]:45032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTTk2-00019l-Vu for submit@debbugs.gnu.org; Sat, 18 Feb 2023 15:23:31 -0500 Received: from world.peace.net ([64.112.178.59]:58142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTTk1-00019X-Kd for 32026@debbugs.gnu.org; Sat, 18 Feb 2023 15:23:29 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTTjs-0003YJ-3z; Sat, 18 Feb 2023 15:23:20 -0500 From: Mark H Weaver In-Reply-To: <87ilg1t11r.fsf@gmail.com> References: <20230216043649.32119-1-maxim.cournoyer@gmail.com> <20230216043649.32119-5-maxim.cournoyer@gmail.com> <87cz69fcuf.fsf@netris.org> <87ilg1t11r.fsf@gmail.com> Date: Sat, 18 Feb 2023 15:22:28 -0500 Message-ID: <878rgu2068.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676751861; a=rsa-sha256; cv=none; b=X1HqfangS+2VW5SZ08vM46WTejwbh5nvhoNdPBmo2WG1n3dqws+kHnarxpjk3/vSL0xp9Y a1GKqmdmaSx/L1BMfqSscz41UhOkXRXy1FKG6EnhUNsm98N4Fs2oSbO1Y8yPxxeFT6zKS8 qSZtJomwYJiE70Zp8JFcWtpn0GBZo2KSLI6/y1QRedYe5UUIXnEiW/CDfUepS3YorN+Lqm HpWIviJttHtmvryRmALuCuQ9SYvsNPg8C4iPxP+74uQtUzfahAnnZF/XPePwrPA9q2fSy6 kyPCa2R4wcrYObQHYW7dqGBmzvPVR4rcvEEypTfA37udIydSLVkD0Z4E6zAaAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676751861; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=uYDYjC7Y5EJEj4gFD9ifIJlsNTv8dKB7S1HTInp0pLc=; b=u+cM7ct6jVUkAYtmrpUp9m4IaEKkCI0E5XxoQVfndZRLSv5nRHCSCVQ/3kTA7IreQVjz1y MT6k/QySHIb+MlGYwfJCYnwih0mMluzIP+66pxibbWx9LMz5yd6k+/2exawz8wVnKd7Axy 76eqI3Pnj8xU8ahCNh7oRd/C0piS3oXZ7DwwRcxdsJ7xdBAFpHgffo9PIK4Fm4DLNZOh71 5NTDjKvMjUBtbzu9jSJYEmpE3DMZV5wp2Z4ZLMtZdcooLqz1a1oUbDGzehvPWfEDiASFw8 pvMyvXv/WXlXLyN+QKa/XEikDiKC0zUfHsyU1y1c/qnN8NI7Y3QSTK3OjBRVOQ== X-Spam-Score: -1.63 X-Migadu-Queue-Id: B3D0C3EA25 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.63 X-TUID: ra7DVQwxkY2r Hi Maxim, Maxim Cournoyer writes: > Mark H Weaver writes: [...] >> (1) Instead of generating the locales in separate "*-locales" packages >> and then merging them with the main package (which must then be >> renamed to "*-minimal"), how feasible would it be to incorporate the >> locale generation directly into the existing packages? > > It's entirely feasible, but I see a couple downsides that explain why I > stuck with the current design: > > 1. The user no longer has an option to install IceCat without the 70 MiB > or so of extra locales (via icecat-minimal). > > 2. The already lengthy IceCat package definition gets even more verbose > and hard to follow. > > 3. The locales are slow to generate (it's sequential, and there are a > lot of them). Currently they can be generate at the same time as > icecat-minimal is built. > > 4. It makes debugging locale-generation problems more focused. Okay, that makes sense. Thanks for explaining it. I didn't realize until now that there's no way, in the current patch set, to install a subset of language packs. I see that the icecat-l10n package installs each language pack into a separate output, which led me to initially guess that users could install a subset of those outputs. At present, I guess that those separate outputs are not yet usable. At some point, it would be good to facilitate the creation of custom 'icecat' packages with only a subset of language packs added, but we can work on that later. There's no need to hold back on this important first step. >> (2) In terms of the API, I very much dislike the approach of having the >> 'make-l10n-package' accept just one argument: a symbol, which it >> uses to construct the variable names of toplevel variables that must >> be looked up using 'module-ref'. I'd greatly prefer to simply pass >> in all of the variables that are needed. >> >> What do you think? > > I don't feel strongly about it. Since you do, I've adjusted it, in an > upcoming v3. Thank you! Regards, Mark