unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
Cc: 62395@debbugs.gnu.org
Subject: bug#62395: [PATCH] Tunable guile@3.0.9t package
Date: Sun, 26 Mar 2023 15:42:04 +0200	[thread overview]
Message-ID: <878rfjd3yr.fsf@gnu.org> (raw)
In-Reply-To: <87zg8479mo.fsf@web.de> (Arne Babenhauserheide's message of "Wed,  22 Mar 2023 22:19:22 +0100")

Hi,

"Dr. Arne Babenhauserheide" <arne_bab@web.de> skribis:

> The attached patch adds a guile@3.0.9t package that enables CPU
> architecture tuning for Guile and for a specialized libgc.
>
> It creates new packages to avoid causing rebuilds.

Marking a package as tunable does not involve any rebuilds, by design:

  https://hpc.guix.info/blog/2022/01/tuning-packages-for-a-cpu-micro-architecture/

Thus there’s no need to create package variants.

> The results of a benchmark are still not fully conclusive: regular Guile
> seems to be slightly slower in the Geometric mean of all tests, but
> there are benchmarks where a tuned Guile is slower.
>
> Note that this is tuning for znver3 while I actually have znver4, but
> support for the correct compile-target will only arrive with GCC 13.

[...]

> Guile tuned has a slowdown of 1.03512801239189
> Guile regular has a slowdown of 1.0504373210343294
>
> This suggests that the regular Guile is 1.48% slower than tuned Guile.
>
> Since I have no errorbars, I cannot say whether this is significant.

As far as I know, there’s no reason why Guile’s C code would benefit
from ISA extensions (we’re mostly talking about vector instructions like
those of AVX).  The only part in libguile that’s performance-critical is
the VM engine—but I don’t see how that code could benefit from vector
instructions.  Likewise, I doubt libgc build with ‘-march=znver3’ has
any chance of being any faster; most likely, the generated code is close
to the baseline.

For these reasons, I’m reluctant to this patch.  Tuning should be done
only on packages where it makes sense, typically linear algebra code,
image/video processing, and so on.

WDYT?

Ludo’.




      reply	other threads:[~2023-03-26 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 21:19 bug#62395: [PATCH] Tunable guile@3.0.9t package Dr. Arne Babenhauserheide
2023-03-26 13:42 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rfjd3yr.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=62395@debbugs.gnu.org \
    --cc=arne_bab@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).