From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QDKqM7fWjWToUAAASxT56A (envelope-from ) for ; Sat, 17 Jun 2023 17:52:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2NvWM7fWjWTDJwAA9RJhRA (envelope-from ) for ; Sat, 17 Jun 2023 17:52:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 908E42833A for ; Sat, 17 Jun 2023 17:52:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAYDd-0001Kp-Ni; Sat, 17 Jun 2023 11:52:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAYDa-0001Jy-Q5 for bug-guix@gnu.org; Sat, 17 Jun 2023 11:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAYDa-0005Kk-3Z for bug-guix@gnu.org; Sat, 17 Jun 2023 11:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAYDZ-0003sM-Vo for bug-guix@gnu.org; Sat, 17 Jun 2023 11:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#64106: `modify-services` no longer affects multiple instances of the same service Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 17 Jun 2023 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64106 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: David Wilson , 64106@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , control@debbugs.gnu.org Received: via spool by 64106-submit@debbugs.gnu.org id=B64106.168701708514839 (code B ref 64106); Sat, 17 Jun 2023 15:52:01 +0000 Received: (at 64106) by debbugs.gnu.org; 17 Jun 2023 15:51:25 +0000 Received: from localhost ([127.0.0.1]:52449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAYCy-0003rG-OG for submit@debbugs.gnu.org; Sat, 17 Jun 2023 11:51:24 -0400 Received: from jpoiret.xyz ([206.189.101.64]:50256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAYCw-0003r3-AD; Sat, 17 Jun 2023 11:51:23 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 21D4018519E; Sat, 17 Jun 2023 15:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1687017079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2X9y4AjShctMzNnob7JJfL5Kb/k/A1oulqrn0YRZkUU=; b=OejHPN3G4kYrp3DRPnS5p+XwCwMWuOXWKQQVUIFANInkDCPh/eUkOqdtD7DVUh9u5iZQgH GQ5PKhaVWvMUT2I/MrnaKk+VVHrsot120MVblL9cEQQ2f+JksrbPcGNSy5Wyypiy3snjqp 8uvYJYn4dqt/mVDQ4Sj4cxOXztlgCQzuLXf2j+qzB9BQQlyAkbOfgkwMjS7TFPXbShYdVc nMJFNb117IYR7Px3hYj4HUKtvrfJGJfE517dPcXNsAPj6lLskNTIh96Hz8gIYA1N5l2U0X BHfO45qxkxSkmp50aQZhEbrOg1WUwf+vHiQUUmiALwVecAhlDQYziKkOaS2alQ== In-Reply-To: References: Date: Sat, 17 Jun 2023 17:51:13 +0200 Message-ID: <878rci5bpq.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret From: Josselin Poiret via Bug reports for GNU Guix Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687017143; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2X9y4AjShctMzNnob7JJfL5Kb/k/A1oulqrn0YRZkUU=; b=tsSuIf6LHThD1R0IXTmX6SAm/IeZ5c/ZmTEaTjKEmEyo99zegnRpRSVSsKQZNDxnazRPDk 8Gn5tSqlIDgXlDN/hSlzTiNR2gPDhSmrb5utRgyKujnoJlGw4spjxklcgGf8VOOOBI/dix JUdJINe1rOPKfkrZJB+rosuh94fTnKMNAfKsJPDxob2xH7Auxda4cJbZOmGXVCSECUcvKr ELfQUNC8WNchzNtVn+sFcvpik9Q/xHixfVcua+kqaBkmYPKLWcsStoMFr4Ze+E3dq8T3Q2 hzIvUFm6yDTZF3M3h493u9g3pXGDJiY/yR1xOv3UOCfsQVG9n2ioYbuczQYYaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=OejHPN3G; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687017143; a=rsa-sha256; cv=none; b=I0iP1mL2ktZyABZSbMYUlkL1JfIp5WO+Fa7jU4wZKLNhfNpjd5cneUK2mOkeYgPEFGu4JR u0+Trx5sP2cGc6An1gjInW26f+IJdo35ePS3iDZZFEdCjzOcz0h3/mmaV9b0n6hR16+0U7 oi7SRF7i5J5LlKXVpZlcMhh0yEhY+YVvWwqx5avlsAOM1c1IDhFba+709ewVt0088xOk02 dQkpH4UGZpHst864kjOZR5574+JiKa+WBpnOxHhRTfT75C2NjEExuOt00Q9nAd7yD6hGd9 GsXE80cif+4IabU9FjfgZwJbcJuxk6PU77MznQN2NSlOUQeRYz9OHpPu5n8kvQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=OejHPN3G; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 908E42833A X-Spam-Score: -3.83 X-TUID: 1fvFIKnJKpOc --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable merge 64106 63921 thankyou Hi David, "David Wilson" writes: > Hi Guix! > > Recently there was a change to the behavior of `modify-services` that add= s logic to check for any unused clauses so that an exception can be raised = to alert the user of this case. > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D18195120733950878= 9b28ba7cb914f983319920f > > It seems that the new logic has a bug that prevents a used clause from be= ing executed on more than one instance of a compatible service in a single = execution of `modify-services`. Here's a new test case for `gnu/tests/serv= ices.scm` that exhibits the issue: This was intended, but was probably not a good idea. I'll look into how we could revert this while keeping the main idea of the change. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmSN1nEQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaimTNC/4jcMiK50ZYhTPxk0MEjWFGlbshJxz/BQly u25PwmvOhbAI7JWlJJihr/C01wknQIOd770iWQc0qoUoDkghjNfR6+L9vLZJ/Luk TpTmJaxZjujS1rgixgM9+qzYVujjn3VC/AwAu+oDDsonwFCZTT08VTGyxWe0vpkx LxEKd0tqliaI5o0bvk3q/2ktZE7vmkXnLfsGKe5TxNtc2les7Xbycwnbp/JbTH3G 16rD6xugDqpGvKZ9nmhaXFk24UAAEDwDS10UJ5YOf+N33m+tXrelJiNejmY+t/Zo 2bqtF5Y4rJzKJEwHxSGcD2mkDlCfwR+sYqLHYi4hZLGu0cgAe+1F2fDHNm5ilaSk L9+UkKerFwKvR+wyTOCNE73oCnIBca0GHUKj1bdPXzogilDCbe50DpG78HhW/0D5 y6D0Om11aipHFOnLmNWitNJgxgHBCocpFQx5F8e80eSFT/mj3pAKFAJ+cCdmwAjr qtt/XhoREOup75TRGJL7d25huNuGRFk= =LHlO -----END PGP SIGNATURE----- --=-=-=--