bug#53423: nncp: Fails to build (renamed file not found)

bug#53423: nncp: Fails to build (renamed file not found)

[Ivan Vilata i Balaguer]

[-- Attachment #1.1: Type: text/plain, Size: 1897 bytes --]

Hi!  When trying to upgrade package `nncp 7.5.0` from Guix commit `404f6953`
to that of commit `4a943cfd`, the build fails showing this error:

```
phase `unpack' succeeded after 0.1 seconds
starting phase `go-unpack'
i/o error: src: No such file or directory
error: in phase 'go-unpack': uncaught exception:
system-error "rename-file" "~A" ("No such file or directory") (2) 
phase `go-unpack' failed after 0.0 seconds
Backtrace:
          10 (primitive-load "/gnu/store/lm25qs8vcxx69hn1rj47pjypc9m…")
In guix/build/gnu-build-system.scm:
    904:2  9 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
In ice-9/boot-9.scm:
  1752:10  8 (with-exception-handler _ _ #:unwind? _ # _)
In srfi/srfi-1.scm:
    634:9  7 (for-each #<procedure 7ffff4889300 at guix/build/gnu-b…> …)
In ice-9/boot-9.scm:
  1752:10  6 (with-exception-handler _ _ #:unwind? _ # _)
In guix/build/gnu-build-system.scm:
   925:23  5 (_)
In ice-9/eval.scm:
    619:8  4 (_ #(#(#<directory (guile-user) 7ffff5fdbc80>) "/gnu/…"))
In ice-9/boot-9.scm:
   260:13  3 (for-each #<procedure 7ffff490c280 at ice-9/eval.scm:3…> …)
In unknown file:
           2 (rename-file "src/vendor/go.cypherpunks.ru/balloon" "..…")
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure rename-file: No such file or directory

Some deprecated features have been used.  Set the environment
variable GUILE_WARN_DEPRECATED to "detailed" and rerun the
program to get more information.  Set it to "no" to suppress
this message.
```

Looks like some bundled dependency is no longer there?  Attaching the whole
`/var/log/guix/drvs/rq/p7xarf62882g2n31mgq3z2g616i5hy-nncp-7.5.0.drv.bz2`.

Thanks a lot!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #1.2: p7xarf62882g2n31mgq3z2g616i5hy-nncp-7.5.0.drv.bz2 --]
[-- Type: application/octet-stream, Size: 20032 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#53423: [fix] nncp: Fails to build (renamed file not found)

[Alan & Kim Zimmerman]

[-- Attachment #1.1: Type: text/plain, Size: 255 bytes --]

I took a look at this, and the problem seems to be that the cwd ends up
different from before, so all the file operations fail.

It needs (chdir "../nncp-7.5.0") in the 'go-unpack section.

Attached is a patch that does this, if it works via gmail.

Alan

[-- Attachment #1.2: Type: text/html, Size: 378 bytes --]

[-- Attachment #2: 0001-nncp-set-directory-so-build-succeeds.patch --]
[-- Type: text/x-patch, Size: 988 bytes --]

From f2cc08e9cd657717049936938077a210773ab193 Mon Sep 17 00:00:00 2001
Message-Id: <f2cc08e9cd657717049936938077a210773ab193.1687601540.git.alan.zimm@gmail.com>
From: Alan Zimmerman <alan.zimm@gmail.com>
Date: Fri, 23 Jun 2023 23:57:48 +0100
Subject: [PATCH] nncp: set directory so build succeeds

---
 gnu/packages/uucp.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/uucp.scm b/gnu/packages/uucp.scm
index e10de59aa2..65e71c1b1a 100644
--- a/gnu/packages/uucp.scm
+++ b/gnu/packages/uucp.scm
@@ -98,6 +98,7 @@ (define-public nncp
            (assoc-ref go:%standard-phases 'setup-go-environment))
          (add-after 'unpack 'go-unpack
            (lambda* (#:key source #:allow-other-keys)
+             (chdir "../nncp-7.5.0")
              ;; Copy source to GOPATH.
              (copy-recursively "src" "../src/go.cypherpunks.ru/nncp/v7")
              ;; Move bundled dependencies to GOPATH.

base-commit: f25529b08e356f89ca7cecc44295085531a8faba
-- 
2.40.1

bug#53423: [fix] nncp: Fails to build (renamed file not found)

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]

On 2023-06-24, Alan & Kim Zimmerman wrote:
> I took a look at this, and the problem seems to be that the cwd ends up
> different from before, so all the file operations fail.
>
> It needs (chdir "../nncp-7.5.0") in the 'go-unpack section.
>
> Attached is a patch that does this, if it works via gmail.

Thanks for the patch! Miraculously, it still applies after all this
time, and it does allow the build to proceed further, but still fails in
tests:

  starting phase `check'
  do  test
  # _/tmp/guix-build-nncp-7.5.0.drv-0/nncp-7.5.0/src/cmd/nncp-cfgdir
  cmd/nncp-cfgdir/main.go:91:4: unknown field 'AllowMinusZero' in struct literal of type hjson.EncoderOptions
  ok      _/tmp/guix-build-nncp-7.5.0.drv-0/nncp-7.5.0/src        37.407s                                                             ?       _/tmp/guix-build-nncp-7.5.0.drv-0/nncp-7.5.0/src/cmd/nncp-bundle        [no test files]
  ?       _/tmp/guix-build-nncp-7.5.0.drv-0/nncp-7.5.0/src/cmd/nncp-call  [no test files]
  ?       _/tmp/guix-build-nncp-7.5.0.drv-0/nncp-7.5.0/src/cmd/nncp-caller        [no test files]
  do: test: got exit code 2
  error: in phase 'check': uncaught exception:
  %exception #<&invoke-error program: "contrib/do" arguments: ("-c" "test") exit-status: 1 term-signal: #f stop-signal: #f>
  phase `check' failed after 44.5 seconds
  command "contrib/do" "-c" "test" failed with status 1

CCed the members of the go team who may have a better idea of, well,
packaging go programs. :)

live well,
  vagrant

> From f2cc08e9cd657717049936938077a210773ab193 Mon Sep 17 00:00:00 2001
> Message-Id: <f2cc08e9cd657717049936938077a210773ab193.1687601540.git.alan.zimm@gmail.com>
> From: Alan Zimmerman <alan.zimm@gmail.com>
> Date: Fri, 23 Jun 2023 23:57:48 +0100
> Subject: [PATCH] nncp: set directory so build succeeds
>
> ---
>  gnu/packages/uucp.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/uucp.scm b/gnu/packages/uucp.scm
> index e10de59aa2..65e71c1b1a 100644
> --- a/gnu/packages/uucp.scm
> +++ b/gnu/packages/uucp.scm
> @@ -98,6 +98,7 @@ (define-public nncp
>             (assoc-ref go:%standard-phases 'setup-go-environment))
>           (add-after 'unpack 'go-unpack
>             (lambda* (#:key source #:allow-other-keys)
> +             (chdir "../nncp-7.5.0")
>               ;; Copy source to GOPATH.
>               (copy-recursively "src" "../src/go.cypherpunks.ru/nncp/v7")
>               ;; Move bundled dependencies to GOPATH.
>
> base-commit: f25529b08e356f89ca7cecc44295085531a8faba
> -- 
> 2.40.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#53423: [fix] nncp: Fails to build (renamed file not found)

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On 2024-02-07, Vagrant Cascadian wrote:
> On 2023-06-24, Alan & Kim Zimmerman wrote:
>> I took a look at this, and the problem seems to be that the cwd ends up
>> different from before, so all the file operations fail.
>>
>> It needs (chdir "../nncp-7.5.0") in the 'go-unpack section.
>>
>> Attached is a patch that does this, if it works via gmail.

FWIW, nncp appears to be quite out of date in guix; might be good
to explore getting current upstream working...

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#53423: nncp: Fails to build (renamed file not found)

[Sharlatan Hellseher]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]


Hi Vagrant,

Thank you for the ping on this issue.

It was on my radar to update nncp as the package was failed to build for
a long time and quite dated.

It looks like the current version is not compatible with versions of
golang packages available in Guix anymore. I have a chance to bump it to
the 8.0.0 to check if it may fix the build but it did not work any more and
the whole package need proper refactoring.

I'll place upgrading it to my TODO list.

Thanks,
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]