From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id GPwWEe6MYGZe4wAAqHPOHw:P1 (envelope-from ) for ; Wed, 05 Jun 2024 18:06:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id GPwWEe6MYGZe4wAAqHPOHw (envelope-from ) for ; Wed, 05 Jun 2024 18:06:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=V4muZFtn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717603566; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GMnuJVI0ye5ItXouj+QpbhhER1yqSqKcV4IilQjA1WY=; b=oHICv5nKX7QUMwoWa0Frr+cb4U3kL4RKuykIgH8h9kWgBI+fRhuBvSGC9Hgz7zdUG2nFpG 2dbA5fiiS6PKhTKS6Jiqc4OB3qbXHlL6lqoY8o+Pz4Gg6+fX1g2r5cMnbfcmzOJnsxKK/P M+NKmaQOBUkDi7PpCzrhY74C+AYNAEf++M+QJq7/YqpMzDj2E0XPCl1qApXk7jccso+3cb DJgbIaf97o8YkfbbXpFTsSaOO5O2/lW13ccTH3kxwGCJzmrT/eue+7ZzMUunmMJzGxo+UL EOBIkwH544eybd9XpWmBs1TshNcFLItK6semTxDhcQmRcRQ50jFtKwpsc0A1aw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=V4muZFtn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717603566; a=rsa-sha256; cv=none; b=ua+f9cvHahZL6y7cvPzfkfaxIs9Yp8ifNmC4NdBTW4q+twi5fW1cpHQscwTcPUxN6OGEPu 5zw8qIc+y0CHs52wmFGr/CWjRAUTHuG4h4U8GSMKOs+un43iIn63Ck++be+R5Dpk3VV4wV YMCgpUs7Lmq8FCO7RpS/M07rqJ+Cqt8cqQ0YuTKlJ++UDYndq9JoluQC4aLtdYjgaRz2gp g/BR6yqKkwlMpyAjF2VaXCsDA6FUdVLAaT7WXJNAYUV33zON6w9ceNMksOjoXf6y5uz+I3 rK9aVph24dKNZCPQJ0Cfql5mWNibdfNSjOnhWSvO3yh25BuhOf/eyt4zN15Blg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 068656842E for ; Wed, 5 Jun 2024 18:06:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEt95-0005mB-2p; Wed, 05 Jun 2024 12:05:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEt93-0005gK-9q for bug-guix@gnu.org; Wed, 05 Jun 2024 12:05:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEt92-0000q1-Hv for bug-guix@gnu.org; Wed, 05 Jun 2024 12:05:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEt9G-0005SR-HA for bug-guix@gnu.org; Wed, 05 Jun 2024 12:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47144: security patching of 'patch' package Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 05 Jun 2024 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47144 X-GNU-PR-Package: guix X-GNU-PR-Keywords: security To: Maxim Cournoyer Cc: Mark H Weaver , 47144@debbugs.gnu.org, Vivien Kraus , Leo Famulari Received: via spool by 47144-submit@debbugs.gnu.org id=B47144.171760350920823 (code B ref 47144); Wed, 05 Jun 2024 16:06:02 +0000 Received: (at 47144) by debbugs.gnu.org; 5 Jun 2024 16:05:09 +0000 Received: from localhost ([127.0.0.1]:45258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEt8N-0005Pe-Uf for submit@debbugs.gnu.org; Wed, 05 Jun 2024 12:05:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEt8L-0005Os-DV for 47144@debbugs.gnu.org; Wed, 05 Jun 2024 12:05:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEt7z-0008Ps-E9; Wed, 05 Jun 2024 12:04:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=GMnuJVI0ye5ItXouj+QpbhhER1yqSqKcV4IilQjA1WY=; b=V4muZFtn7kywlgsFcv8w F4kNyY3+rqyV8J8TWGPFUAHQbZoFceRZNW+qDa6G7SWG47ZNv22leTJtlYZqlaygEmgxcegGTzDjY 1ITOOq8kM6BDU6T10axn9jHftwpw/KxIfQ1WtUBXld8Ysxh2oyENPIMAb4Leg4WXDJHgaQC9kWVMK kiRULJl8SHhwkJk0NLc3G78rqupi+DkVyAqrMtsqF5Kx7t+6O3WlJGPuYvWckGt3pyiMGLusfrpjE JXHDwWubq7L8tXQd8by+hcs4j4kR1YwdnR5Iilax4n0VbXGRFM171zcFtIcXXApD+2KkeUG/f1tLL EmYJPX2sNB+lYA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <875xusln8m.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 01 Jun 2024 11:02:49 -0400") References: <28b457771ab0e7ad87cb65600a5898f68be5074a.1717124361.git.maxim.cournoyer@gmail.com> <5eda21a09360653b198f1b0d7f52cf531dc97485.1717124361.git.maxim.cournoyer@gmail.com> <87r0dgn36w.fsf@gnu.org> <875xusln8m.fsf@gmail.com> Date: Wed, 05 Jun 2024 18:04:39 +0200 Message-ID: <878qzj74vc.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.74 X-Spam-Score: -5.74 X-Migadu-Queue-Id: 068656842E X-Migadu-Scanner: mx13.migadu.com X-TUID: 8n0tdeFqc6c0 Hi Maxim, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >> Unless I=E2=80=99m mistaken, this will have practically no effect becaus= e Patch >> is a build-time-only dependency. >> >> My recommendation would be to not add a =E2=80=98replacement=E2=80=99 fi= eld at all. >> Instead, you could add a new =E2=80=98patch/latest=E2=80=99 public varia= ble pointing to >> that commit that you picked. That way, users running =E2=80=98guix inst= all >> patch=E2=80=99 or similar will get the latest version of Patch. > > I see what you mean, but for all practical purposes, using a graft seems > a more thorough (because it affects the original 'patch' *variable* as > well) means that have the same effect for users, so I'd seems like a > slightly better option to me. Strictly speaking, yes, but in practice the benefit are largely theoretical IMO, and the cost of having a graft this deep in the dependency graph. What about renaming =E2=80=98patch=E2=80=99 to =E2=80=98patch/pinned=E2=80= =99 and having =E2=80=98patch=E2=80=99 point to the new version? Internally, we=E2=80=99d refer to =E2=80=98patch/pinned=E2=80=99 in (guix p= ackages), but user code etc. would refer to =E2=80=98patch=E2=80=99 and thus get the latest ve= rsion. Ludo=E2=80=99.