From: ludo@gnu.org (Ludovic Courtès)
To: Taylan Ulrich Bayirli/Kammer <taylanbayirli@gmail.com>
Cc: 17946-done@debbugs.gnu.org
Subject: bug#17946: Try LOGNAME in addition to USER
Date: Sat, 05 Jul 2014 15:12:48 +0200 [thread overview]
Message-ID: <877g3suey7.fsf@gnu.org> (raw)
In-Reply-To: <87wqbsc78j.fsf@taylan.uni.cx> (Taylan Ulrich Bayirli's message of "Sat, 05 Jul 2014 15:36:44 +0300")
Taylan Ulrich Bayirli/Kammer <taylanbayirli@gmail.com> skribis:
> Cron jobs may set the LOGNAME environment variable but no USER,
> e.g. under Debian 7 (wheezy). In that case 'guix package' fails to
> use $localstatedir/guix/profiles/per-user/$user. From a quick grep I
> couldn't find more places in Guix where USER is used, so here's a
> patch that just does it straightforwardly in two places in
> scripts/package.scm, but perhaps a more generic solution would be good
> for the future.
Good catch. I agree we’ll need to factorize that eventually.
> From 902267cf99aacaea994cc95b77551f0d2bd35836 Mon Sep 17 00:00:00 2001
> From: Taylan Ulrich B <taylanbayirli@gmail.com>
> Date: Sat, 5 Jul 2014 15:28:50 +0300
> Subject: [PATCH] Try LOGNAME in addition to USER.
>
> Notoriously, cron jobs may set LOGNAME only and not USER. See
> e.g. crontab(5) under Debian 7 (wheezy).
>
> * guix/scripts/package.scm (%profile-directory)
> (guix-package): Also try LOGNAME if USER is unset.
Pushed after tweaking the commit log.
Thanks!
Ludo’.
prev parent reply other threads:[~2014-07-05 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 12:36 bug#17946: Try LOGNAME in addition to USER Taylan Ulrich Bayirli/Kammer
2014-07-05 13:12 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g3suey7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=17946-done@debbugs.gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).