From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#21399: Emacs: Guix Package Info omits some inputs
Date: Thu, 03 Sep 2015 16:41:33 +0200
Message-ID: <877fo7y38i.fsf@gnu.org>
References: <87bndl9djb.fsf@gnu.org> <87a8t4zw3q.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38907)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZXViF-0007Zz-9s
	for bug-guix@gnu.org; Thu, 03 Sep 2015 10:42:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZXViE-0002tq-5T
	for bug-guix@gnu.org; Thu, 03 Sep 2015 10:42:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZXViE-0002tj-32
	for bug-guix@gnu.org; Thu, 03 Sep 2015 10:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZXViD-0003Iy-VT
	for bug-guix@gnu.org; Thu, 03 Sep 2015 10:42:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.21399.B21399.144129130412681@debbugs.gnu.org>
In-Reply-To: <87a8t4zw3q.fsf@gmail.com> (Alex Kost's message of "Wed, 02 Sep
	2015 18:20:25 +0300")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: 21399@debbugs.gnu.org

Alex Kost <alezost@gmail.com> skribis:

> Yes, you are right, it is filtered in =E2=80=98package-inputs-names=E2=80=
=99 in
> "emacs/guix-main.scm".  The easiest fix would be the following
>
> diff --git a/emacs/guix-main.scm b/emacs/guix-main.scm
> index 8d3a881..636d524 100644
> --- a/emacs/guix-main.scm
> +++ b/emacs/guix-main.scm
> @@ -245,7 +245,7 @@ Example:
>  (define (package-inputs-names inputs)
>    "Return a list of full names of the packages from package INPUTS."
>    (filter-map (match-lambda
> -               ((_ (? package? package))
> +               ((_ (? package? package) _ ...)
>                  (package-full-name package))
>                 (_ #f))
>                inputs))
>
> However, I think it would be better to have "icedtea6-1.13.7:jdk"
> instead of "icedtea6-1.13.7" in the "Inputs".  This requires modifying
> =E2=80=98full-name->name+version=E2=80=99 procedure so that pressing such
> "<name>-<version>:<out>" buttons will also work.

Right, makes sense.

> From ae9203234d5254a9cb6a8127d31e99289c605f7a Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Wed, 2 Sep 2015 17:57:58 +0300
> Subject: [PATCH] emacs: Add support for "triplet" package inputs.
>
> Fixes <http://bugs.gnu.org/21399>.
>
> * emacs/guix-main.scm (full-name->name+version): Adjust to handle
>   "name-version:output" string.
>   (package-inputs-names): Support ("name" package "output") inputs.

LGTM, thanks for the quick fix!

Ludo=E2=80=99.