From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Sturmfels Subject: bug#30189: [PATCH] Re: bug#30189: Retux game halts after preloading levels (missing ucd.sqlite uniseg database) Date: Mon, 22 Jan 2018 13:03:12 +1100 Message-ID: <877esa8xb3.fsf@sturm.com.au> References: <87vafvnaan.fsf@sturm.com.au> <87tvvfmyqy.fsf@sturm.com.au> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edRSx-00016b-56 for bug-guix@gnu.org; Sun, 21 Jan 2018 21:04:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edRSs-0008Fx-71 for bug-guix@gnu.org; Sun, 21 Jan 2018 21:04:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edRSs-0008Fs-3R for bug-guix@gnu.org; Sun, 21 Jan 2018 21:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edRSr-0000Tc-ON for bug-guix@gnu.org; Sun, 21 Jan 2018 21:04:01 -0500 In-Reply-To: <87vafvnaan.fsf@sturm.com.au> Sender: "Debbugs-submit" Resent-Message-ID: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: guix-patches@gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Patch for python-uniseg attached that fixes bug#30189. Sorry if this is a duplicate, but I can't seem my previous email in the guix-patches archives. Maybe because I missed the [PATCH] in the subject? On Sun, 21 Jan 2018, Ben Sturmfels wrote: > Thanks G=C3=A1bor, adding zipfile fixes the build and Retux now runs. > > Patch attached and CC'd to guix-patches. > > Regards, > Ben > > On Sun, 21 Jan 2018, G=C3=A1bor Boskovits wrote: > >> I think unzip should be added to native-inputs. Can you try that? >> >> 2018-01-21 4:46 GMT+01:00 Ben Sturmfels : >> >> Hi Folks, >> >> I'd like to play the Retux game, but while the game starts up it >> crashes >> on me after the "preloading levels" screen. >> >> There's no useful console output, but when running in the debugger, I >> see that the python-uniseg package is looking for a file called >> ucd.sqlite3 that doesn't exist, some kind of Unicode letter spacing >> database that's not present in the BitBucket repository. >> >> python3 -m pdb -c continue \ >> "/gnu/store/57psnlgdyri8phkxzasaf6q0gb8nskpz-retux-1.3.5/bin/.retux-rea= l" >> >> >> See uniseg/db.py:107 and 21. Since it's also looking in the current >> directory, I tried downloading ucd.sqlite3 from the PyPI zip package - >> that fixes the issue. >> >> The python-uniseg package downloads the source from BitBucket, so >> I >> tried changing that to PyPI: >> >> (uri (pypi-uri "uniseg" version ".zip")) >> >> which downloads ok, but fails but the fails at the unpack phase >> without >> any details. Should Guix know how to unpack a .zip? Or maybe I >> should >> coerce the maintainer to publish a .tar.gz? >> >> Currently Retux is the only program that uses python-uniseg (via >> python-sge-pygame dependency). >> >> Regards, >> Ben --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-python-uniseg-Switch-to-PyPi-source-to-get-missi.patch Content-Transfer-Encoding: quoted-printable From=2042c1e69526ec9781e3f7290fb74e2a561131e3be Mon Sep 17 00:00:00 2001 From: Ben Sturmfels Date: Sun, 21 Jan 2018 18:43:07 +1100 Subject: [PATCH] gnu: python-uniseg: Switch to PyPi source to get missing ucd.sqlite3. * gnu/packages/python.scm (python-uniseg): Use PyPI, add zipfile dependency= to unpack. =2D-- gnu/packages/python.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 0b582e6b7..2f1c20e31 100644 =2D-- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -773,15 +773,15 @@ Python 3 support.") (source (origin (method url-fetch) =2D (uri (string-append "https://bitbucket.org/emptypage/uniseg-pytho= n/" =2D "get/rel-" version ".tar.gz")) =2D (file-name (string-append name "-" version ".tar.gz")) + (uri (pypi-uri "uniseg" version ".zip")) (sha256 (base32 =2D "1df4gddnj2a0v8z35wb2ra5vvh1f1qyxs8fgd25c8g64031mna6x")))) + "05jsazvz6nbmh6l3v1rph5ydkqn1hzx1pyggdyvgp2qgmgrnmiz2")))) (build-system python-build-system) (arguments '(#:tests? #f)) ; The test suite requires network access. + (native-inputs + `(("unzip" ,unzip))) (home-page "https://bitbucket.org/emptypage/uniseg-python") (synopsis =2D-=20 2.15.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEPn825zvdanEG+SAhAjwF4snAaPAFAlplRmAACgkQAjwF4snA aPCxhA/+P1n8no4YzBjvnXotSmFvj0qTlLWu9KELbTXfw3AKyBpZtY3t3LMNqcNj HSwE2PyLxPT/dB/FUAW5KvHW7wCNQflh3dLIDOwl2pl8Fzo48Ve17G3t7wjjnlPR AOa7HM7eFsBg7Cco1SmfAaleOYc/6tC/l9jkZeLPcoBqACw2JGNjhwCnBlbCxB+k ByA/1KMZ555Y8laSF+XATcVFWwBznJCQdeacnMpVFJxdCM8bepWwnWQDbhNQ3YU/ gvitIEcTmzhdG0MQSRbb86ecESol2RTjt5e+4QZAFyjBjwpcy8Cz3O9MkH/raVHa qRxsp6yRB7lQ13u7sHBG8lf6l5D2yUjGTIjqfWaBBmp6nJmdvyTi3VSgPte/3WjG w2j5W/TH7dL2M7Pikfg88EkMsKRQR5fs1RUulJntQiWj6rFe1N0rMNwZiPKEJHrm ASBih69X1yYuQCM3teOv2FLfCibONMdJtTruXEGaLN/NF8hUws4k0PCq78dA7HQg fqjWrYhOi7js+r4PVsxSEhofHuYWMQ6FyFwlwuA8yz+THStVui1DbSkFF14LRPt8 C51YaWl1lMWW8Ln3bexndgMRliWEjey2T3Ya99Fp/dLsHX7LTKmqy+PBSeNhpH1N b9tly3x7OZkBw2FfgoAktcSNYn8ucL/wwnP2BjXRb0pAwZnQQWU= =WW4M -----END PGP SIGNATURE----- --==-=-=--