From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#22039: [PATCH] 'guix system reconfigure' must start/restart/stop services Date: Mon, 24 Sep 2018 10:58:58 +0200 Message-ID: <877ejbxodp.fsf@gnu.org> References: <874mg6rsjl.fsf@gnu.org> <87tvnhxr20.fsf@zancanaro.id.au> <87sh2tijb2.fsf@gnu.org> <87va7pza4p.fsf@zancanaro.id.au> <87tvn9b0qh.fsf@gnu.org> <87tvn8d0n7.fsf@zancanaro.id.au> <87lg7xh4l0.fsf@gnu.org> <871s9pfbpg.fsf@zancanaro.id.au> <87efdowleu.fsf@gnu.org> <87tvmkqxe7.fsf@zancanaro.id.au> <87efdov32l.fsf@gnu.org> <87sh24qtes.fsf@zancanaro.id.au> <87r2hn2hbo.fsf@gnu.org> <87lg7ru83l.fsf@zancanaro.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4Miu-00050v-Br for bug-guix@gnu.org; Mon, 24 Sep 2018 05:00:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4Mip-000778-0M for bug-guix@gnu.org; Mon, 24 Sep 2018 05:00:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4Mio-00076v-SL for bug-guix@gnu.org; Mon, 24 Sep 2018 05:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g4Mio-0002Vp-Nw for bug-guix@gnu.org; Mon, 24 Sep 2018 05:00:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87lg7ru83l.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Mon, 24 Sep 2018 09:06:38 +1000") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Carlo Zancanaro Cc: 22039@debbugs.gnu.org Hi Carlo, Carlo Zancanaro skribis: > On Fri, Sep 21 2018, Ludovic Court=C3=A8s wrote: >> What would you put there? Do you have concrete examples? > > I would have three possible values: 'never, 'always, 'manual. > > 'never would mean that the service should never be restarted. This is > for things like udev, or the filesystems, which should never be > restarted on a running system. > > 'always would mean that the service is always safe to restart. I don't > immediately know what services would fit in this category (maybe sshd, > given Efraim's comment; maybe ntpd? I'm sure there are others). Things > like nginx will probably not fall into this category, because they > involve some downtime when restarting. Reloading their configuration > (via a "reload" action, or similar) is not enough because the binary > and/or libraries might have changed (and, in the worst case, might > have an incompatible configuration format, although I would expect > that to be exceedingly rare). > > 'manual would mean that the service should be restarted, but it need > to be done at an appropriate time. This should prompt the user with > the names of the services, and we should provide an option to guix > system reconfigure to restart these services as part of the > reconfigure. We could call the option "--restart-services". OK, I see. >> We can go with your patch and a message along the lines of what we >> discussed above, and then work on the improvements you mentioned, >> one at a time. That way we=E2=80=99ll have the warm feeling of having >> achieved something, even if there=E2=80=99s more to come. :-) > > I won't be able to look at writing the code for this for a few weeks, > but hopefully I'll get to it around mid- to late-October. If that=E2=80=99s fine with you, I can apply the patch you initially posted= so we can start taking advantage of it (I=E2=80=99d like to push a Guix releas= e by the end of October.) WDYT? Thanks! Ludo=E2=80=99.