unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Jelle Licht <jlicht@fsfe.org>
To: Daniel Gerber <dg@atufi.org>
Cc: 34526@debbugs.gnu.org
Subject: bug#34526: Updating node.js
Date: Mon, 18 Feb 2019 21:50:41 +0100	[thread overview]
Message-ID: <877edw6cta.fsf@fsfe.org> (raw)
In-Reply-To: <87d0npb1tx.fsf@atufi.org>


Daniel Gerber <dg@atufi.org> writes:

> Notes on v11.10.0:
> - it does support openssl@1.1.1
> - it ships with libuv 1.26.0 (1.24.0 in guix)
> - some previously bundled deps are absent from tarball
> - NODE_EXPERIMENTAL_HTTP is a no-op / always defined
>
> There is an issue with the alternative http parser, `llhttp`. The
> choice of parser is at runtime, and one compile flag,
> --shared-http-parser, configures both. Building fails with:

> [snip]

> ../src/http_parser_adaptor.h:5:21: fatal error: llhttp.h: No such
> file or directory
> ```
>
> AFAIU, either llhttp has to be made a separate package and listed
> in inputs, or http-parser linked statically. Or should the missing
> -I../deps/llhttp/include argument be passed here somehow -- maybe
> patching node.gypi?

It seems that llhttp includes a build step for generating C-files using
TypeScript, making it a non-starter for proper packaging in Guix.

See https://github.com/nodejs/llhttp/issues/14 for more details, but
sadly no solution.

>
> I have not tried to build 10.15.1(LTS), which presumably has the
> same issues as in #32095.
>
> Also, should previous version branches (8.x, 9.x) be kept in guix?

As long as they are still supported by upstream, I see no issue with
this. The 8.x LTS is still maintained through the end of 2019.

I am not sure the 9.X series is still supported. If not, it might make
more sense to remove it instead of updating it.

  reply	other threads:[~2019-02-18 21:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 14:36 bug#34526: Updating node.js Daniel Gerber
2019-02-18 20:50 ` Jelle Licht [this message]
2019-02-19  8:06   ` Björn Höfling
2019-02-19 16:42   ` Daniel Gerber
2019-02-19 17:00     ` Daniel Gerber
2019-02-20 13:59     ` Jelle Licht
2019-02-21 17:02       ` Daniel Gerber
2019-11-16 20:28         ` Christopher Lemmer Webber
2019-11-17 18:25           ` Marius Bakke
2019-11-20 14:26             ` Christopher Lemmer Webber
2019-11-21 13:34               ` Jelle Licht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877edw6cta.fsf@fsfe.org \
    --to=jlicht@fsfe.org \
    --cc=34526@debbugs.gnu.org \
    --cc=dg@atufi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).