From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: bug#35941: Newt installer failure when wifi name is #f Date: Wed, 29 May 2019 09:50:12 +0200 Message-ID: <877ea9u2bv.fsf@gmail.com> References: <87h89fj6p3.fsf@ambrevar.xyz> <8736kywqr2.fsf@gnu.org> <8736kyii1r.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:35067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVtMV-0007Ra-Lu for bug-guix@gnu.org; Wed, 29 May 2019 03:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVtMU-00070a-LB for bug-guix@gnu.org; Wed, 29 May 2019 03:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVtMU-00070V-Iy for bug-guix@gnu.org; Wed, 29 May 2019 03:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVtMU-0001gn-EO for bug-guix@gnu.org; Wed, 29 May 2019 03:51:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <8736kyii1r.fsf@ambrevar.xyz> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Pierre Neidhardt Cc: 35941@debbugs.gnu.org --=-=-= Content-Type: text/plain Hey, > Out of 44 SSIDs around me, only 2 are hidden and they are the only 2 ones > for which connmanctl does not report the "Name = " line. > > That should fix the issue! Thanks for the investigation ! I guess the attached patch should fix the issue then :) Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-installer-Fix-wifi-menu-crash-with-hidden-SSIDs.patch >From dd212927d50eeed9b8d16beed1f98228299c8633 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Wed, 29 May 2019 09:44:44 +0200 Subject: [PATCH] installer: Fix wifi menu crash with hidden SSIDs. * gnu/installer/connman.scm (): Mention that name may be false. * gnu/installer/newt/wifi.scm (wifi-services): Filter out wifi services without name. Co-authored by: Pierre Neidhardt --- gnu/installer/connman.scm | 2 +- gnu/installer/newt/wifi.scm | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm index ef8cca3952..7f47b9af77 100644 --- a/gnu/installer/connman.scm +++ b/gnu/installer/connman.scm @@ -108,7 +108,7 @@ (define-record-type* service make-service service? - (name service-name) ; string + (name service-name) ; string or #f (type service-type) ; string (path service-path) ; string (strength service-strength) ; integer diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm index da2f0b56d0..1cb2ef2df3 100644 --- a/gnu/installer/newt/wifi.scm +++ b/gnu/installer/newt/wifi.scm @@ -144,6 +144,7 @@ of records present in LISTBOX." (let ((services (connman-services))) (filter (lambda (service) (and (string=? (service-type service) "wifi") + (service-name service) (not (string-null? (service-name service))))) services))) -- 2.17.1 --=-=-=--