From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wN2EHq0F+V52EgAA0tVLHw (envelope-from ) for ; Sun, 28 Jun 2020 21:03:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MJlYGq0F+V5KPAAA1q6Kng (envelope-from ) for ; Sun, 28 Jun 2020 21:03:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 045A4940369 for ; Sun, 28 Jun 2020 21:03:41 +0000 (UTC) Received: from localhost ([::1]:40630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpeSi-0006cj-04 for larch@yhetil.org; Sun, 28 Jun 2020 17:03:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpeS7-000693-OT for bug-guix@gnu.org; Sun, 28 Jun 2020 17:03:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpeS6-0001I7-Lv for bug-guix@gnu.org; Sun, 28 Jun 2020 17:03:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpeS6-00027F-Hb for bug-guix@gnu.org; Sun, 28 Jun 2020 17:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42111: tests/syscalls.scm stumbles on network interface aliases Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 28 Jun 2020 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42111 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Marius Bakke Received: via spool by 42111-submit@debbugs.gnu.org id=B42111.15933781408083 (code B ref 42111); Sun, 28 Jun 2020 21:03:02 +0000 Received: (at 42111) by debbugs.gnu.org; 28 Jun 2020 21:02:20 +0000 Received: from localhost ([127.0.0.1]:47073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpeRQ-00026J-8w for submit@debbugs.gnu.org; Sun, 28 Jun 2020 17:02:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpeRM-000264-Bw for 42111@debbugs.gnu.org; Sun, 28 Jun 2020 17:02:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47999) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpeRH-0001Em-2k for 42111@debbugs.gnu.org; Sun, 28 Jun 2020 17:02:11 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpeRF-0004zX-V7; Sun, 28 Jun 2020 17:02:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y2o7b32j.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Jun 2020 23:02:08 +0200 In-Reply-To: <87y2o7b32j.fsf@gnu.org> (Marius Bakke's message of "Sun, 28 Jun 2020 17:52:20 +0200") Message-ID: <877dvqgazz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42111@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Iy+Nn0IRWM/m Hi! Marius Bakke skribis: > The "network-interface-names" test from tests/syscalls.scm fails if a > network interface alias is configured. > > I.e. this command: > > ip addr add 127.0.0.2/8 dev lo label lo:lcat Woow. =F0=9F=90=88 > diff --git a/tests/syscalls.scm b/tests/syscalls.scm > index 6acaa0b131..7aa16ce3f4 100644 > --- a/tests/syscalls.scm > +++ b/tests/syscalls.scm > @@ -382,7 +382,10 @@ > (member "lo" names)))) >=20=20 > (test-assert "network-interface-names" > - (match (network-interface-names) > + (match (filter (lambda (if) > + ;; Ignore interface aliases. Perhaps add =E2=80=9Csince they don=E2=80=99t show up in (all-network-inter= face-names)=E2=80=9D. > + (not (string-contains if ":"))) > + (network-interface-names)) You can use =E2=80=98remove=E2=80=99 instead of =E2=80=98filter=E2=80=99 + = =E2=80=98not=E2=80=99. Otherwise LGTM, thanks! Ludo=E2=80=99.