From: "Ludovic Courtès" <ludo@gnu.org>
To: Marius Bakke <marius@gnu.org>
Cc: 42111@debbugs.gnu.org
Subject: bug#42111: tests/syscalls.scm stumbles on network interface aliases
Date: Sun, 28 Jun 2020 23:02:08 +0200 [thread overview]
Message-ID: <877dvqgazz.fsf@gnu.org> (raw)
In-Reply-To: <87y2o7b32j.fsf@gnu.org> (Marius Bakke's message of "Sun, 28 Jun 2020 17:52:20 +0200")
Hi!
Marius Bakke <marius@gnu.org> skribis:
> The "network-interface-names" test from tests/syscalls.scm fails if a
> network interface alias is configured.
>
> I.e. this command:
>
> ip addr add 127.0.0.2/8 dev lo label lo:lcat
Woow. 🐈
> diff --git a/tests/syscalls.scm b/tests/syscalls.scm
> index 6acaa0b131..7aa16ce3f4 100644
> --- a/tests/syscalls.scm
> +++ b/tests/syscalls.scm
> @@ -382,7 +382,10 @@
> (member "lo" names))))
>
> (test-assert "network-interface-names"
> - (match (network-interface-names)
> + (match (filter (lambda (if)
> + ;; Ignore interface aliases.
Perhaps add “since they don’t show up in (all-network-interface-names)”.
> + (not (string-contains if ":")))
> + (network-interface-names))
You can use ‘remove’ instead of ‘filter’ + ‘not’.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2020-06-28 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 15:52 bug#42111: tests/syscalls.scm stumbles on network interface aliases Marius Bakke
2020-06-28 21:02 ` Ludovic Courtès [this message]
2020-06-28 21:37 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dvqgazz.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42111@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).