bug#42186: emacs swiper package missing since ivy update 0.13.1

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Pierre Langlois]

Hi Nicolas, hello Guix!

I just noticed the last update to the emacs-ivy package removed
swiper.el from the package by moving from github to elpa. It seems elpa
packages ivy and swiper separately
(https://elpa.gnu.org/packages/swiper.html).

I don't have time to submit a patch to fix it at the moment so I'm just
filing a bug, but I can get to it next week if needed :-). I think we
can either go back to using github to fetch the source, or package
emacs-swiper separately.

WDYT?

Thanks!
Pierre

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Pierre Langlois]

Pierre Langlois writes:

> Hi Nicolas, hello Guix!
>
> I just noticed the last update to the emacs-ivy package removed
> swiper.el from the package by moving from github to elpa. It seems elpa
> packages ivy and swiper separately
> (https://elpa.gnu.org/packages/swiper.html).

Looking at elpa, it seems 0.13.1 isn't a new update to the code itself
(I couldn't find any 0.13.1 release upstream) but instead a change that
splits ivy into three packages for ivy, swiper and counsel. I wonder if
that means we should also package emacs-counsel separately, they mention
version conflict issues although I imagine we don't have this problem
in guix.

https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/packages/ivy?id=782117aa34418ff66ecf763327f1e2aa69f234f9

Thanks,
Pierre

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Nicolas Goaziou]

Hello,

Pierre Langlois <pierre.langlois@gmx.com> writes:

> I just noticed the last update to the emacs-ivy package removed
> swiper.el from the package by moving from github to elpa. It seems elpa
> packages ivy and swiper separately
> (https://elpa.gnu.org/packages/swiper.html).
>
> I don't have time to submit a patch to fix it at the moment so I'm just
> filing a bug, but I can get to it next week if needed :-). I think we
> can either go back to using github to fetch the source, or package
> emacs-swiper separately.
>
> WDYT?

I think packages from GNU ELPA are cleaner, and easier to update.
I added emacs-swiper package.

Thank you for the heads up.

Regards,
-- 
Nicolas Goaziou

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

That is also the reason why emacs-lispy fails to build:

...
starting phase `check'
make: which: No such file or directory
Using ...
emacs -batch -l elpa.el -l lispy-test.el -l lispy-inline.el -l lispy.el -f ert-run-tests-batch-and-exit
Loading /gnu/store/3s56kpyjvds6apr21nw85nh83lwj6smg-emacs-clojure-mode-5.11.0/share/emacs/site-lisp/clojure-mode-autoloads...
Loading /gnu/store/p1advrdp5jipq915alsxgvdb24ck6rwd-emacs-undercover-0.6.1/share/emacs/site-lisp/undercover-autoloads...
Loading /gnu/store/j57rh6w6fvxibl08mj9x8pb7d98jbfk2-emacs-ace-window-0.10.0/share/emacs/site-lisp/ace-window-autoloads...
Loading /gnu/store/adndadpiaj5i08hiq9bddrn7m4sqy5a8-emacs-iedit-0.9.9.9-1.e2c100c/share/emacs/site-lisp/iedit-autoloads...
Loading /gnu/store/s86lwlq43m1jy7nw8ydwz6017cxhcl2x-emacs-ivy-0.13.1/share/emacs/site-lisp/ivy-autoloads...
Loading /gnu/store/5b6qndzv9hczlm7ax2vmah9z81177p5r-emacs-hydra-0.15.0/share/emacs/site-lisp/hydra-autoloads...
Loading /gnu/store/v09b5sx3lm9pybvikm19krmwvb2fgvqg-emacs-zoutline-0.2.0/share/emacs/site-lisp/zoutline-autoloads...
Loading /gnu/store/byijdv6j5gsdrvamcwcpnn9in6c8854h-emacs-shut-up-0.3.2/share/emacs/site-lisp/shut-up-autoloads...
Loading /gnu/store/qi38w5ivwzdiapnkj8h3v5zkdfy5wnkj-emacs-dash-2.17.0/share/emacs/site-lisp/dash-autoloads...
Loading /gnu/store/fxi3kp0kcbvp8grljm2c8h11xygggl47-emacs-avy-0.5.0/share/emacs/site-lisp/avy-autoloads...
Cannot open load file: No such file or directory, swiper
make: *** [Makefile:22: test] Error 255


-- 
The sendmail configuration file is one of those files that looks like someone
beat their head on the keyboard.  After working with it... I can see why!
		-- Harry Skelton

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Pierre Langlois]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]


Nicolas Goaziou writes:

> Hello,
>
> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> I just noticed the last update to the emacs-ivy package removed
>> swiper.el from the package by moving from github to elpa. It seems elpa
>> packages ivy and swiper separately
>> (https://elpa.gnu.org/packages/swiper.html).
>>
>> I don't have time to submit a patch to fix it at the moment so I'm just
>> filing a bug, but I can get to it next week if needed :-). I think we
>> can either go back to using github to fetch the source, or package
>> emacs-swiper separately.
>>
>> WDYT?
>
> I think packages from GNU ELPA are cleaner, and easier to update.
> I added emacs-swiper package.

Nice, thanks for the quick fix! Originally I noticed this because of the
emacs-lispy package failing to build. Here's a patch to add
`emacs-swiper` as a dependency to fix it.

I suspect we might need to fix some more, including the few
emacs-counsel-* packages we have. I agree things will be cleaner that
way in the end :-).

Thanks,
Pierre


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-lispy-Add-emacs-swiper-dependency.patch --]
[-- Type: text/x-patch, Size: 901 bytes --]

From cc5609fbb99dbec1eefaca87a04bce8b6088bd2b Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Sat, 4 Jul 2020 12:41:37 +0200
Subject: [PATCH] gnu: emacs-lispy: Add emacs-swiper dependency.

* gnu/packages/emacs-xyz.scm (emacs-lispy)[propagated-inputs]: Add
emacs-swiper.
---
 gnu/packages/emacs-xyz.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5c4861766c..813b7d3eb1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6695,6 +6695,7 @@ navigate code in a tree-like fashion.")
      `(("emacs-ace-window" ,emacs-ace-window)
        ("emacs-iedit" ,emacs-iedit)
        ("emacs-ivy" ,emacs-ivy)
+       ("emacs-swiper" ,emacs-swiper)
        ("emacs-hydra" ,emacs-hydra)
        ("emacs-zoutline" ,emacs-zoutline)))
     (native-inputs
--
2.27.0

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Nicolas Goaziou]

Pierre Langlois <pierre.langlois@gmx.com> writes:

> Nice, thanks for the quick fix! Originally I noticed this because of the
> emacs-lispy package failing to build. Here's a patch to add
> `emacs-swiper` as a dependency to fix it.
>
> I suspect we might need to fix some more, including the few
> emacs-counsel-* packages we have. I agree things will be cleaner that
> way in the end :-).

I think I fixed all Emacs packages depending on emacs-ivy.

Let me know if something is still wrong.

Regards,

bug#42186: emacs swiper package missing since ivy update 0.13.1

[Pierre Langlois]

Nicolas Goaziou writes:

> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> Nice, thanks for the quick fix! Originally I noticed this because of the
>> emacs-lispy package failing to build. Here's a patch to add
>> `emacs-swiper` as a dependency to fix it.
>>
>> I suspect we might need to fix some more, including the few
>> emacs-counsel-* packages we have. I agree things will be cleaner that
>> way in the end :-).
>
> I think I fixed all Emacs packages depending on emacs-ivy.
>
> Let me know if something is still wrong.

It all works for me! This is great, thanks so much!

Pierre