unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon South <simon@simonsouth.net>
To: 50346@debbugs.gnu.org
Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64
Date: Thu, 02 Sep 2021 18:41:12 -0400	[thread overview]
Message-ID: <877dfy7g8n.fsf@simonsouth.net> (raw)
In-Reply-To: <875yvi93w8.fsf@simonsouth.net>

Patching strace to add a "--trace-path" parameter to the two tests'
definitions as in the patch below seems to fix this issue on both
AArch64 and x86-64, and is less drastic than disabling the tests
altogether.

The changes limit strace's output during testing to only calls affecting
files in the test directory itself, effectively filtering out the
'readlink("/proc/self/exe")' call from glibc that is throwing the tests
currently.  You can see a number of other places in gen_tests.in where
this is done, presumably for similar reasons.

Does this seem reasonable?

-- 
Simon South
simon@simonsouth.net


diff --git a/tests/gen_tests.in b/tests/gen_tests.in
index 8b4e2e9..cc3ca63 100644
--- a/tests/gen_tests.in
+++ b/tests/gen_tests.in
@@ -623,8 +623,8 @@ quotactl-xfs-v	-v -e trace=quotactl
 read-write	-a15 -eread=0,5 -ewrite=1,4 -e trace=read,write -P read-write-tmpfile -P /dev/zero -P /dev/null
 readahead	-a1
 readdir	-a16
-readlink	-xx
-readlinkat	-xx
+readlink	-xx --trace-path=test.readlink.link
+readlinkat	-xx --trace-path=test.readlinkat.link
 reboot		-s 256
 recv-MSG_TRUNC	-a26 -e trace=recv
 recvfrom	-a35




  reply	other threads:[~2021-09-02 22:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 19:24 bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Simon South
2021-09-02 22:41 ` Simon South [this message]
2021-09-03 12:15   ` Bengt Richter
2021-09-03 14:00     ` Simon South
2021-09-03 16:53       ` Bengt Richter
2021-09-03 21:27         ` Simon South
2021-09-04 19:51           ` Simon South
2021-09-04 19:58 ` bug#50346: [PATCH core-updates-frozen] gnu: strace: Allow readlink, readlinkat tests to pass Simon South
2021-11-18 13:13   ` bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dfy7g8n.fsf@simonsouth.net \
    --to=simon@simonsouth.net \
    --cc=50346@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).