unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon South <simon@simonsouth.net>
To: Bengt Richter <bokr@bokr.com>
Cc: 50346@debbugs.gnu.org
Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64
Date: Fri, 03 Sep 2021 10:00:33 -0400	[thread overview]
Message-ID: <877dfxbvy6.fsf@simonsouth.net> (raw)
In-Reply-To: <20210903121513.GA5202@LionPure> (Bengt Richter's message of "Fri, 3 Sep 2021 14:15:13 +0200")

Bengt Richter <bokr@bokr.com> writes:
> A proper configurability, ISTM, would be preferable to any other form
> of more general filtering.

I agree with you on the need to be cautious around modifying test cases
but I'm not sure I follow you otherwise.  What would "proper
configurability" look like in this case?

The change I'm proposing here narrows the two test cases so they test
only what appears to have been intended, i.e. that strace can capture
readlink(at) system calls and that it reports them in the format
expected by the developers.  It does not affect other test cases or the
test suite as a whole.

The obvious alternative would be to modify the test cases' expected
output to match what is actually generated, but this could have the side
effect of tying the package to Linux and perhaps to specific versions of
glibc.

That said I'm still not sure why this additional syscall is being made
in the first place, only that it appears to originate from glibc's
"_dl_get_origin" function[0].  If I build strace from source "manually"
the tests complete fine without modification.  I presume the extra call
has to do with the fact Guix builds strace inside a container; does
anyone know how this could be affecting the way programs are loaded?

-- 
Simon South
simon@simonsouth.net

[0] See e.g. glibc's sysdeps/unix/sysv/linux/dl-origin.c for the x86-64
    case, as well as "_dl_non_dynamic_init" in elf/dl-support.c, which
    seems to be the only place it is called.




  reply	other threads:[~2021-09-03 14:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 19:24 bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Simon South
2021-09-02 22:41 ` Simon South
2021-09-03 12:15   ` Bengt Richter
2021-09-03 14:00     ` Simon South [this message]
2021-09-03 16:53       ` Bengt Richter
2021-09-03 21:27         ` Simon South
2021-09-04 19:51           ` Simon South
2021-09-04 19:58 ` bug#50346: [PATCH core-updates-frozen] gnu: strace: Allow readlink, readlinkat tests to pass Simon South
2021-11-18 13:13   ` bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dfxbvy6.fsf@simonsouth.net \
    --to=simon@simonsouth.net \
    --cc=50346@debbugs.gnu.org \
    --cc=bokr@bokr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).