From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yMpXEKVDhmFn4gAAgWs5BA (envelope-from ) for ; Sat, 06 Nov 2021 09:58:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kDcTDKVDhmHQSQAA1q6Kng (envelope-from ) for ; Sat, 06 Nov 2021 08:58:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 05F552C854 for ; Sat, 6 Nov 2021 09:58:13 +0100 (CET) Received: from localhost ([::1]:39486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjHWe-0001HK-7I for larch@yhetil.org; Sat, 06 Nov 2021 04:58:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjHWU-0001H1-Ra for bug-guix@gnu.org; Sat, 06 Nov 2021 04:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjHWU-0007Ca-HV for bug-guix@gnu.org; Sat, 06 Nov 2021 04:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjHWU-0003eh-HD for bug-guix@gnu.org; Sat, 06 Nov 2021 04:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51559: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 06 Nov 2021 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51559 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler , 51559@debbugs.gnu.org Received: via spool by 51559-submit@debbugs.gnu.org id=B51559.163618906414025 (code B ref 51559); Sat, 06 Nov 2021 08:58:02 +0000 Received: (at 51559) by debbugs.gnu.org; 6 Nov 2021 08:57:44 +0000 Received: from localhost ([127.0.0.1]:48359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjHWC-0003e9-5a for submit@debbugs.gnu.org; Sat, 06 Nov 2021 04:57:44 -0400 Received: from world.peace.net ([64.112.178.59]:33836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjHWA-0003dt-B7 for 51559@debbugs.gnu.org; Sat, 06 Nov 2021 04:57:42 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjHW2-0000eE-Sz; Sat, 06 Nov 2021 04:57:34 -0400 From: Mark H Weaver In-Reply-To: <5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com> References: <5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com> Date: Sat, 06 Nov 2021 04:55:36 -0400 Message-ID: <877ddlu0gs.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maxim.cournoyer@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636189093; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=KaZaicoj/z3Diu+f8lUkvo+zcO1QQMhvUjB6z1NxOsc=; b=VLvxuhE9UJ30Zum9xgpQ7WvB1yRRorybZJsGp0QL6yC2sIvTT03bGArXlNVrPtkC5ij5rv ybxvv9LgjqWB+Pg3RCOMuxgZL/tl5sj49qBXJYl74YST54JY47/sXeMG79rSuSjXSZLIzX 8B8RHOAO23JFs053ovtPknD+iN5tgxkz06f4Qzfb2rg7+887hKKgB1+XTBAOLK9fESAUAK +LcHuwf16/KEnXU5YBVEOlJ71ql4GpTAondM+chFDyuOLEPuPQbgGTK9l3yJ1CIQDr7zpU HoiqkKNIvzU5CFmXne62gcm8BF33opR6bhP3MbotU/j8HymGLuyYPsYZjjHHEA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636189093; a=rsa-sha256; cv=none; b=OKqHHHf8t8/IySgN6uPVim4FPzBVUKhM/87aw+XXVve5dX8lWyCKtKmrlsPKaqVgTmZRd2 Nz0UAWqRnz1OCRPrp5mg0NfAwE/67cq31yXFSDUo0dfcSFLAEOPf2dXJPG2DoVe8eljGc5 RrPMUVxPyb67q3N2+e7A0lkLnUY9XYUEuo1S1mnVcuieCziFs7QYOXCB5F/o7LBl76ef7j RK+EfP4CMIjBA6AYyemJo3kNjQdkbhuVS07hmW2pNOhE8viewCczUdxDVfXWLO89Tha1G+ H3B/sQGqDlNcGRYub7+Y4dtVBzZ1U6yCJQ7PkXWQ4Lja95km6Fyrnnvu9w84RQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 05F552C854 X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: oa6BiZRCI+bX Hi Liliana, I have one more comment: Liliana Marie Prikler writes: > @@ -241,7 +241,7 @@ (define-public webkitgtk > (build-system cmake-build-system) > (outputs '("out" "doc")) > (arguments > - '(#:tests? #f ; no tests > + `(#:tests? #f ; no tests > #:build-type "Release" ; turn off debugging symbols to save space > #:configure-flags (list > "-DPORT=GTK" You'll need to remove this hunk in order to apply this to 'master', since I've already made the change above in commit 4fd12fb00d595b6f6a5d5cc734863f4c4bc5f46c. > @@ -295,6 +295,13 @@ (define-public webkitgtk > (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version) > (string-append wpebackend-fdo "/lib/" all))) > #t))) > + ,@(if (string-prefix? "x68_64" (or (%current-target-system) > + (%current-system))) > + '() > + '((add-after 'unpack 'disable-sse2 > + (lambda _ > + (substitute* "Source/cmake/DetectSSE2.cmake" > + (("CHECK_FOR_SSE2\\(\\)") "")))))) As a general recommendation, it would be preferable to add the phase only on the systems that need it (32-bit x86), instead of adding it on every system except x86_64. The code above will force rebuilds on every system other than x86_64, whereas if the test was done as I suggested, rebuilds would only happen on 32-bit x86 systems. However, in this particular case it hardly matters, since our libsoup package currently fails to build on any system that's not x86-based. Thanks, Mark -- Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about .