From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0CEBDciNCmLR3wAAgWs5BA (envelope-from ) for ; Mon, 14 Feb 2022 18:13:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6LG/BciNCmJ/MQAAG6o9tA (envelope-from ) for ; Mon, 14 Feb 2022 18:13:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8C2438283 for ; Mon, 14 Feb 2022 18:13:43 +0100 (CET) Received: from localhost ([::1]:52018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJev0-0001mM-PA for larch@yhetil.org; Mon, 14 Feb 2022 12:13:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJesQ-0008GH-65 for bug-guix@gnu.org; Mon, 14 Feb 2022 12:11:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJesP-0006Ih-SI for bug-guix@gnu.org; Mon, 14 Feb 2022 12:11:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJesP-0000S6-O4 for bug-guix@gnu.org; Mon, 14 Feb 2022 12:11:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53210: [WIP PATCH 0/4] Make current-guix work when run outside a Git checkout Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 14 Feb 2022 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53210 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Josselin Poiret Received: via spool by 53210-submit@debbugs.gnu.org id=B53210.16448586591730 (code B ref 53210); Mon, 14 Feb 2022 17:11:01 +0000 Received: (at 53210) by debbugs.gnu.org; 14 Feb 2022 17:10:59 +0000 Received: from localhost ([127.0.0.1]:42446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJesN-0000Rp-3p for submit@debbugs.gnu.org; Mon, 14 Feb 2022 12:10:59 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:48932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJesL-0000Rb-IP for 53210@debbugs.gnu.org; Mon, 14 Feb 2022 12:10:58 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DFED6B50; Mon, 14 Feb 2022 18:10:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sBA8XLopHxpI; Mon, 14 Feb 2022 18:10:50 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CA57A2D0; Mon, 14 Feb 2022 18:10:49 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87lezkrgvj.fsf@gnu.org> <20220214092908.16801-1-dev@jpoiret.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 =?UTF-8?Q?Pluvi=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 14 Feb 2022 18:10:49 +0100 In-Reply-To: <20220214092908.16801-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Mon, 14 Feb 2022 10:29:04 +0100") Message-ID: <877d9xv0fa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: DFED6B50 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Othacehe , 53210@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644858823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=moZLDiNGTJhqxm7tZvVrM2n7Oat+M/1+1cu4GV+z0Tc=; b=NXVziZlEZrkA3xAcN3xIfMDDmt4SU8nu6FyZOIilEUU0aWI+oU+dIEcRftTcgVx2Hujvzo cbWod8AdYhMyZYvLvl77f8cQRywzajYm1khWuKhhL3M0ud9oMFV+Dlo+e5QNRxpflW57UX alrannoUucvqn1Di8+Pln0UZu1B0ICP753VnAvviHfAISNoSCoP7r/6C4VXZVpXyVRaH8G MHIuvR3bNjnLXTC/JYlyaQb2l2y6PjMRMt8+yUwiSRGvv+RSITvZzMCyDYEOzhwd1IItIL 0j5wVZhGnKUohra7eLTW3nAiEfrXmo1p2pVyYoqZBcuxDSuXINPDhbAIdNp+Mg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644858823; a=rsa-sha256; cv=none; b=PhIuHM4gSNFRnk5eRAc/yfegQavv9nqOYRXVe+BqtA/W7bbVytSh7CsQVUy/cN2P5YGdYJ F7v9eL88AWENrpBmYbzbfYRxeChF9aYJDwOIZaCQ7ZpTDc7H/Rk36APRAhPMP5OmmUesQx O4pzSG9OBIyGz3kRl2ZiOtOW/qKuRPPOU0pRoi520W67tk/s8osSKklRac5S6M7eDAGAIn o7mfHHPAkDUozqURrtpNLwINSSc3vnO1siPZI56+W0Z8OLQcHfU+1KCTdmsOQiMmK3JcBt TFyQd1Kzr5DVJzR+Obh9pn/dUGvw7z051s3lzpN29AeuvXUnS+CxVQGurJXOCQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A8C2438283 X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: Yp9tQrPIsXDp Hello, Thanks for working on it! Josselin Poiret skribis: > This is only a WIP as there are some unresolved things: I've disabled > authentication, since I'm currently testing my own unsigned patches. > Should we indiscriminately enable it? This would cause some issues > for people that have their own 'guix channel. Maybe we could enable > authentication if the channel URL is the default one? How about adding a keyword argument to =E2=80=98channel-build-system=E2=80= =99, defaulting to true? > Also, when I tried to replace the guix in the installer by > (current-guix), it ended up building the Guix derivation multiple > times, even though the package is memoized and the package->derivation > process should be cached. =E2=80=98current-guix=E2=80=99 returns a fresh package object every time it= =E2=80=99s called: (define-public current-guix (lambda () =E2=80=A6 (package =E2=80=A6))) This defeats the object-to-derivation cache, which relies on object identity (eq?). So yes, you definitely have to turn it into =E2=80=98mlamb= da=E2=80=99. Why that=E2=80=99s no enough, I don=E2=80=99t know. > There's a bit of rift between what the ci uses (renamed here to > channel-profile-build-system) and what current-guix uses, since the > former builds a profile as a package, whereas the latter simply builds > the derivation for the 'guix channel. This avoids creating profile > collisions when the package is added to the system profile, but it > also means we don't get the package cache generation. As discussed on IRC, I think the file-level collisions are fine: unless I=E2=80=99m mistaken, it=E2=80=99s the =E2=80=98manifest=E2=80=99 file of t= he real profile that =E2=80=9Cwins=E2=80=9D, so it doesn=E2=80=99t really matter that the =E2=80=98guix=E2=80=99 package= also provides a =E2=80=98manifest=E2=80=99 file. What=E2=80=99s more problematic though is that it means that =E2=80=9C/run/current-system/profile/bin/guix describe=E2=80=9D would now f= ail (I think? Can you confirm?) since it gets its provenance data from the profile it=E2=80=99s in. WDYT? Ludo=E2=80=99.