From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 55936-done@debbugs.gnu.org
Subject: bug#55936: dockerd fails to start on boot
Date: Wed, 13 Jul 2022 21:40:53 -0400 [thread overview]
Message-ID: <877d4g1nfe.fsf@gmail.com> (raw)
In-Reply-To: <87wncgyb67.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Wed, 13 Jul 2022 17:06:56 -0400")
Hi Oleg,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hi Oleg,
>>
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> Fixes <https://issues.guix.gnu.org/38432>.
>>>
>>> * gnu/packages/patches/containerd-create-pid-file.patch: New file.
>>> * gnu/local.mk (dist_patch_DATA): Add this.
>>> * gnu/packages/docker.scm (containerd)[source]: Add this patch.
>>> * gnu/services/docker.scm
>>> (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout.
>>> * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag.
>>
>> Thanks for this, it looks promising!
[...]
> All that to say that I shall be reviewing your patches shortly :-).
Now done; it all looks good to me! I've run the docker system test, and
installed it on my machine, rebooted, confirmed it was up, restarted
containerd a couple times and checked the PID content matched its actual
PID, and it seems to behave as expected!
Pushed as b33e1a183f6756514e6b6a3b84054a232dbddad4.
Thank you!
Maxim
next prev parent reply other threads:[~2022-07-14 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 22:56 bug#55936: dockerd fails to start on boot Luciano Laratelli
2022-06-24 5:11 ` Maxim Cournoyer
2022-07-02 10:41 ` bug#55936: [PATCH] services: docker: Fix race condition Oleg Pykhalov
2022-07-10 5:10 ` Maxim Cournoyer
2022-07-13 21:06 ` bug#55936: dockerd fails to start on boot Maxim Cournoyer
2022-07-14 1:40 ` Maxim Cournoyer [this message]
2022-07-15 10:20 ` Ludovic Courtès
2022-07-16 1:55 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d4g1nfe.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=55936-done@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).