unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#56864: qutebrowser
@ 2022-08-01  5:04 Jack Hill
  2022-08-01 13:08 ` Maxim Cournoyer
  0 siblings, 1 reply; 7+ messages in thread
From: Jack Hill @ 2022-08-01  5:04 UTC (permalink / raw)
  To: 56864; +Cc: maxim.cournoyer

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

X-Debbugs-CC: maxim.cournoyer@gmail.com

With Guix 3a656ea836f87f30f1b34852cb4efc911363d2b4, qutebrowser's 
wrap-qt-process-path phase fails. Maybe related to the recent Qt work 
in <https://issues.guix.gnu.org/56771>? Build log attatched.

Best,
Jack

[-- Attachment #2: Type: application/octet-stream, Size: 15101 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#56864: qutebrowser
  2022-08-01  5:04 bug#56864: qutebrowser Jack Hill
@ 2022-08-01 13:08 ` Maxim Cournoyer
  2022-08-01 13:35   ` bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append Maxim Cournoyer
  0 siblings, 1 reply; 7+ messages in thread
From: Maxim Cournoyer @ 2022-08-01 13:08 UTC (permalink / raw)
  To: Jack Hill; +Cc: 56864

Hello Jack,

Jack Hill <jackhill@jackhill.us> writes:

> X-Debbugs-CC: maxim.cournoyer@gmail.com
>
> With Guix 3a656ea836f87f30f1b34852cb4efc911363d2b4, qutebrowser's
> wrap-qt-process-path phase fails. Maybe related to the recent Qt work
> in <https://issues.guix.gnu.org/56771>? Build log attatched.

Uh, this was unexpected.  I believe it's because label-less inputs are
auto-generated via the package *name* rather than their variable name...
Since qtwebengine-5 (the variable) still has the name "qtwebengine", the
following code:

--8<---------------cut here---------------start------------->8---
(qt-process-path (string-append (assoc-ref inputs "qtwebengine-5")
                                      "/lib/qt5/libexec/QtWebEngineProcess"))
--8<---------------cut here---------------end--------------->8---

Doesn't actually find "qtwebengine-5" and it fails attempting to append
#f to "/lib/qt5/libexec/QtWebEngineProcess.  The solution that comes to
mind would be using:

(file-input-search inputs "lib/qt5/libexec/QtWebEngineProcess").

Thanks,

Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append
  2022-08-01 13:08 ` Maxim Cournoyer
@ 2022-08-01 13:35   ` Maxim Cournoyer
  2022-08-01 14:10     ` Lars-Dominik Braun
  0 siblings, 1 reply; 7+ messages in thread
From: Maxim Cournoyer @ 2022-08-01 13:35 UTC (permalink / raw)
  To: Jack Hill; +Cc: 56864-done

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello Jack,
>
> Jack Hill <jackhill@jackhill.us> writes:
>
>> X-Debbugs-CC: maxim.cournoyer@gmail.com
>>
>> With Guix 3a656ea836f87f30f1b34852cb4efc911363d2b4, qutebrowser's
>> wrap-qt-process-path phase fails. Maybe related to the recent Qt work
>> in <https://issues.guix.gnu.org/56771>? Build log attatched.
>
> Uh, this was unexpected.  I believe it's because label-less inputs are
> auto-generated via the package *name* rather than their variable name...
> Since qtwebengine-5 (the variable) still has the name "qtwebengine", the
> following code:
>
> (qt-process-path (string-append (assoc-ref inputs "qtwebengine-5")
>                                       "/lib/qt5/libexec/QtWebEngineProcess"))
>
> Doesn't actually find "qtwebengine-5" and it fails attempting to append
> #f to "/lib/qt5/libexec/QtWebEngineProcess.  The solution that comes to
> mind would be using:
>
> (file-input-search inputs "lib/qt5/libexec/QtWebEngineProcess").

Yep, that did it.

Fixed in aea756ea3312ba7e8229804492ba12001c8de568.

Closing.

Thanks for the report!

Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append
  2022-08-01 13:35   ` bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append Maxim Cournoyer
@ 2022-08-01 14:10     ` Lars-Dominik Braun
  2022-08-01 14:16       ` paren--- via Bug reports for GNU Guix
  2022-08-01 14:40       ` paren--- via Bug reports for GNU Guix
  0 siblings, 2 replies; 7+ messages in thread
From: Lars-Dominik Braun @ 2022-08-01 14:10 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: Jack Hill, 56864

Hi Maxim,

> Yep, that did it.
> 
> Fixed in aea756ea3312ba7e8229804492ba12001c8de568.

this does not fix the build of lyx and twinkle for me, which both fail at 'qt-wrap:

---snip---
starting phase `qt-wrap'
error: in phase 'qt-wrap': uncaught exception:
wrong-type-arg "substring" "Wrong type argument in position ~A (expecting ~A): ~S" (1 "string" #f) (#f)
phase `qt-wrap' failed after 0.0 seconds
Backtrace:
           9 (primitive-load "/gnu/store/gm47sv2ndfg906vkdr68nbv7zsi…")
In guix/build/gnu-build-system.scm:
    906:2  8 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
In ice-9/boot-9.scm:
  1752:10  7 (with-exception-handler _ _ #:unwind? _ # _)
In srfi/srfi-1.scm:
    634:9  6 (for-each #<procedure 7ffff0b45020 at guix/build/gnu-b…> …)
In ice-9/boot-9.scm:
  1752:10  5 (with-exception-handler _ _ #:unwind? _ # _)
In guix/build/gnu-build-system.scm:
   927:23  4 (_)
In guix/build/qt-utils.scm:
   148:22  3 (wrap-all-qt-programs #:inputs _ #:outputs _ #:qtbase _ …)
In unknown file:
           2 (string-drop #f 44)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure substring: Wrong type argument in position 1 (expecting string): #f
---snap---

Maybe a different incarnation of the same issue?

Lars




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append
  2022-08-01 14:10     ` Lars-Dominik Braun
@ 2022-08-01 14:16       ` paren--- via Bug reports for GNU Guix
  2022-08-01 14:40       ` paren--- via Bug reports for GNU Guix
  1 sibling, 0 replies; 7+ messages in thread
From: paren--- via Bug reports for GNU Guix @ 2022-08-01 14:16 UTC (permalink / raw)
  To: Lars-Dominik Braun, Maxim Cournoyer; +Cc: Jack Hill, 56864

On Mon Aug 1, 2022 at 3:10 PM BST, Lars-Dominik Braun wrote:
> Maybe a different incarnation of the same issue?
The fix is on the package side, so other affected packages won't have
been fixed by that commit.

    -- (




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append
  2022-08-01 14:10     ` Lars-Dominik Braun
  2022-08-01 14:16       ` paren--- via Bug reports for GNU Guix
@ 2022-08-01 14:40       ` paren--- via Bug reports for GNU Guix
  2022-08-01 15:43         ` Maxim Cournoyer
  1 sibling, 1 reply; 7+ messages in thread
From: paren--- via Bug reports for GNU Guix @ 2022-08-01 14:40 UTC (permalink / raw)
  To: Lars-Dominik Braun, Maxim Cournoyer; +Cc: Jack Hill, 56864

This issue affects the following packages as well as qute:

  twinkle, lyx, nheko, quaternion, kcrash, likely many KDE packages
  (possibly kdenlive, kdevelop, and others), kguiaddons, psi, sonnet.

(Not a complete list, of course.)

    -- (




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append
  2022-08-01 14:40       ` paren--- via Bug reports for GNU Guix
@ 2022-08-01 15:43         ` Maxim Cournoyer
  0 siblings, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2022-08-01 15:43 UTC (permalink / raw)
  To: (; +Cc: Jack Hill, Lars-Dominik Braun, 56864

Hi,

"(" <paren@disroot.org> writes:

> This issue affects the following packages as well as qute:
>
>   twinkle, lyx, nheko, quaternion, kcrash, likely many KDE packages
>   (possibly kdenlive, kdevelop, and others), kguiaddons, psi, sonnet.

Proposed fix at:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56771#124.  If nobody
objects I'll push it soon.

Thanks,

Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-08-01 15:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01  5:04 bug#56864: qutebrowser Jack Hill
2022-08-01 13:08 ` Maxim Cournoyer
2022-08-01 13:35   ` bug#56864: qutebrowser: wrap-qt-process-path phase wrong type to string-append Maxim Cournoyer
2022-08-01 14:10     ` Lars-Dominik Braun
2022-08-01 14:16       ` paren--- via Bug reports for GNU Guix
2022-08-01 14:40       ` paren--- via Bug reports for GNU Guix
2022-08-01 15:43         ` Maxim Cournoyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).