From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EAkJKX2f8mM2jwAAbAwnHQ (envelope-from ) for ; Sun, 19 Feb 2023 23:15:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eOSxKH2f8mPuCgEAauVa8A (envelope-from ) for ; Sun, 19 Feb 2023 23:15:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 80CFE1571A for ; Sun, 19 Feb 2023 23:15:25 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=m6Uq29ej; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676844925; a=rsa-sha256; cv=none; b=Y/8FcKQ+EwtW4jqL15cNQAIgGAIi4O8UL0CrKZl2uuixTcEbBwC8OOy94RCXETj+XVU1Ac y0xxQgkeCGox0jovFcCSYF5nh5uAYW5lcXqhqcuSHk1YcIiNwt0ZwAAjtKWR5wQd+pHaVO VLlMeoop4UV3pUE8ftML25Er9EzPajCxU5RC6+BRPTKDcD6BOjtOfAbWQRmJbZZ/hrONfc GYVpDBFUGDpHx7+L8T9qnxUocYsAoW9mg5ZeI0VaM5kez+ca/bvbEX77dHL+kvnT5+rAo/ ieClidhMjEQ4wgvdFcZJ6GQiXwyAlQXmc5OxDrPRA76ET+kBM0kq6G8Icvdj9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=m6Uq29ej; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676844925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cuVa+mb8P08SUlMMBLcjaQHRnpvLvAbDffk0GI4mcAE=; b=WXazIlXpyitUSKEYKdiMnrsYl6DTPrU8juvkk6p1Ic81uSbNZ6+KULjH+vmMl6kMVir8gK 9bWgpb5x8iBrVLWhN9Y90QXLg6mIYIQKKInewY2M72ol7swkfS7zote0zGT6K7L8g08apL eezYh2i3M/GWi871M9nQy/4XTJgpTP/XF9tFUgYP8lpPV4LKTR8+ap3gjLyNagou0gmjmV DhCsqiREQtCydHrDZIZp98xMpgEC0qJARETJhXS4aRIkrz48k1CfMeyeucC6On/wkcXmRk zfdjwUVO9xZpUhn7ZOKtVrUiftJ0vy+shXtrKSlpZxrqCcIMz6ziegrwxaWL0w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTrxY-0003M7-52; Sun, 19 Feb 2023 17:15:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTrxW-0003Kv-Nl for bug-guix@gnu.org; Sun, 19 Feb 2023 17:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTrxW-0001ri-Dc for bug-guix@gnu.org; Sun, 19 Feb 2023 17:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTrxW-0001nd-4E for bug-guix@gnu.org; Sun, 19 Feb 2023 17:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH v4 3/9] gnu: Define %icecat-base-version at the top level. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 19 Feb 2023 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Cc: 32026@debbugs.gnu.org, ludo@gnu.org, Jonathan Brielmaier Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16768448786850 (code B ref 32026); Sun, 19 Feb 2023 22:15:02 +0000 Received: (at 32026) by debbugs.gnu.org; 19 Feb 2023 22:14:38 +0000 Received: from localhost ([127.0.0.1]:49852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTrx7-0001mQ-QD for submit@debbugs.gnu.org; Sun, 19 Feb 2023 17:14:38 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:38437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTrx6-0001mB-9M for 32026@debbugs.gnu.org; Sun, 19 Feb 2023 17:14:36 -0500 Received: by mail-qt1-f176.google.com with SMTP id f1so800750qtb.5 for <32026@debbugs.gnu.org>; Sun, 19 Feb 2023 14:14:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=cuVa+mb8P08SUlMMBLcjaQHRnpvLvAbDffk0GI4mcAE=; b=m6Uq29ejC8CrxSWq9WTdzavGXGWzgrc8Np/pIE7+ga3bO31HOnwVl0fn0uITmuq+Zg rmeD132SZrVCtcG8nch+SajX6BEU+Pkl/lGUPfNQYWTa2mRQ3jomkYmWWHLakjJOgACx 8QaT2Kv/H6F8JZn3UcbRUwGSKcZpDFYe+YR6i8Gkmy5gEP+LMgf35qfjJ+WmoUrWduSj ecWyHN+KQbHEKqKMLhIqo5Vf7uM1rVcNsGStvCIAIFMBMZC+UmhJh9OFFmEg0FAPG/ic odV64lbu/LxdaoYX91QGiIKfkKVB0LPi36QMh1lkf20mr9Ym9Rtl76hriH9dOWzyTxue +URQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cuVa+mb8P08SUlMMBLcjaQHRnpvLvAbDffk0GI4mcAE=; b=WRfXy7y25w2gVj+ofH2CBRT6RTOC/UO16mwWMKWi29S2JIjAkgWHyZwcxt3Yee84Ph a+HH2woZVMK+W9+cQxgE9FVsgoAsU0tVwAWOfETEt1cXf3q85mN7kkRM9A1lr9Hf0h+r 7VnG3qKAOS73Xtpq4EOmZ2plmCYqaA38uRlIVuMEJD8bGq7ZA62oItzPVqXwW4EpNukH 0YOsVlaYNfKVhaUk5fJwxuMANnUk3u2Pd2ZgTvIr6LKjFJICLLElsm9/+KaxbuVlyNbv aIRz4EWXGF3a/I9ej6ojx5MFv/U61nCZkBFj9Wta80fLyGvK0FSNbw66DL0bvN+yR+Pt AlBA== X-Gm-Message-State: AO0yUKXaT9TmA88mle4Yniu8rdPqfYIoIuxRGRKr/D+xsMMu/B66L7OV /pBy17ojvGPni40wGKuUW5RUsCPugxFq9A== X-Google-Smtp-Source: AK7set/o9L1ynrNDFzNSk3yoyCz/qsi7/q7KE+MeKRy9HMa7hsYvd4wjk0awidwzOflS/1I+dOFN4g== X-Received: by 2002:a05:622a:1ce:b0:3b9:b4b5:4b7a with SMTP id t14-20020a05622a01ce00b003b9b4b54b7amr16511048qtw.11.1676844870626; Sun, 19 Feb 2023 14:14:30 -0800 (PST) Received: from hurd (dsl-158-213.b2b2c.ca. [66.158.158.213]) by smtp.gmail.com with ESMTPSA id p71-20020a37424a000000b0073b275607f0sm7918714qka.65.2023.02.19.14.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 14:14:30 -0800 (PST) From: Maxim Cournoyer References: <20230219192405.26549-1-maxim.cournoyer@gmail.com> <20230219192405.26549-3-maxim.cournoyer@gmail.com> <87lektct0h.fsf@netris.org> Date: Sun, 19 Feb 2023 17:14:29 -0500 In-Reply-To: <87lektct0h.fsf@netris.org> (Mark H. Weaver's message of "Sun, 19 Feb 2023 15:13:55 -0500") Message-ID: <877cwdnvzu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 80CFE1571A X-Spam-Score: -2.84 X-Migadu-Spam-Score: -2.84 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: 9Vpaa13weoc8 Hi Mark, Mark H Weaver writes: > Hi Maxim, > > Maxim Cournoyer writes: >> * gnu/packages/gnuzilla.scm (%icecat-base-version): New variable. >> (%icecat-version): Define in terms of %icecat-base-version. >> (icecat-source): Adjust to use the above newly introduced variables. > > What's the rationale for this? I couldn't find any uses of > '%icecat-base-version' in your patch set outside of 'icecat-source'. > I don't have a strong objection, but it seems unjustified. > > Thanks, > Mark Not much anymore, but I just thought it was cleaner than having to do (base-version (first (string-split %icecat-version #\-))) later on to retrieve this information. -- Thanks, Maxim