From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oH2THD2lLmU0ywAA9RJhRA:P1 (envelope-from ) for ; Tue, 17 Oct 2023 17:16:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oH2THD2lLmU0ywAA9RJhRA (envelope-from ) for ; Tue, 17 Oct 2023 17:16:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D7B042BF5 for ; Tue, 17 Oct 2023 17:16:13 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Kt4u2rs3; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697555773; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mB1qKttpSOcYnWDLxVfmdqAJkfbFBqfe5U2ShI8xYGc=; b=mQ+W9DG9WUiuWshyzP8PcJqz1OsxmdYdEsNt5QZdBepae6RBxQjp4LotDruz+2C3e0Z4sQ +kmI3eYy7AfarnR+h8BBciPOQRt+JjbPOeyG6FcGo95NXaBRVE6M0cIpezeiBcznaXfIvw kYIzLW4daIB4EXKN3gi9N+Wcxw9p0rrYVi6IJancr4+h9PKyADfk78+Zp91L5JOk36tZqn u0Z2ycPF703tX0ZY8CFTdeQse+y95IoB6a7QCsLZVcmQ2eOpSiI2QDIt06QLvKgkBI4lsk Dvt+lHc9OMyVwd8fh0cm00MHyu6UIL/yDdqrH/zv6OaaW3dKnZuG7srHwFVxJg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697555773; a=rsa-sha256; cv=none; b=icBCFRVuPilz/UG15/WfNxqYpDtr1bD6e+TIPlGTn/P7HNZZJNgRn51GGMx9++XGR/H7aA TVUnK3Poh4SuNZ8XDQjuDNgDEV8Kqx8+PvSQkJes5d8w0TpphCVGnchJfiFRTi5PRnZXI5 xEqNiyaKtCzTGeuVOif6jGlaGNGxPA7JdAzpeSGl0or5AVZYmWNdL83CboFcbaPKRVpb7o P2U0K8GUh+GNGjz90VDcK/vjWLVOvi7gKY5nKISEBwStwCZhK1ZgrKzBbl88Bxs0S84TAi /ryql6xZa4HVdXJs2h5r7nBP+jC6kHPmWDCx3/NwlWVxjTAAV1r8iImsWsNdQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Kt4u2rs3; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qslnH-0005jv-DQ; Tue, 17 Oct 2023 11:15:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qslnF-0005jE-0l for bug-guix@gnu.org; Tue, 17 Oct 2023 11:15:37 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qslnE-0004eA-OV for bug-guix@gnu.org; Tue, 17 Oct 2023 11:15:36 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qslne-0004Kp-4E for bug-guix@gnu.org; Tue, 17 Oct 2023 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65924: [PATCH core-updates 3/3] gnu: git-minimal: Add coreutils and sed to PATH. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 17 Oct 2023 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65924 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 65924@debbugs.gnu.org, Simon Tournier Received: via spool by 65924-submit@debbugs.gnu.org id=B65924.169755575916654 (code B ref 65924); Tue, 17 Oct 2023 15:16:02 +0000 Received: (at 65924) by debbugs.gnu.org; 17 Oct 2023 15:15:59 +0000 Received: from localhost ([127.0.0.1]:60840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qslna-0004KY-PJ for submit@debbugs.gnu.org; Tue, 17 Oct 2023 11:15:59 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:46560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qslnX-0004KG-41 for 65924@debbugs.gnu.org; Tue, 17 Oct 2023 11:15:57 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7781bc3783fso48014985a.1 for <65924@debbugs.gnu.org>; Tue, 17 Oct 2023 08:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697555724; x=1698160524; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mB1qKttpSOcYnWDLxVfmdqAJkfbFBqfe5U2ShI8xYGc=; b=Kt4u2rs3aocKuxpbx6M+N+9O6CcWyPcf+kJCDVgwo/DDaoi2BiDkZ6UKrfZl0/lWB5 1sajyZsPbcXHWtUhASMV9CkQiFhGEsdl1qP/nITg9T+QWrI/XKzrex3uSqD5Yvzq677l m1hUGTMZoiTEMDYDyEX08jtOptZ7tprv1twVdcpnR6dgli5/nZz0ZTvOfSgLv/NFinm5 ocigjgsssiFLSZBF2t3TXOTsIQ7hX4+8dVg2+HQyUybsgmUbtUnap3uQ0JrJnlRCXQUE tDEru3Ng/8N9I1q2DJg0s7rSAoddPKEeIlzbYmZRfJ9GzvOK64Z2OtsfP3RwgjEf6wSI yAyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697555724; x=1698160524; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mB1qKttpSOcYnWDLxVfmdqAJkfbFBqfe5U2ShI8xYGc=; b=c1G35NV/DtrN3GReRHbIISLn00K1qMFXj8vRpbJLg90MXxKWfwldldAnJ41FcKdLvx uW/xNgD0YEvL/Vn+OC5l9j5Gx3xppAblldbhafhXjl9DAZV4+xbkxUBb+dILu/fugrJQ XsySztOKgOqBlvQWWP1TxM3JhOLfPoOV03ixZq0L8YGXkKPxgQLm4n1Qx1iI1fTKWRUD pVkh1ecL5ygCF4+34tuqd+mWlM7nQdfJ/SIaZk/o5lmW4v6DraSsNpF6xn2bh0O6hO8f alxI17al7yz7sWfT51hlqJ3ZmDMMfEmvgnk+TJBJI+6K6/1PsGjpztP+l7S7jsQbV/mi 1KQQ== X-Gm-Message-State: AOJu0YwZFSuVt+zdt9IR7NTAOoRl1tQAjGdNjSllHPXDwndnY1C4OTWb ux3U6DNQXTkDG/zSlJAgkqk= X-Google-Smtp-Source: AGHT+IFqSTeFV3v28Q1VXHdq+G904CMAMgHBXIHld5SAmZXaKzZS+aBD8BIceE6JX8Hos6vXqso7+A== X-Received: by 2002:a05:620a:3994:b0:76e:faf1:5e2c with SMTP id ro20-20020a05620a399400b0076efaf15e2cmr2375603qkn.45.1697555724005; Tue, 17 Oct 2023 08:15:24 -0700 (PDT) Received: from hurd (dsl-155-177.b2b2c.ca. [66.158.155.177]) by smtp.gmail.com with ESMTPSA id bk40-20020a05620a1a2800b0076cc4610d0asm727956qkb.85.2023.10.17.08.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 08:15:23 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87r0lxdtpt.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 14 Oct 2023 19:01:02 +0200") References: <9e15a3ab5f8d4f44b834e1fc90464312c60fac9e.1696734901.git.maxim.cournoyer@gmail.com> <87r0lxdtpt.fsf@gnu.org> Date: Tue, 17 Oct 2023 11:15:22 -0400 Message-ID: <877cnluvp1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 2.84 X-Migadu-Queue-Id: 2D7B042BF5 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 2.84 X-TUID: IOSMg6OE0bA/ Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> Fixes . >> >> * gnu/packages/version-control.scm (git-minimal) >> [arguments] : New field. >> : Augment with (ice-9 match), (ice-9 textual-ports) and (guix >> search-paths). >> : Add patch-commands phase. >> [inputs]: Add coreutils-minimal and sed. > > [...] > >> + #:imported-modules `(,@%gnu-build-system-modules >> + ,@(source-module-closure '((guix search-path= s)))) > > I think we should avoid the dependency on (guix search-paths) here, to > avoid situation such as that described in > . [...] > How about something along these lines instead: > > ;; Instead PATH definition at the top of the file. > (substitute* "git-sh-setup.sh" > (("^unset CDPATH" all) > (string-append "PATH=3D" (dirname (search-input-file inputs "bin/bas= ename")) > ":$PATH\nexport PATH\n" all))) > I've done something along these lines with commit ab9a88e355165025f7b4719017c0a40264167b22. Also see bug#66585 for a small doc addition hopefully serving as a reminder to not go down that path again. --=20 Thanks, Maxim