From: Arun Isaac <arunisaac@systemreboot.net>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Christopher Baines <mail@cbaines.net>
Cc: 65858@debbugs.gnu.org, guix-sysadmin <guix-sysadmin@gnu.org>
Subject: bug#65858: mumi crashes
Date: Thu, 26 Oct 2023 01:16:05 +0100 [thread overview]
Message-ID: <877cnai6gq.fsf@systemreboot.net> (raw)
In-Reply-To: <87wmvc4273.fsf@gmail.com>
Hi Chris and Maxim,
>> I think this is kind of expected. If NGinx hits the proxy_read_timeout
>> it'll return a 504 to the client and close the connection to Mumi I
>> think. I think what you're seeing here is Mumi trying to respond to a
>> request from NGinx that NGinx has closed.
Thanks for the tip. This indeed makes a lot of sense!
But, I don't understand why a proxy read timeout happens. The requests
in question seem to be very simple requests that shoud be processed
quickly. Should we increase nginx's proxy_read_timeout?
> If it's expected, we should handle it and produce a useful warning
> instead of crashing, right?
A couple of weeks ago, I put in a mechanism to better catch and report
errors.
https://git.savannah.gnu.org/cgit/guix/mumi.git/commit/?id=7a71c12a1f7f033ae93f26fb09387f6c04c143ba
I'm not sure this is working correctly, though. I have used `guard` in the
commit above. Does `guard` catch all exceptions correctly, or should I
instead use `catch`?
Also, I believe the logs are written in parallel by fibers. This may
mangle up the logs a bit, but I'm not sure if we're actually see
requests rapid enough for this to happen.
Regards,
Arun
prev parent reply other threads:[~2023-10-26 0:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 1:28 bug#65858: mumi crashes Maxim Cournoyer
2023-10-08 3:13 ` Maxim Cournoyer
2023-10-09 23:02 ` Arun Isaac
2023-10-10 3:51 ` Maxim Cournoyer
2023-10-10 22:57 ` Arun Isaac
2023-10-11 1:29 ` Maxim Cournoyer
2023-10-24 4:26 ` Maxim Cournoyer
2023-10-24 7:13 ` Christopher Baines
2023-10-24 12:47 ` Maxim Cournoyer
2023-10-24 13:15 ` Christopher Baines
2023-10-26 0:16 ` Arun Isaac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnai6gq.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=65858@debbugs.gnu.org \
--cc=guix-sysadmin@gnu.org \
--cc=mail@cbaines.net \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).