bug#72797: qt-tools is unnecessary optional dependency for monero

bug#72797: qt-tools is unnecessary optional dependency for monero

[0xFFFC via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi Guix community,

Thank you for your great software :)

I noticed that the Monero package has an (a huge) unnecessary dependency here [1]. qt is an optional dependency for Monero code base (we only need that in case of using translations).

Anyway to make this optional? or get rid of this?

1.https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/finance.scm#n716

Freedom wins.
0xFFFC

[-- Attachment #2: Type: text/html, Size: 1583 bytes --]

bug#72797: qt-tools is unnecessary optional dependency for monero

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

0xFFFC via Bug reports for GNU Guix <bug-guix@gnu.org> skribis:

> Hi Guix community,
>
> Thank you for your great software :)
>
> I noticed that the Monero package has an (a huge) unnecessary dependency here [1]. qt is an optional dependency for Monero code base (we only need that in case of using translations).
>
> Anyway to make this optional? or get rid of this?
>
> 1.https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/finance.scm#n716
>
> Freedom wins.
> 0xFFFC

Hi.

The qt-tools package is used to create the binary translations files
that are used by the monero-wallet-cli program, which seems to be
a useful thing.

What kind of issue is the dependency on qt-tools causing for you?

To disable translations, a variant of the monero package like the
following could work (not tested, I'm writing this example on the fly):

--8<---------------cut here---------------start------------->8---
(define-public monero-without-translations
  (inherit monero)
  (name monero-without-translations)
  (native-inputs (package-native-inputs monero)
    (delete "qttools-5")))
--8<---------------cut here---------------end--------------->8---

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#72797: qt-tools is unnecessary optional dependency for monero

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Here's a corrected definition:

--8<---------------cut here---------------start------------->8---
(define-public monero-without-translations
  (package
    (inherit monero)
    (name "monero-without-translations")
    (native-inputs (modify-inputs (package-native-inputs monero)
                     (delete "qttools")))))
--8<---------------cut here---------------end--------------->8---

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#72797: qt-tools is unnecessary optional dependency for monero

[Maxim Cournoyer]

tag 72797 + notabug
quit

Hi Guillaume,

Guillaume Le Vaillant <glv@posteo.net> writes:

> Here's a corrected definition:
>
> (define-public monero-without-translations
>   (package
>     (inherit monero)
>     (name "monero-without-translations")
>     (native-inputs (modify-inputs (package-native-inputs monero)
>                      (delete "qttools")))))
>

Thanks for providing the above tip for users who'd like rewrite the
dependencies of monero.  Guix will continue shipping translations in its
stock package, so you should use the above.  qt-tools is also a native
dependency, so shouldn't end up in the closure of the built package.

-- 
Thanks,
Maxim