bug#74583: ‘guix git authenticate’ pre-push hook unsuitable in some cases

bug#74583: ‘guix git authenticate’ pre-push hook unsuitable in some cases

[Ludovic Courtès]

As reported by Sébastien¹, the ‘pre-push’ hook installed by ‘guix git
authenticate’ fails when pushing the keyring branch because that branch
is not authenticated.

I’ve seen other situations where it fails, and IIRC one of them is when
pushing a tag.

We should list these corner cases and have ‘guix git authenticate’
install a fixed hook.

Ludo’.

¹ https://lists.gnu.org/archive/html/guix-devel/2024-11/msg00256.html

bug#74583: ‘guix git authenticate’ pre-push hook unsuitable in some cases

[Ludovic Courtès]

Ludovic Courtès <ludo@gnu.org> skribis:

> As reported by Sébastien¹, the ‘pre-push’ hook installed by ‘guix git
> authenticate’ fails when pushing the keyring branch because that branch
> is not authenticated.

Here’s what happens when running ‘git pull’ from the ‘keyring’ branch:

--8<---------------cut here---------------start------------->8---
$ git pull
remote: Enumerating objects: 9963, done.        
remote: Counting objects: 100% (9063/9063), done.        
remote: Compressing objects: 100% (1920/1920), done.        
remote: Total 8838 (delta 7033), reused 8721 (delta 6918), pack-reused 0        
Receiving objects: 100% (8838/8838), 3.83 MiB | 5.14 MiB/s, done.
Resolving deltas: 100% (7033/7033), completed with 150 local objects.
From ssh://git.sv.gnu.org/srv/git/guix
   1d5caad391..f8868dd56b  keyring           -> origin/keyring
   00fda872d0..b9afd0ae5e  go-team           -> origin/go-team
 + 34344d8e24...77e3ebbfe2 gsl-upgrade       -> origin/gsl-upgrade  (forced update)
   b51632cfa4..a36fe3204b  hurd-team         -> origin/hurd-team
 + 00f0b26fa8...022819af80 kde-team          -> origin/kde-team  (forced update)
 + 2104837001...7853ffd6ff kernel-updates    -> origin/kernel-updates  (forced update)
 + 566cd207a8...cf6a849f1b python-team       -> origin/python-team  (forced update)
   86f14d70d7..77e98a5546  r-team            -> origin/r-team
 + e40a906933...31e7d5d0d7 rust-team         -> origin/rust-team  (forced update)
 + 47a0a24991...aa3960c15e wip-zig-bootstrap -> origin/wip-zig-bootstrap  (forced update)
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Updating 1d5caad391..f8868dd56b
Fast-forward
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
 ekaitz-3F7356D6.key | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 ekaitz-3F7356D6.key
Authenticating commits 9edb3f6 to f8868dd (28 new commits)...
guix git: error: commit f8868dd56bff0f282329a33abb62262b2fc584b6 is not a descendant of introductory commit 9edb3f66fd807b096b48283debdcddccfea34bad
--8<---------------cut here---------------end--------------->8---

Ludo’.

bug#74583: ‘guix git authenticate’ pre-push hook unsuitable in some cases

[Ludovic Courtès]

And when pushing tags:

--8<---------------cut here---------------start------------->8---
$ git … push origin --tags
guix git: .[1;31merror: .[0mGit error: the requested type does not match the type in the ODB
error: failed to push some refs to 'ssh://git.sv.gnu.org/srv/git/shepherd.git'
--8<---------------cut here---------------end--------------->8---