bug#75464: Package thefuck is broken

bug#75464: Package thefuck is broken

[Andrew Stubbs]

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

"guix shell thefuck" fails:

building /gnu/store/qkhrgs2wvxwzhv71kzp6fhxnf3gk8nsh-thefuck-3.32.drv...
\ 'check' phasebuilder for
`/gnu/store/qkhrgs2wvxwzhv71kzp6fhxnf3gk8nsh-thefuck-3.32.drv' failed with
exit code 1
build of /gnu/store/qkhrgs2wvxwzhv71kzp6fhxnf3gk8nsh-thefuck-3.32.drv failed
View build log at
'/var/log/guix/drvs/qk/hrgs2wvxwzhv71kzp6fhxnf3gk8nsh-thefuck-3.32.drv.gz'.
guix shell: error: build of
`/gnu/store/qkhrgs2wvxwzhv71kzp6fhxnf3gk8nsh-thefuck-3.32.drv' failed

This is straight after a "guix pull". I tested on Ubuntu 20.04, Ubuntu
22.04, and Ubuntu 24.11.

From the logfile:


=========================== short test summary info
============================
FAILED
tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[le
cat-result0]
FAILED
tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[diff
x-result1]
FAILED
tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[fuck-result2]
FAILED
tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[cafe
\xf4-result3]

=================================== FAILURES
===================================
_
TestGetValidHistoryWithoutCurrent.test_get_valid_history_without_current[le
cat-result0] _


self = <tests.test_utils.TestGetValidHistoryWithoutCurrent object at
0x7ffff50aa290>
script = 'le cat', result = ['ls cat', 'diff x', 'café ô']



    @pytest.mark.parametrize('script, result', [

        ('le cat', ['ls cat', 'diff x', u'café ô']),

        ('diff x', ['ls cat', u'café ô']),

        ('fuck', ['ls cat', 'diff x', u'café ô']),

        (u'cafe ô', ['ls cat', 'diff x', u'café ô']),

    ])

    def test_get_valid_history_without_current(self, script, result):

        command = Command(script, '')

>       assert get_valid_history_without_current(command) == result

E       AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x',
'café ô']
E

E         Right contains one more item: 'café ô'

E

E         Full diff:

E           [

E               'ls cat',

E               'diff x',

E         -     'café ô',

E           ]



/tmp/guix-build-thefuck-3.32.drv-0/source/tests/test_utils.py:276:
AssertionError

[-- Attachment #2: Type: text/html, Size: 4583 bytes --]

bug#75464: Package thefuck is broken

[John Kehayias via Bug reports for GNU Guix]

Hi Andrew

On Thu, Jan 09, 2025 at 10:43 AM, Andrew Stubbs wrote:

[...]
> =========================== short test summary info ============================
> FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[le cat-result0]
> FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[diff x-result1]
> FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[fuck-result2]
> FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[cafe \xf4-result3]
>
> =================================== FAILURES ===================================
[...]

I noticed this as well recently, thanks for reporting. I think this is
the upstream issue: <https://github.com/nvbn/thefuck/issues/1438>.
Unfortunately there's been no activity there or on the project in
general (for a year). I guess we could disable just those tests and link
to the upstream issue, would you like to take a stab at a patch?

John