From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#30434: magit =?UTF-8?Q?won=E2=80=99t?= work over TRAMP Date: Mon, 12 Feb 2018 20:11:19 +0100 Message-ID: <876072koq0.fsf@elephly.net> References: <87lgfyl67x.fsf@elephly.net> <87mv0e2jvm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elc2z-0006cS-Ui for bug-guix@gnu.org; Tue, 13 Feb 2018 09:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elc2w-0008Fg-P1 for bug-guix@gnu.org; Tue, 13 Feb 2018 09:59:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elc2w-0008FW-Ii for bug-guix@gnu.org; Tue, 13 Feb 2018 09:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elc2w-0001vV-8f for bug-guix@gnu.org; Tue, 13 Feb 2018 09:59:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87mv0e2jvm.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Alex Kost Cc: 30434@debbugs.gnu.org Alex Kost writes: > Ricardo Wurmus (2018-02-12 13:53 +0100) wrote: > >> The default value for =E2=80=9Cmagit-git-executable=E2=80=9D (when magit= is installed >> via Guix) appears to be a store path, such as >> =E2=80=9C/gnu/store/l7g5r1c2i0bf3cd71g53ajy8khdcyidz-git-2.16.1/bin/git= =E2=80=9D. This >> means that when magit is used over TRAMP it will try to find the exact >> same git executable on the remote. >> >> Instead, magit should only look for =E2=80=9Cgit=E2=80=9D on the remote,= not for the >> exact store location of a particular git executable. >> >> I could only use magit over TRAMP after setting =E2=80=9Cmagit-git-execu= table=E2=80=9D >> to =E2=80=9Cgit=E2=80=9D. > > If people will agree that changing 'magit-git-executable' is not needed, > then I think 'git' can be removed from the inputs as it is used just for > that variable. > > P.S. I also use just "git" for 'magit-git-executable'. It took me way too long to figure out that this was the cause. I played with TRAMP settings before that and only noticed that something was off when I looked at the verbose TRAMP debug logs. I think it makes sense *not* to hardcode the path to the git executable here. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net