From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: 31974@debbugs.gnu.org
Subject: bug#31974: If a phase returns #f, a warning is issued, but the build continues
Date: Sun, 19 Aug 2018 15:53:03 +0200 [thread overview]
Message-ID: <876006ihts.fsf@gnu.org> (raw)
In-Reply-To: <87600qstkn.fsf@netris.org> (Mark H. Weaver's message of "Fri, 03 Aug 2018 23:23:52 -0400")
Mark H Weaver <mhw@netris.org> skribis:
> Mark H Weaver <mhw@netris.org> writes:
>
>> I just noticed that I made a mistake in commit
>> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in
>> (guix build gnu-build-system) to issue a warning if a phase returns a
>> value other than #t.
>>
>> The result is that if a phase returns a value other than #t, a warning
>> is issued, but the build nonetheless continues to the next phase, and
>> the build could ultimately "succeed" even some phases returned #f.
>>
>> In other words, the return values of phases are effectively ignored,
>> except for the warning, so the only way to cause a build with phases to
>> fail is to raise an exception.
>
> This should be fixed by commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df
> in core-updates.
Cool, thanks for not forgetting! :-)
Ludo’.
next prev parent reply other threads:[~2018-08-19 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 3:13 bug#31974: If a phase returns #f, a warning is issued, but the build continues Mark H Weaver
2018-06-27 20:14 ` Ludovic Courtès
2018-06-28 5:09 ` Mark H Weaver
2018-06-28 5:56 ` Gábor Boskovits
2018-06-28 15:46 ` Gábor Boskovits
2018-06-28 15:10 ` Ludovic Courtès
2018-06-28 17:51 ` Mark H Weaver
2018-08-04 3:23 ` Mark H Weaver
2018-08-19 13:53 ` Ludovic Courtès [this message]
2019-01-09 20:38 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876006ihts.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31974@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).