From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Marius Bakke <marius@gnu.org>
Cc: 41827@debbugs.gnu.org
Subject: bug#41827: lib2geom fails tests on i686-linux
Date: Sun, 14 Jun 2020 15:19:52 -0400 [thread overview]
Message-ID: <875zbth2uf.fsf@gmail.com> (raw)
In-Reply-To: <878sgsfoq2.fsf@gnu.org> (Marius Bakke's message of "Fri, 12 Jun 2020 14:33:25 +0200")
Hello Marius,
Marius Bakke <marius@gnu.org> writes:
> Marius Bakke <marius@gnu.org> writes:
>
>> lib2geom fails several tests on i686-linux:
>>
>> https://ci.guix.gnu.org/log/h3d9i8jqygnc3qvcd83c678kzmr5p4b7-lib2geom-1.0-1.42e119d
>>
>> This is a dependency of Inkscape 1.0.
>
> The same tests also fail on aarch64-linux:
>
> https://ci.guix.gnu.org/log/rq7d8y0b8cv7ils7wd3fq97br8j3d4xz-lib2geom-1.0-1.42e119d
>
> armhf-linux and x86_64-linux seems fine.
I had a quick look of the output, and it seems the failures are due to
comparison of inexact numbers. A quick idea would be to make sure that
the test suite is making use of Googletest's floating point comparison
macros, which are designed to handle variations on floats [0].
If that's the flaw, we sould implement a patch and contribute it to
upstream.
Maxim
next prev parent reply other threads:[~2020-06-14 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 12:30 bug#41827: lib2geom fails tests on i686-linux Marius Bakke
2020-06-12 12:33 ` Marius Bakke
2020-06-14 19:19 ` Maxim Cournoyer [this message]
2020-06-18 6:28 ` Maxim Cournoyer
2020-06-19 3:32 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zbth2uf.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=41827@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).