From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kAlaOf+ZRmDeAgAA0tVLHw (envelope-from ) for ; Mon, 08 Mar 2021 21:41:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2LMqNf+ZRmBNNwAAB5/wlQ (envelope-from ) for ; Mon, 08 Mar 2021 21:41:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7DC9C2749F for ; Mon, 8 Mar 2021 22:41:19 +0100 (CET) Received: from localhost ([::1]:60744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJNcs-0008Iq-HK for larch@yhetil.org; Mon, 08 Mar 2021 16:41:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJNcc-0008G8-Vh for bug-guix@gnu.org; Mon, 08 Mar 2021 16:41:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJNcc-0006fg-KC for bug-guix@gnu.org; Mon, 08 Mar 2021 16:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJNcc-00061D-Hq for bug-guix@gnu.org; Mon, 08 Mar 2021 16:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#46925: Ripgrep tests failures due to bstr update Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 08 Mar 2021 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46925 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 46925@debbugs.gnu.org X-Debbugs-Original-To: JOULAUD =?UTF-8?Q?Fran=C3=A7ois?= via Bug reports for GNU Guix X-Debbugs-Original-Cc: JOULAUD =?UTF-8?Q?Fran=C3=A7ois?= , John Soo , "46925@debbugs.gnu.org" <46925@debbugs.gnu.org> Received: via spool by 46925-submit@debbugs.gnu.org id=B46925.161523963723078 (code B ref 46925); Mon, 08 Mar 2021 21:41:02 +0000 Received: (at 46925) by debbugs.gnu.org; 8 Mar 2021 21:40:37 +0000 Received: from localhost ([127.0.0.1]:45069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJNcD-000603-5m for submit@debbugs.gnu.org; Mon, 08 Mar 2021 16:40:37 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJNcB-0005zh-06 for 46925@debbugs.gnu.org; Mon, 08 Mar 2021 16:40:35 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 89DE960004; Mon, 8 Mar 2021 21:40:28 +0000 (UTC) From: Nicolas Goaziou References: <8735xax46u.fsf@asu.edu> <87mtvifycw.fsf@nicolasgoaziou.fr> <20210308161856.rme6tdhbbr44zdev@fjo-extia-HPdeb.example.avalenn.eu> Date: Mon, 08 Mar 2021 22:40:27 +0100 In-Reply-To: <20210308161856.rme6tdhbbr44zdev@fjo-extia-HPdeb.example.avalenn.eu> ("JOULAUD =?UTF-8?Q?Fran=C3=A7ois?= via Bug reports for GNU Guix"'s message of "Mon, 8 Mar 2021 16:22:02 +0000") Message-ID: <875z21494k.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francois.JOULAUD@radiofrance.com, jsoo1@asu.edu Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615239679; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=EmdrAhALlcz1EcIcKqnS1i7F3HHDpMKAtQDsdrBRPwI=; b=Z6yp/Th507HvNOOOsM4zjbrxcDVvdaenn2QNc5YjvqxKiC2vjOnNoUAOO8V2saDREaulLK v/i+S3qnj3Vx+XOxQL8pXKXxULZDWWxOHn5bcG0z9zeIQsj0ZusdwVy3uUWmD2m5gUdN4b IxaUZchGagnYXlEVvCL3f2Tk580ChPkeaLcJfFK2RKqCa1M6/6TDVTxbnSmQXYeQLWsPLo g48ts6RYJCwDUGB2a4MyqyuFFIbL0DwoH/zlCiO6721sogOmUUOJgzDnJNxtPVemrVCBVg OUHPEYmyomMOA6CCMImUne04aWoXzb7EGHKWIlyjotVudm6lhk0oqsMh9KuguA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615239679; a=rsa-sha256; cv=none; b=bneQIHjOhdhQMJfStlr3qPj/v37BVhRXuVkui9o1JW+fV+AJXsBY2EOc6jWHmYlMT8Bu4o wjs1p/PvdVHv64eYPT5SGUzIdoarZduW+/TKm9KJzsvd/8EEUMnPslzYIbpq4r8pGO5MEB gYQSkwOSkIcH6NOaVs1BV1WzuZBIzx1RjZK2qSin0MfnIQh0DXAtR5ccsvkaRtql22GFlI bdcZgxMXeGLhf18zZq1/YP0qpGzon1e4KVrP3JrbcUOJNhxErdGzj/4ouRzO716NfZGoyq wmIxhCq954zBAtfeDElXr8E6P7r5e8Fkf+5ltjezVwVkJUu2yfNcYCYo08sq+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.38 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 7DC9C2749F X-Spam-Score: -2.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: FSLJdk1taRlX Hello, JOULAUD Fran=C3=A7ois via Bug reports for GNU Guix write= s: > Two possibilities seems to be possible here. > > Upgrade rust-bstr-0.2 to be 0.2.12, possibly only upgrading needed > dependent packages. Just to be clear, your are suggesting a downgrade, because currently, Guix packages bstr 0.2.15. Downgrading is not trivial because bstr 0.2.15 is mandatory for bat 0.18. We might provide both bstr 0.2.12 and 0.2.15. Note that 11 packages are requiring bstr. Providing two bstr is only possible if none of those packages are both among bat and ripgrep dependencies. I didn't check but I'm not very optimistic. > Patch new ripgrep to understand the old bstr debug format in its > tests. I'll pass, sorry. > Disabling tests is bad. Disabling tests when we diverge from supported > upstream configuration (in this cas as we don't use recommended version > of deps) is in my opinion even worst. I'm not sure this kind of generalization helps here. Even if you may be right in theory, looking at the number of "#:tests #f" among packages, disabling tests is probably a necessary evil in practice. Moreover, AFAICT, this incompatibility does not break functionality in ripgrep. It just breaks its tests. Disabling them for a while does not sound so bad, after all. Is it? Regards, --=20 Nicolas Goaziou