unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 39341@debbugs.gnu.org, 39341-done@debbugs.gnu.org,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#39341: Installer using 100% of a CPU core
Date: Thu, 29 Apr 2021 11:59:05 +0200	[thread overview]
Message-ID: <875z05mmxi.fsf@gnu.org> (raw)
In-Reply-To: <8735v91llu.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 29 Apr 2021 11:33:17 +0200")

Hello!

Mathieu Othacehe <othacehe@gnu.org> skribis:

> Your recent patch is just revealing an issue we always had with this
> Kmscon patch. Basically, without the "unlink" called you introduced, the
> FIFO fd was added only to the first discovered input and the keyboard
> layout was only applied to that very input.
>
> Conveniently, that input was always the main user keyboard I guess. The
> attached patch fixes that issue by registering the FIFO on the first
> input, but applying the keyboard layout to all the inputs.

Oh, fun (indeed I tested on a laptop with an external USB keyboard).

>>From 1a0fddd844ced62c802db0d6d133af45880435f0 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <othacehe@gnu.org>
> Date: Thu, 29 Apr 2021 11:11:32 +0200
> Subject: [PATCH] gnu: kmscon: Fix layout setup.
>
> Kmscon may discover multiple inputs, corresponding to multiple devices. This
> means that the uxkb_dev_keymap_update function may be called multiple times,
> and the FIFO is registered on each input poll loop.
>
> When a new layout is written on the FIFO by the installer, the first input
> picking up the message, will apply the new layout. However, that input may not
> be the input that the user is currently using.
>
> To fix it, register the FIFO on the first input poll loop, but apply the new
> layout on all the inputs in the uxkb_keymap_update_handler function.
>
> * gnu/packages/patches/kmscon-runtime-keymap-switch.patch
> (uxkb_keymap_update_handler): Apply the new layout to all the inputs.
> (uxkb_dev_keymap_update): Register the FIFO fd only on the first input poll loop.

Tested in a VM: it switches layouts like crazy, doesn’t leak a single
FD, and generally behaves as expected.

Thumbs up!

Thanks,
Ludo’.




  reply	other threads:[~2021-04-29 10:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29  5:19 bug#39341: Installer using 100% of a CPU core Maxim Cournoyer
2021-04-25 21:41 ` Ludovic Courtès
2021-04-26 14:32   ` pelzflorian (Florian Pelz)
2021-04-26 16:07     ` Ludovic Courtès
2021-04-26 16:14       ` pelzflorian (Florian Pelz)
2021-04-27 10:38         ` Ludovic Courtès
2021-04-27 12:32           ` pelzflorian (Florian Pelz)
2021-04-27 17:43             ` Bengt Richter
2021-04-27 19:58               ` pelzflorian (Florian Pelz)
2021-04-27 21:26             ` Ludovic Courtès
2021-04-28  7:02               ` pelzflorian (Florian Pelz)
2021-04-28  7:06                 ` pelzflorian (Florian Pelz)
2021-04-28 13:43                 ` Ludovic Courtès
2021-04-28 15:20                   ` pelzflorian (Florian Pelz)
2021-04-29  9:33                   ` Mathieu Othacehe
2021-04-29  9:59                     ` Ludovic Courtès [this message]
2021-04-29 10:13                       ` Mathieu Othacehe
2021-04-29 10:47                     ` pelzflorian (Florian Pelz)
2021-04-28 15:22                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z05mmxi.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=39341-done@debbugs.gnu.org \
    --cc=39341@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).