unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 40998@debbugs.gnu.org
Subject: bug#40998: Guix System's initrd doesn't honor rootflags
Date: Sun, 27 Feb 2022 22:06:34 +0100	[thread overview]
Message-ID: <875yp0uihx.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220219070155.1924-3-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 19 Feb 2022 02:01:54 -0500")

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> * gnu/build/linux-boot.scm (boot-system): Honor rootfstype and rootflags
> arguments.  Update doc.  Error out in case there is insufficient information
> with regard to the root file system.
> Restore the behavior of inferring the root device from the root file system
> from the operating system in case the root argument is not provided.
> * doc/guix.texi (Initial RAM Disk): Document the new command-line parameters.

Very nice!

[...]

> -        (if root-device
> -            (mount-root-file-system (canonicalize-device-spec root-device)
> -                                    (file-system-type root-fs)
> -                                    #:volatile-root? volatile-root?
> -                                    #:flags (mount-flags->bit-mask
> -                                             (file-system-flags root-fs))
> -                                    #:options (file-system-options root-fs)
> -                                    #:check? (check? root-fs)
> -                                    #:skip-check-if-clean?
> -                                    (skip-check-if-clean? root-fs)
> -                                    #:repair (repair root-fs))
> -            (mount "none" "/root" "tmpfs"))
> +        ;; Mount the root file system.
> +        (mount-root-file-system (canonicalize-device-spec

I think the ‘if’ had (has?) a justification but I’m not sure what that
was.  It’s likely nobody will notice if we remove it anyway.  :-)

Ludo’.




  reply	other threads:[~2022-02-27 21:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 13:53 bug#40998: Guix System's initrd doesn't honor rootflags maxim.cournoyer
2022-02-18 15:33 ` bug#40998: [PATCH 1/3] initrd: Rename the '--root' initrd option to just 'root' Maxim Cournoyer
2022-02-18 15:33   ` bug#40998: [PATCH 2/3] initrd: Honor rootfstype and rootflags command-line parameters Maxim Cournoyer
2022-02-18 15:33   ` bug#40998: [PATCH 3/3] initrd: Print its " Maxim Cournoyer
2022-02-19  7:01 ` bug#40998: [PATCH v2 1/4] system: Add a version field to the <boot-parameters> record Maxim Cournoyer
2022-02-19  7:01   ` bug#40998: [PATCH v2 2/4] initrd: Use non-hyphenated kernel command-line parameter names Maxim Cournoyer
2022-02-27 21:03     ` bug#40998: Guix System's initrd doesn't honor rootflags Ludovic Courtès
2022-02-28 20:31       ` Maxim Cournoyer
2022-02-19  7:01   ` bug#40998: [PATCH v2 3/4] initrd: Honor rootfstype and rootflags command-line parameters Maxim Cournoyer
2022-02-27 21:06     ` Ludovic Courtès [this message]
2022-02-19  7:01   ` bug#40998: [PATCH v2 4/4] initrd: Print its " Maxim Cournoyer
2022-02-27 21:08     ` bug#40998: Guix System's initrd doesn't honor rootflags Ludovic Courtès
2022-02-28 20:36       ` Maxim Cournoyer
2022-02-28  3:45     ` bug#40998: [PATCH v2 4/4] initrd: Print its command-line parameters Tobias Geerinckx-Rice via Bug reports for GNU Guix
2022-02-28 15:54       ` Maxim Cournoyer
2022-02-27 20:54   ` bug#40998: Guix System's initrd doesn't honor rootflags Ludovic Courtès
2022-02-28 20:02     ` Maxim Cournoyer
2022-02-28 21:15       ` Ludovic Courtès
2022-02-28 21:45         ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yp0uihx.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=40998@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).