From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iMhPFIYxHWJOsgAAgWs5BA (envelope-from ) for ; Mon, 28 Feb 2022 21:33:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UN3jEYYxHWJ61QAA9RJhRA (envelope-from ) for ; Mon, 28 Feb 2022 21:33:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC39514A04 for ; Mon, 28 Feb 2022 21:33:09 +0100 (CET) Received: from localhost ([::1]:56880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOmhh-0007Cl-4U for larch@yhetil.org; Mon, 28 Feb 2022 15:33:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOmha-0007CN-69 for bug-guix@gnu.org; Mon, 28 Feb 2022 15:33:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOmhZ-0006Cq-Tb for bug-guix@gnu.org; Mon, 28 Feb 2022 15:33:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOmhZ-0004kt-Qr for bug-guix@gnu.org; Mon, 28 Feb 2022 15:33:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#40998: Guix System's initrd doesn't honor rootflags Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 28 Feb 2022 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40998 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 40998-submit@debbugs.gnu.org id=B40998.164608032418204 (code B ref 40998); Mon, 28 Feb 2022 20:33:01 +0000 Received: (at 40998) by debbugs.gnu.org; 28 Feb 2022 20:32:04 +0000 Received: from localhost ([127.0.0.1]:34861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOmge-0004jY-A6 for submit@debbugs.gnu.org; Mon, 28 Feb 2022 15:32:04 -0500 Received: from mail-qv1-f41.google.com ([209.85.219.41]:36753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOmgc-0004j2-NJ for 40998@debbugs.gnu.org; Mon, 28 Feb 2022 15:32:03 -0500 Received: by mail-qv1-f41.google.com with SMTP id w7so14625383qvr.3 for <40998@debbugs.gnu.org>; Mon, 28 Feb 2022 12:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=kaX8DLNhZ3UV0kl5ZUnQEMwDUduLfp2WmWITywk+ykQ=; b=iXyk0cGQ+V1pRdkbYTQ2aMaynkLtQFQYxYKpK+GceaAe+xv+nbST2rnbXqBR+FM1Bv kSp4cT7nwoca1WAAPMfkDFbAZMB6y0oWOslaidNNN+cZvOhdqnhaHixKZ0pzygvDt28V YahkAoHydSedcZW2ducZE6XX91M23p+D4XhgDdCQj0mlg25PpawkzoD3wc0FxSzdRF7S 93PAP6KVfOqkhJL9A89RXX694cDTn+3X1JquQnDppdUKJiWHiG4tV4GobrdB8t6S6TKR RyZmnrfiVcQyL+RX7VabPicbJdd7FbVjOeCiZjM2jgT7bNheuDautXd93Tyv/IgWy6Mh EQ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=kaX8DLNhZ3UV0kl5ZUnQEMwDUduLfp2WmWITywk+ykQ=; b=W9U6oOUG9O6clKOSy1rACgz8u2tj4FE+t0F1inLcY2vd6+0QkhdZKgkWjVF6nQRX9G Djr7zHB2BuD70bQ69SemE28irI0aRMNTuc6s3xFOWd67T7FJkGN90Xyqkjsotyv2R+n7 qP0cVx75fCEt7D9f1ZNd78UM9jzlc0NBwPGByji+EH2Tem5I7Vc1aquhpiVspVBfE7qg SWvsGud5jl+bPzmDHk/oI7h5DOP2iDUyVEEJ8oVorwaDYmlv1TsOxyWfFXf0rboOAWaU xgCmM0xAwq4vnPARfcIJ6oSD8iqtlc8j5GoHcDkzZAhZoz0IoFlPKZMvVZUC6sZ5RVhu qr0w== X-Gm-Message-State: AOAM530yF1aAXJiTzWPGFV+HMH8My41/26DnNlcQoHTG0Q/XT1NsaExd j//2L+agXO5JvlohJu1VCCiz8vTe2ts= X-Google-Smtp-Source: ABdhPJwBRU1CeNYT8lTShLP3IVJByOi2EGCXFDUaQ1WDZtmq5Ah68UxnBH3xj2OVcjBvEHItF7wIkw== X-Received: by 2002:a05:622a:588:b0:2de:9242:8788 with SMTP id c8-20020a05622a058800b002de92428788mr17927732qtb.76.1646080316944; Mon, 28 Feb 2022 12:31:56 -0800 (PST) Received: from hurd (dsl-141-227.b2b2c.ca. [66.158.141.227]) by smtp.gmail.com with ESMTPSA id h188-20020a376cc5000000b0064957b23a9csm5501800qkc.118.2022.02.28.12.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 12:31:56 -0800 (PST) From: Maxim Cournoyer References: <20220219070155.1924-1-maxim.cournoyer@gmail.com> <20220219070155.1924-2-maxim.cournoyer@gmail.com> <87bkysuimk.fsf_-_@gnu.org> Date: Mon, 28 Feb 2022 15:31:55 -0500 In-Reply-To: <87bkysuimk.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 27 Feb 2022 22:03:47 +0100") Message-ID: <875yoyu404.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 40998@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646080389; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kaX8DLNhZ3UV0kl5ZUnQEMwDUduLfp2WmWITywk+ykQ=; b=b416Uc4ycr9EKbBR7kHp2vZOk0e1qFDSF4Lcf55elaVN59TjwtP8WzrS8VT6KAAVxfHyio eQlPE42j4ZNzlWMPh8r8lpwIre2GMq0s3Rsh2eQZeYa4T79OLvkDxG1EklEwkzGM+BRNZY 3QeyUK0bRipacp+Md9e6lf/FuQQjJEY8Ex29gxoJRau0AVc9kAkIjkrrSLqZ/IKiKQq7At JicJp3IwMGPPr2AqX9OLIbQ4ZuuyzgVwpSjv8YtMAoBJ3XkyS9lGSh0+ho3uneSOlHRIbV nQSPqiYwnMAIW52YRLX/TkI2imZryUjLJIrKdLOzU/PtBjgGuX74Sq8h4MKXMw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646080389; a=rsa-sha256; cv=none; b=gSEX4P8SB4Ppq4Nq9RGojeMfMBvTvXY0qTHVVo/ZRMno30Bd/Jmy6PZqgJSZNhD9sSW+Id SaBQ03ZpkpBE97uBWVYdEVt8VgYVEsFoezMI9BcfNrIP1b70NMp9W4aZeaMFSQIz93Td17 S9MnJLRMbJc8p3RS+/yUUkcYQK1ku9UhwGadDanU8jnWrLXqxuz7udFRNcIExj41tnfDlh UFW6XmjFJOg5gjcey59KpPCenlhqetVWU/DAwUr4NU3zSLELTt69Y1UIaTC+GUDBwApj7z JJrK5Pdg9CLUAFkMYCh60QQFczep73YSB4poLwoaUK72kzDhJi7DqowacimSjg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iXyk0cGQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iXyk0cGQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DC39514A04 X-Spam-Score: 5.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: cb9UkOX+v1hc Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> -(define (bootable-kernel-arguments system root-device) >> - "Return a list of kernel arguments (gexps) to boot SYSTEM from ROOT-D= EVICE." >> - (list (string-append "--root=3D" >> +(define* (bootable-kernel-arguments system root-device version) >> + "Return a list of kernel arguments (gexps) to boot SYSTEM from ROOT-D= EVICE. >> +VERSION is the target version of the boot-parameters record." >> + ;; If the version is newer than 0, we use the new style initrd parame= ter >> + ;; names, otherwise we use the legacy ones. This is to maintain back= ward >> + ;; compatibility when producing bootloader configurations for older >> + ;; generations. >> + (define version>0? (> version 0)) >> + (list (string-append (if version>0? "root=3D" "--root=3D") >> ;; Note: Always use the DCE format because that'= s what >> - ;; (gnu build linux-boot) expects for the '--roo= t' >> + ;; (gnu build linux-boot) expects for the 'root' >> ;; kernel command-line option. >> (file-system-device->string root-device >> #:uuid-type 'dce)) >> - #~(string-append "--system=3D" #$system) >> - #~(string-append "--load=3D" #$system "/boot"))) >> + #~(string-append (if #$version>0? "gnu.system=3D" "--system=3D"= ) #$system) >> + #~(string-append (if #$version>0? "gnu.load=3D" "--load=3D") >> + #$system "/boot"))) > > This is the logic I was suggesting to move to =E2=80=98read-boot-paramete= rs=E2=80=99. > > To do that, =E2=80=98read-boot-parameters=E2=80=99 would have to fill the > =E2=80=98kernel-arguments=E2=80=99 field of such that i= t already > contains --system/gnu.system and --load/gnu.load. As mentioned in my previous reply, that'd only be possible if we no longer cared about having the produced system directory content-addressable, if I understood that comment in the docstring referred earlier correctly. Thanks, Maxim