From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kNwkD8FuYGLVKwEAbAwnHQ (envelope-from ) for ; Wed, 20 Apr 2022 22:36:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AAU3D8FuYGLBwQAA9RJhRA (envelope-from ) for ; Wed, 20 Apr 2022 22:36:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E737B2F411 for ; Wed, 20 Apr 2022 22:36:16 +0200 (CEST) Received: from localhost ([::1]:34402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhH3f-0006Nl-Nk for larch@yhetil.org; Wed, 20 Apr 2022 16:36:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhGhC-0001hJ-5o for bug-guix@gnu.org; Wed, 20 Apr 2022 16:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhGhB-0004Cw-Sr for bug-guix@gnu.org; Wed, 20 Apr 2022 16:13:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nhGhB-0002hj-P2 for bug-guix@gnu.org; Wed, 20 Apr 2022 16:13:01 -0400 Subject: bug#54893: guix-daemon, locale, LANG, and unicode in git tag names Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 20 Apr 2022 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54893 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Attila Lendvai Mail-Followup-To: 54893@debbugs.gnu.org, ludo@gnu.org, attila@lendvai.name Received: via spool by 54893-done@debbugs.gnu.org id=D54893.165048555810348 (code D ref 54893); Wed, 20 Apr 2022 20:13:01 +0000 Received: (at 54893-done) by debbugs.gnu.org; 20 Apr 2022 20:12:38 +0000 Received: from localhost ([127.0.0.1]:47586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhGgo-0002gq-FQ for submit@debbugs.gnu.org; Wed, 20 Apr 2022 16:12:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhGgm-0002ga-CA for 54893-done@debbugs.gnu.org; Wed, 20 Apr 2022 16:12:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhGge-00048m-SI; Wed, 20 Apr 2022 16:12:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=s6Ruu3hr1nbneUKHvaXXXRBN/jGdafnrZWMqfMnD3ZM=; b=nXSkZkyQl+8hbfCNBXTf H4DLaHq2jqd3njWcehLsYibn4d7IyUpQfFnrry2a2mgyTWGp5T/XNqM+HLc9c3UqQGhim9fApxCT8 dz/FJk+wLtqqW3Zkb5OqN51LERRk2BX/BFL6NOF6wFeLQbM7E5Y0TvmhxLNLGhGQFFBN82gp3uYjr PxQeMlXSd36OB7j0ooBfreZ2DJ9LrgAfkW+oqhRvtOgRVCS6Lqz5N4YtjOuew2HVWvDJNgbo9oYgc la3300ZA0SBIgSQPmP3xmYxVCiigPx+EhhEC4c5FItcwRyADg7CuWZSiSnGcCJHmJEphKyy/8i8uL pFBeSGe7jYta8w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61344 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhGge-0003gG-BS; Wed, 20 Apr 2022 16:12:28 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220419180954.9636-1-attila@lendvai.name> Date: Wed, 20 Apr 2022 22:12:26 +0200 In-Reply-To: <20220419180954.9636-1-attila@lendvai.name> (Attila Lendvai's message of "Tue, 19 Apr 2022 20:09:55 +0200") Message-ID: <875yn3o6ol.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54893-done@debbugs.gnu.org, Liliana Marie Prikler Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650486976; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=s6Ruu3hr1nbneUKHvaXXXRBN/jGdafnrZWMqfMnD3ZM=; b=XsO0guXdnFVN04DkhEuKduA74ov8HpDx7Kfe040rUhdLulyMPWMRmY5ey4uyYl6oJLVuqh 5jFa/kSOLAWe+g/SbAzZjufJcxPumucG4KmCMHnFfrfiiK0EzU4t2poOddEXX1JhGwR8wl oQa56hmb6QXRE9r9i+pcs4Aym5UijkPRCZXUdIJO2vYwAbQ4ZlMM1lAkDoR+PLRZet264J YA4b/xNGyi9lySjOJJUYi1lv8IV+RZ5/2Fx2JJma5nODp1W2M3AK/dsWBD52qT5rwU4SUj kgFXm7zBJSq0iUq7M5OYIKoli0M1czwUSODvLeYHm1Oo/n9tF/5CWJ1MJeAg+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650486976; a=rsa-sha256; cv=none; b=pNMl97CLHfIxkC1mA9urGTjFwsXA1Tg6hkgf/xUugvy8R7UkHCK0Rg/S5c1AA+Lrkg0vvI Lqe0NP2sSP+qPeX+T3CWm95Eob/jAkO+yMfcSfBa0k0qtOMX6466/Xj/oKTzNCXcQjKQXH s74F4isfD+zqi9oeXvb/PuOaRk4ve/Qr48eiRHpOTbccj+kAYwwjrf1FewTIpJ/r6oG4l0 B3gXBt6H2R9AA0x8gltImFVR1qhnBgtKzt+F1Ee/qWtiVmnTkN680EvV5sJyyQ0I5x3nqT FSHgsnf+SbZBN/tW6uvGcB5qWbChKwuyDIRr6zbYI1pe2mvq/yLPBKpHV/SmgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nXSkZkyQ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nXSkZkyQ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E737B2F411 X-Spam-Score: -5.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: YE/OEuwUB/cI Hi, Attila Lendvai skribis: > Without this the git-fetch GEXP is run in an environment that uses ASCII > character encoding when strings are crossing the Guile - C boundary. It = means > that e.g. tag names that have Unicode chars in them will cause problems, > e.g. when walking and deleting the .git directory. > > An example in the wild: https://github.com/klauspost/pgzip/tags > > For more details see: https://issues.guix.gnu.org/54893 > > * guix/git-download.scm (git-fetch): Call setlocale to set it to en_US.ut= f8. [...] > + (define glibc-locales > + (module-ref (resolve-interface '(gnu packages base)) 'glibc-locales)) I changed this to =E2=80=98glibc-utf8-locales=E2=80=99, which is sufficient= here, and committed. Thanks everyone for the investigation and fix! Ludo=E2=80=99.