From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sL6zD4pfUWPO1QAAbAwnHQ (envelope-from ) for ; Thu, 20 Oct 2022 16:47:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yNHED4pfUWMcGwAAauVa8A (envelope-from ) for ; Thu, 20 Oct 2022 16:47:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C276831C5A for ; Thu, 20 Oct 2022 16:47:37 +0200 (CEST) Received: from localhost ([::1]:38370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olWpV-0006Wo-8z for larch@yhetil.org; Thu, 20 Oct 2022 10:47:36 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olWk9-0001wT-7h for larch@yhetil.org; Thu, 20 Oct 2022 10:41:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWjM-00015v-AC for bug-guix@gnu.org; Thu, 20 Oct 2022 10:41:20 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1olWjG-0004cC-Bj for bug-guix@gnu.org; Thu, 20 Oct 2022 10:41:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1olWjG-0000MW-6t for bug-guix@gnu.org; Thu, 20 Oct 2022 10:41:02 -0400 Subject: bug#55360: bug#58375: Installer does not show what is being downloaded Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Thu, 20 Oct 2022 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 55360 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , 55360-done@debbugs.gnu.org, 58375-done@debbugs.gnu.org Mail-Followup-To: 55360@debbugs.gnu.org, othacehe@gnu.org, ludo@gnu.org Received: via spool by 55360-done@debbugs.gnu.org id=D55360.16662768231317 (code D ref 55360); Thu, 20 Oct 2022 14:41:01 +0000 Received: (at 55360-done) by debbugs.gnu.org; 20 Oct 2022 14:40:23 +0000 Received: from localhost ([127.0.0.1]:35900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olWic-0000L4-Rg for submit@debbugs.gnu.org; Thu, 20 Oct 2022 10:40:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olWiZ-0000Kh-Iv; Thu, 20 Oct 2022 10:40:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWiT-0004S7-9X; Thu, 20 Oct 2022 10:40:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xq8qCLhr/yT7fmIPsPynd2yaLg2UsCANvV6zqIAXLaM=; b=mw9gkFMy1U+waSOzdta/ RoNFNCt0wOo/BrDMpJn1R1NvcpC91J/cs4tNDCv8VL1HxodwJCdeWaADh3dBMm5cbJ7U+d+umK7GO 4MtS06CJDDsnaBH112vOIGVN8QFbI4wEBXa3B5f4/KkxoFTPJRHhHQRsm+2qc/uGLVKi4LrFIPhut GaZiT3suMwTqJ4rMRP8iHm91tctS8j8z5bSMMkt+mgak6b2OGf+EUNhNnAU0CBoQVLUN0AxFL2o+Y WEDWmyYOWWRXSRzMZDTZwzby54r6E2Sm5ySbqYjEGWNCX/E6oAlPdi7FaHHSWT3+GFNDSeusBpsFT Ki/5p6sjd62V1w==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:59608 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWiR-0002Mf-RD; Thu, 20 Oct 2022 10:40:12 -0400 From: Mathieu Othacehe References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> <871qrabeav.fsf_-_@gnu.org> <87czapma90.fsf@gnu.org> Date: Thu, 20 Oct 2022 16:40:08 +0200 In-Reply-To: <87czapma90.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 18 Oct 2022 17:17:47 +0200") Message-ID: <875ygepnhz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666277257; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xq8qCLhr/yT7fmIPsPynd2yaLg2UsCANvV6zqIAXLaM=; b=KRjrj85teo/4RpHSnQWNxQgqcvfZvPLNxnK0ACKycFowloIrwr+kAJlSJikm/7NlpqF1Ye KD/Vt/FSsglBp81kEffpQ30A3X0PnxiA0rsMfyyklElDJWuE/mYGhL9rJ95rA/hft8Za1E A56jsTj0wLM71hEXtnyWla7ItlPC1Bt0/SSNExAWzC4vPqeHg+1PyNK5sg0P7u9qVM/Z2z 7fx58ZnJOzY8ps8Y9l1mRLvtxD8EzsP4TWUCRaj9AUlPfo8y2jo9m0Le7o8z+GH5K1uLnr GbGLNiCirA2p6uxqkTPDL9VbXU9LXDKcDaPSXNn3+PD/q5NAS5KUyWvDW6zuxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666277257; a=rsa-sha256; cv=none; b=VmRoHOXwPlncOCpYj9tBmA7rmhMg30gsjYh81fcegyf6j7zDdBryDodNfeGmRLNFLIb7Xv wjMOadATlC6ExMv3/XuNcEEBGaJiuGtx+vxLIqgR0mwpWh0NnNO7T8TfC7k6V1ND51u7Fq P4wfJMz5rDoY4HOaXG6r6wKsZOVUAP5Zl4Y8H0ZPZoHxpEaRrWTZcf2ftCyEWG6qa9cRW9 L8qNGmdtesModIe5kLzMyuRBp8bLzGEtVZIj5Vjt8xHBrh7Z6Z7P8QdqLjV4VepQM19oGG fHLhSREYZnuzIKfkOKQoosilzDPk2C6dLATQUYfzvYdoapsF5ulKH0Xm/03m6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mw9gkFMy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=mw9gkFMy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C276831C5A X-Spam-Score: -3.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: JujXS+qCDFrJ Hey, Thanks for having a look! > I haven=E2=80=99t actually tested the patch but it LGTM. One thing to ch= eck is > whether =E2=80=98terminal-window-size=E2=80=99 returns something sensible= for the > pseudo-terminal; it could be that we need an extra ioctl so the > pseudo-terminal has the same size as the actual terminal. Well it returns 0 for all fields, but I tested on several screen sizes and everything seems fine so I went ahead. While testing I noticed two new issues though: 1. When the disk is GPT partitionned there is no confirmation page in "run-label-page". Something I missed in #57232. 2. When there is an exception in run-external-command-with-handler/tty for instance, the backtrace page is displayed in the PTY and the keyboard shortcuts do not work anymore. I'll address point 1 shortly but could use some advice for point 2. Thanks, Mathieu