From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2DV7KxnwdWMG4AAAbAwnHQ (envelope-from ) for ; Thu, 17 Nov 2022 09:26:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +HyXKhnwdWM4hwAAG6o9tA (envelope-from ) for ; Thu, 17 Nov 2022 09:26:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C5DA1A60A for ; Thu, 17 Nov 2022 09:26:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovaCm-0007ii-Rf; Thu, 17 Nov 2022 03:25:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovaCk-0007iL-Vq for bug-guix@gnu.org; Thu, 17 Nov 2022 03:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovaCk-0000v9-MK for bug-guix@gnu.org; Thu, 17 Nov 2022 03:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovaCk-0000ZO-FG for bug-guix@gnu.org; Thu, 17 Nov 2022 03:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#58485: [shepherd] Restarting guix-publish fails Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 17 Nov 2022 08:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58485 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Lars-Dominik Braun Cc: 58485@debbugs.gnu.org Received: via spool by 58485-submit@debbugs.gnu.org id=B58485.16686734582107 (code B ref 58485); Thu, 17 Nov 2022 08:25:02 +0000 Received: (at 58485) by debbugs.gnu.org; 17 Nov 2022 08:24:18 +0000 Received: from localhost ([127.0.0.1]:59025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovaC1-0000Xv-SN for submit@debbugs.gnu.org; Thu, 17 Nov 2022 03:24:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovaBz-0000Xh-MK for 58485@debbugs.gnu.org; Thu, 17 Nov 2022 03:24:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovaBt-0000m0-Qk; Thu, 17 Nov 2022 03:24:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fEWiBpZo23p5z1lAbmjhGVOV3wbuMuK5tAAuLPTbtNs=; b=G5rKjSAsWw0a7MXWL9Q/ btXd13T6aRs2drBVycSlWmVyn1PwOdnOkvODUDZGgzdVzOB5bEqs2yejlQHmHl2cLo5D3diroZ4X4 CKKWeNt7lNrjzaAI+TJszo2EkM4Pw6Ml8HNE4JbS1JycAnE9XSnxJWTiDjDY7uED3GLD+Q9VTKjqJ cciprxf2eoaSiEMS0MQuO8t3LSDEvOetrZ3Wl+ofLIef5+l2deXy4EaiVv/XeElN8eIlhgHfA+5Fn Y8rNK8K3qaUZIc2u/ynXNwfXesV+i8VnOKYFMUZV72BSlky2VGZB5qrmM32DkaWk0qXgiEvoMKsnW 5Cmw3NivQdA16Q==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovaBs-0001xB-6M; Thu, 17 Nov 2022 03:24:08 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 17 Nov 2022 09:24:05 +0100 In-Reply-To: (Lars-Dominik Braun's message of "Thu, 13 Oct 2022 09:51:58 +0200") Message-ID: <875yfekmze.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668673561; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fEWiBpZo23p5z1lAbmjhGVOV3wbuMuK5tAAuLPTbtNs=; b=TCYxNYAbSayJKGtem7R20R/gX6bbAX4w84kq+6gVmhQ/uz7PdyeYKyQHHbnWARyN/M1eeI f2m06ZJO2xLS1biXHLobwhIlTWuVlineC4ny6G33nqGRfnvXl/vC/EbEfNak/uQzyR1M4e OOCeLY8J54IY8u4iQS7BLw44VAOaE1oojq+g652s298DQjx5KOJa+pB2VxAQg8K166aeDb VHsubS3DVVPlom1H27nTxOUfF/wUQC6SfNQreRciMY1ug7Xm1wum2SoFuk+KQsPJFkkYLg G/rwBmbEc0r5F3Tv+SAypryojyrA/tmzyX+YPK0Q2jWo4yuz/ydfuSuhm8imrw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668673561; a=rsa-sha256; cv=none; b=TDBCe2oTusfWYJUGiR0LsDEu0gkwvxeHAmQrB9sO0OS/OOqvLIGxZCDJ3U6hyvspES6bEw lUNrvwGx9TgW5ASSEHTPdUzZBQy+DCr/CSniTS8EhimApkPTytI4cNERE1ean6KS5YCc3T wzwqltLPLX1hji2LtnzQbPgAvHmOzjk/L89ZiZH2MAl3lIIG4a3gf5sLropKpPF9djkG9D tlRyyqJlK49xCUOfvu0cM46//ZR0ybKrr5WNiSPIbxtsD2GDVnqQPWn+kygGoVQCZY/lxB DVD5e29pvKsJpwLvF7eoXENJAhglkQ0eQVUVkhB1OIEi3KrTuGLBfUnaYwKTLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=G5rKjSAs; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=G5rKjSAs; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4C5DA1A60A X-Spam-Score: -5.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: j0LmRGE9cHDL Hi, Lars-Dominik Braun skribis: > 1 kill(-18096, SIGTERM) =3D 0 > 1 newfstatat(AT_FDCWD, "/etc/localtime", {st_mode=3DS_IFREG|0444, st_= size=3D2298, ...}, 0) =3D 0 > 1 write(17, "shepherd[1]: Service guix-publish has been stopped.\n", = 52) =3D 52 > 1 socket(AF_INET, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP)= =3D 36 > 1 setsockopt(36, SOL_SOCKET, SO_REUSEADDR, [1], 4) =3D 0 > 1 bind(36, {sa_family=3DAF_INET, sin_port=3Dhtons(8082), sin_addr=3Di= net_addr("127.0.0.1")}, 16) =3D -1 EADDRINUSE (Address already in use) > 1 write(23, "(reply (version 0) (result #f) (error (error (version 0)= action-exception start guix-publish system-error (\"bind\" \"~A\" (\"Addre= ss already in use\") (98)))) (messages (\"Service guix-publish has been sto= pped.\")))", 208) =3D 208 > 1 close(23) > ---snap--- > > The obvious explanation would be that stopping does not wait for the > process to actually exit. make-kill-destructor does not waitpid it seems > and 'running is set unconditionally to #f after 'stop has finished. Indeed. This is fixed by Shepherd commit d97592f58603ff51cb280ae57d413c8731e601b3, which will be in the upcoming 0.9.3 release. Thanks, Ludo=E2=80=99.