unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Kaelyn <kaelyn.alexi@protonmail.com>
Cc: 59519-done@debbugs.gnu.org
Subject: bug#59519: LibreOffice 7.3.5.2 fails to build on i686-linux
Date: Sat, 26 Nov 2022 23:15:44 +0100	[thread overview]
Message-ID: <875yf19x7c.fsf@nckx> (raw)
In-Reply-To: <Z2LMwUZaypR2VGnb3bUUN7tetAhGixOo9QFHkinSutT7_-xxP3PkYZImdRGr4jGjyNiPRJfFNR3yfnpEI7JCv9TjTAgOlHTD-jICoqg_Hc8=@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Hi Kaelyn,

Kaelyn via Bug reports for GNU Guix 写道：
> Here is a revised diff with comments added for the flags.

Thanks again!  Pushed as 536adbd7cca1f257261645d9cfd7910a0055a60e, 
also with a commit message added.

> +         ;; Enable building with LTO to avoid linker errors 
> about
> +         ;; non-virtual thunks on i686-linux.
> +         "--enable-lto"
> +         ;; Disable galleries to avoid errors rebuilding the 
> Gtk icon
> +         ;; cache, at least on i686-linux.
> +         "--without-galleries"

The importance of comments is to document the ‘why’.  The ‘what’ 
is obvious from the flags themselves, so I removed the first few 
words of each comment to make them fit nicely on 1 line.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-11-26 22:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 16:43 bug#59519: LibreOffice 7.3.5.2 fails to build on i686-linux Ludovic Courtès
2022-11-24 18:37 ` Ricardo Wurmus
2022-11-25  9:18   ` Ricardo Wurmus
2022-11-25 19:50 ` Kaelyn via Bug reports for GNU Guix
2022-11-25 19:54 ` Kaelyn via Bug reports for GNU Guix
2022-11-26  2:02 ` Kaelyn via Bug reports for GNU Guix
2022-11-26 22:15   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yf19x7c.fsf@nckx \
    --to=bug-guix@gnu.org \
    --cc=59519-done@debbugs.gnu.org \
    --cc=kaelyn.alexi@protonmail.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).