From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mKisA8osgmOqiQAAbAwnHQ (envelope-from ) for ; Sat, 26 Nov 2022 16:12:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YEXLAsosgmN1BwEAG6o9tA (envelope-from ) for ; Sat, 26 Nov 2022 16:12:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4C56EFBB for ; Sat, 26 Nov 2022 16:12:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oywqa-0005Hg-AS; Sat, 26 Nov 2022 10:12:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywqY-0005FI-Hi for bug-guix@gnu.org; Sat, 26 Nov 2022 10:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oywqY-0004Lg-92 for bug-guix@gnu.org; Sat, 26 Nov 2022 10:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oywqY-00070r-4Z for bug-guix@gnu.org; Sat, 26 Nov 2022 10:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#30948: [PATCH core-updates] guix: Reap finished child processes in build containers. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Nov 2022 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30948 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 30948@debbugs.gnu.org, Carlo Zancanaro Received: via spool by 30948-submit@debbugs.gnu.org id=B30948.166947548426911 (code B ref 30948); Sat, 26 Nov 2022 15:12:02 +0000 Received: (at 30948) by debbugs.gnu.org; 26 Nov 2022 15:11:24 +0000 Received: from localhost ([127.0.0.1]:41132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywpw-0006zx-1d for submit@debbugs.gnu.org; Sat, 26 Nov 2022 10:11:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywpt-0006zi-Pq for 30948@debbugs.gnu.org; Sat, 26 Nov 2022 10:11:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywpn-00049N-IS; Sat, 26 Nov 2022 10:11:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=gtSmDRbd9BZJ1gXExIQGRmyis3euS8L0/vFvmpMFIVs=; b=eAeQ6luggfT7o8ablxcL pEeLUg06m/Z86sQbbepRGTA8PWT8cle3aAsGdTG6xfjoxZLxN3CGWw/QwWi8CH1xi4BzcTkDSCvZE 3MYNexgR9jWUAtDoeHj7++04NViHSWj+ta88P+ilg5SCbaPNOt1zsQJbK5yQaxQxXh46FqUwBOEcn fhlJ4LLFsrmDAbGA9S63KaNlANRDqR5Cn4dvLD6lWe7811P1b9gXoNLug3qVRTZds0mi4RnWB/BUV iqVdHfjCxzetoVjLGPAb6V1izbNDuZVINLwjGXQ95qneQ457DaFUp2tjyrmTxqE//4O8D8ZTJ/AUd Gkx4LS29fmXv2w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywpm-0003a6-A7; Sat, 26 Nov 2022 10:11:15 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87muyvulwt.fsf@zancanaro.id.au> <87bmf6ve6u.fsf@gnu.org> <87sh8id1mg.fsf@zancanaro.id.au> <87vadeou54.fsf@gnu.org> <87o9j5x1d4.fsf@zancanaro.id.au> <874lkxoanq.fsf@gnu.org> <87cz9cnvys.fsf_-_@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la =?UTF-8?Q?M=C3=A2che?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 26 Nov 2022 16:11:12 +0100 In-Reply-To: <87cz9cnvys.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Thu, 24 Nov 2022 11:44:27 -0500") Message-ID: <875yf192en.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669475529; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gtSmDRbd9BZJ1gXExIQGRmyis3euS8L0/vFvmpMFIVs=; b=cYV7Xs1dyBcSv0iC3sAOEyVR2JhlLw73q3z+cNbYBvFs7EBwDODmKhhnzXHN2OpQ/SGhFx 39r9KBV3GRflNQNcMUWJDLcZn/MJnPU4G1+U+4cP30FdSjeYDkgJuEebX6mZKw70B1/4EV rTkVMVUptdcOtJVTBWLw7cVHMBi8HLXlppnZgbxXZD22idf0wVvtS8IfVrbyXTH/vstqKH qniUcFzlvWLUCP1X3LlhhzUN0Gy17Mp2Nd4OcKdhEEAf1QH64v4WA3n4eSkBN1RarXUnpw tX2tREeR5Jlb/IUd5fehgfooLaFov5SH+AHA0drTs7ac+ff8DF2PZAK3Q4/6jA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669475529; a=rsa-sha256; cv=none; b=lm5GYtjc2Yt1yd2s6Ysm3EXSw5zF7u7qaofBgDZuccMp8NKMPY8c/T2I7Wka1hbODFi67m FnEHt+hn75tovxLWbqTab5QQZ3zSn4mSgrra6xk00X86FtDKtF2F0E5spgoOAFK/+K1aQ1 QEhjCknfxX3QUl0wUTgxo54xXpcMG4gVnJbCj9urUPki2cFYzeA2/mfoMQz1SwqSRrhvtx tBaLZwgcKNl1RAQR9gu3WySkC6vicwX0SfDrYMz5Pf5TCOOkN6gIYp9WRabCld9GYOxrEm OtCBZoJkjO9mYlNcGu4FHRQazDPkc59azlAW92mKqEH2KeiLsk6paNxJK/mh9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=eAeQ6lug; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=eAeQ6lug; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A4C56EFBB X-Spam-Score: -3.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: UU3GWLoSHsg8 Hi, Maxim Cournoyer skribis: >> My view is just that this mechanism belongs in =E2=80=9Cuser code=E2=80= =9D, not in the >> low-level mechanisms such as =E2=80=98build-expression->derivation=E2=80= =99 and >> =E2=80=98gexp->derivation=E2=80=99. It=E2=80=99s a matter of separation= of concerns. > > Why? On my Guix System, such signal handling is handled by Shepherd, if > I'm not mistaken. As I user, I can trust the foundation to be sane, > rather than having to provide the bits to make it so myself. > >> Of course we don=E2=80=99t want to duplicate that code every time, but t= he way >> we should factorize it, IMO, is by putting it in a =E2=80=9Cnormal=E2=80= =9D module that >> people will use. >> >> Putting it in gnu-build-system is an admittedly hacky but easy way to >> have it widely shared. > > I think we can do better than hacky here :-) I think the real issue here is semantic clarity when it comes to derivation inputs. If I write: (gexp->derivation "foo" #~(mkdir #$output)) I can be sure that my derivation depends on nothing but (default-guile). This is important for tests, but also to make sure we can use this primitive everywhere=E2=80=94if it pulled in the Shepherd, I wouldn=E2=80= =99t be able to use to build glibc, because there=E2=80=99d be a cycle. In that sense, having child-reaping code in gnu-build-system.scm, just like in (guix least-authority), doesn=E2=80=99t seem unreasonable to me. That said, I=E2=80=99m open to other proposals so please unleash your creativity! :-) We=E2=80=99re touching core components though so this will require discussi= on. Ludo=E2=80=99.