From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eHGZCet152RMWQAASxT56A (envelope-from ) for ; Thu, 24 Aug 2023 17:23:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CPNBCet152SwTAEAauVa8A (envelope-from ) for ; Thu, 24 Aug 2023 17:23:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DCD5838336 for ; Thu, 24 Aug 2023 17:23:22 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pii6j+Xq; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692890602; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=v4jvtVkwshoteARlEeJneqoBE0ha7+eigyM9eksu63A=; b=a5O4wauXKiaPSVkOGlohA1xD72JLNUURSRCSZTUC6vQAOGuTP4epNMKsnat264yIKPysaF nbOMm+vE74uLxwegdoepCjNNXv3y3RkPhgrNH3k25yqK3L6hpqz5nT4a4XDOd2gjqdsIXK 7VwqMDl8IXqeGbgk/y6b41GKtC1TQWFBtf2MUfAz+J27YetIlrf4BnwHgFIkm4LcsNiSpJ JqTKHpoULsNuZIb2YDigHwPd1wKx3byfcL1/YY2A7VWcFGUZ12hK4fYp6WiO5O4+B25QxQ QKr6j5F7Cib0xnkh1GZi69N/I+JuMzTfksUAL8ALg3HKliR6Mh/wFeUHW9LshA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pii6j+Xq; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692890602; a=rsa-sha256; cv=none; b=YkN2GjslPquuuDaL2X1LZTJzBWJZXaXJcEyR0/DRFUsbUffrQulqCZuybUjXvSk6UMdYGZ zHUWyhvI1bm703nXu+PSeYtN8cXsg74iPMCZsMbL4MrHS7YRR99s1sT6rOFVveGDkni/Zw wh8yH/bu7PsMhbwySYUnAFlHl+63b4h8sIgVKdpB7PwXnaXJ0soWRHv359+9WdSremNjcr ZvpTKIhIBbnZ7Vhj+VzWCUk6lL/ykLKo6VcKNdoInycPA7xfvTzzM2fuigvrkt/+GRT57f gvtT//ho/O1fKdOkr+f5IGdevOv+HQ75L4Lif9SeupCio5h7iOfSTkYTQ5Q/mA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZCAn-0005zT-53; Thu, 24 Aug 2023 11:23:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZCAl-0005zK-B4 for bug-guix@gnu.org; Thu, 24 Aug 2023 11:22:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZCAl-0001v8-2H for bug-guix@gnu.org; Thu, 24 Aug 2023 11:22:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZCAo-0000ur-Kn for bug-guix@gnu.org; Thu, 24 Aug 2023 11:23:02 -0400 Subject: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Thu, 24 Aug 2023 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64317 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 64317-done@debbugs.gnu.org Mail-Followup-To: 64317@debbugs.gnu.org, ludo@gnu.org, ludovic.courtes@inria.fr Received: via spool by 64317-done@debbugs.gnu.org id=D64317.16928905553482 (code D ref 64317); Thu, 24 Aug 2023 15:23:02 +0000 Received: (at 64317-done) by debbugs.gnu.org; 24 Aug 2023 15:22:35 +0000 Received: from localhost ([127.0.0.1]:38421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZCAM-0000u5-O4 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 11:22:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZCAK-0000tt-Sn for 64317-done@debbugs.gnu.org; Thu, 24 Aug 2023 11:22:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZCAB-0001sD-BS for 64317-done@debbugs.gnu.org; Thu, 24 Aug 2023 11:22:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=v4jvtVkwshoteARlEeJneqoBE0ha7+eigyM9eksu63A=; b=pii6j+XqSYbaRJVC+IuP ChnKtEl1uaVm9E5J343QW97PO9102MM0QaZy6r1l8P6W2nYKXTiWS66ZZRYSrX7hsP+qFN9Lh9wZh c0R4+jwh9l3QyQZrAKCtgdwG7yDxZiQiHTQ0EI/64IyBwrP/xqv8gg/GyNtk2ujK/Z/qkNB18E6hF 8Vtzm8EDA/WXsU49j2MimhA36+F/QMLed4jIRDQUNtSbUHsdLMLAaVdyXKedPtgK1v5/lvC/2eUa9 E4hgEwQYSW7bkVefhPAAkQESbex4BzZZ2wQfAktvC6SsizyyLqh0XYnvo+xraWy2bHi9HmYYOc0Yq J8QCGjH2j8KQWg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87bkh1uhdf.fsf@inria.fr> Date: Thu, 24 Aug 2023 17:22:18 +0200 In-Reply-To: <87bkh1uhdf.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 27 Jun 2023 16:09:16 +0200") Message-ID: <875y54xy6t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -6.91 X-Spam-Score: -6.91 X-Migadu-Queue-Id: DCD5838336 X-TUID: vAoivXdDULh5 Ludovic Court=C3=A8s skribis: > The /download endpoint refers directly to store items. However, they > can be GC=E2=80=99d in the meantime, in which case the HTTP handler fails > gracelessly (HTTP 500 or so) as shown here: > > 2023-06-27 16:02:24 GET /download/718 > 2023-06-27 16:02:24 Uncaught exception in task: > 2023-06-27 16:02:24 In fibers.scm: > 2023-06-27 16:02:24 172:8 1 (_) > 2023-06-27 16:02:24 In ice-9/boot-9.scm: > 2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _) > 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exceptio= n: > 2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/= gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz" > > The solution IMO is to (1) register GC roots for these, (2) periodically > remove old GC roots, and (3) return 404 when the file has vanished. Fixed with these Cuirass commits: 9e897d8 'create-build-outputs' registers a GC root on build products. 103a6ec http: Gracefully handle missing files in "/download". 5e3e49c http: "/download" returns 404 rather than 500 for "not found". Ludo=E2=80=99.