From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id EN1cOBYYPWU7TwEAG6o9tA:P1 (envelope-from ) for ; Sat, 28 Oct 2023 16:17:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EN1cOBYYPWU7TwEAG6o9tA (envelope-from ) for ; Sat, 28 Oct 2023 16:17:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE3483F342 for ; Sat, 28 Oct 2023 16:17:58 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=hB8DcwVd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698502678; a=rsa-sha256; cv=none; b=iyr66I7oXTwDbu8DurAyXg84qj+xpeP3Qfasi0pGpDwO79WDPAtwkXzOqlOC/swGOOobkf Tm72HHlN4Nwyv+6WohIvUSfZ5+AmEW4CtTTk0+gQ+yN7Ic0243blcdOg0PD38uqfPUmtz6 zwTTtt7MRTrhJ24XBg6JHNv9CFK3Ro3pFQQpww+kgxYkfz1SxKwBJqyvcrr6nVGWkt+NKj EBNTJS9xTUm5z4lKJeqxdkWZ52cFWhA7rSKoHeB4RwipPpswSMgRu8NN2KQfpkQnfCLUSI AqV9iaRcaWQpMyfr/w3WjWSHKvVKsLamrQo64/E1bi3MNtyWwaN71NwJOwpuug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698502678; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ra4B4uVkCaaJGDlvYmItNkmtV4aJ+KOvVvgRx/ql//w=; b=riWCS8FSTRZOURwGoJb1/XZE8VVhGnH6az/7kiRJW/uzGZ5JoiTpsd51BgjM4GaKRT0Jo0 ZRy+mvNhHsnz7KmwM5bcQQ+r29FvYmihEGbnDHhiZWt6h9Y3jYchH91Vnq7VWf5DDaxlk6 CS+7jMzmJorbj+rWTv7ljE7SPHj/JT4YZPdSYouJ6+IeiDXmahtYSDms4av6of2P9S07UL IPXlsQvyO3OgODpZ3/pjNYg1nnBAnZyUi/S4tAPmtIgqiKwA6++YWBRBlsR0aIjxU8btrN Ya6bwCxbEJ9pDu+WGPyCDa8kGQUHR0iDw1DMn4uZny+baMEgmjTFP8n+gRhT9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=hB8DcwVd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwk84-0002Fn-GP; Sat, 28 Oct 2023 10:17:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwk83-0002Fd-Ip for bug-guix@gnu.org; Sat, 28 Oct 2023 10:17:31 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwk83-0001fO-Ak for bug-guix@gnu.org; Sat, 28 Oct 2023 10:17:31 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwk8Z-0001u4-9l for bug-guix@gnu.org; Sat, 28 Oct 2023 10:18:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65788: poor information when updating using =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 28 Oct 2023 14:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65788 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: 65788@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 65788-submit@debbugs.gnu.org id=B65788.16985026597252 (code B ref 65788); Sat, 28 Oct 2023 14:18:03 +0000 Received: (at 65788) by debbugs.gnu.org; 28 Oct 2023 14:17:39 +0000 Received: from localhost ([127.0.0.1]:39323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwk8B-0001st-5d for submit@debbugs.gnu.org; Sat, 28 Oct 2023 10:17:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwk88-0001sf-RN for 65788@debbugs.gnu.org; Sat, 28 Oct 2023 10:17:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwk7X-0001dw-Df; Sat, 28 Oct 2023 10:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ra4B4uVkCaaJGDlvYmItNkmtV4aJ+KOvVvgRx/ql//w=; b=hB8DcwVdjQXCyW6Ob3c7 ETjuzTVCSx+7OO+6S9EMh2gHyNUj2kygADE2FFgaizgnA9R71MzMgOhfsiTXCOb9lIFFZaPm9Vel+ 0P3ws1Bxl5o4dLy65bVh1lERq075sw3vXq2Rqa9HtX+qLRNDXjbSXfs5zlszxyr2oL8qC0VY9Z6Bw 1XZ/9Bq4RHWEAZ9NlVVvD9FrnR90YghAKdMvB2v4q1mN+e6tZdHUMWfls1I7Dw1/GEa7pJbKitaLd vxpKD24gSyDC/I5tAEaOH5pM+vGqmVylpaBN2XSYgv/c4UbR/cUuKEHMM/cDyQX0Le3aM7Nw0Lx6y tlRTC46hP9uYLg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87pm2vme7x.fsf@gmail.com> (Simon Tournier's message of "Wed, 06 Sep 2023 18:57:38 +0200") References: <87pm2vme7x.fsf@gmail.com> Date: Sat, 28 Oct 2023 16:16:56 +0200 Message-ID: <875y2q96hz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -4.99 X-Migadu-Queue-Id: AE3483F342 X-Migadu-Spam-Score: -4.99 X-TUID: Er2fGswaGdnG Hi, (Cc: Maxim.) Simon Tournier skribis: > $ guix time-machine -q --commit=3D6113e05 -- describe > receiving objects 2% =E2=96=95=E2=96=88=E2=96=8B > =E2=80=A6some time flies=E2=80=A6 > indexing objects 21% =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96= =88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88= =E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2= =96=88=E2=96=88 = =E2=96=8F > =E2=80=A6some time flies=E2=80=A6 > Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.= org/git/guix.git'... > =E2=80=A6instant=E2=80=A6 > Computing Guix derivation for 'x86_64-linux'... \ To be clear, the problem you see is that =E2=80=9CUpdating channel=E2=80=9D= is printed too late, after =E2=80=9Creceiving objects=E2=80=9D etc., right? > Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals. = Somehow, it is > in guix/scripts/ because it captures =E2=80=99ref=E2=80=99. However, thi= s capture is > redundant and is normally managed by =E2=80=99channel-list=E2=80=99. The= refore, I would > be tempted to have this validation for the reachable commit close to the > =E2=80=9CUpdating=E2=80=9D message. Yes, that=E2=80=99s a good idea. As I started looking into it, I realized we could reuse the existing #:validate-pull mechanism of =E2=80=98latest-channel-instances=E2=80=99 for= the purposes of this commit check in =E2=80=98time-machine=E2=80=99. The main advantage is that this would address a performance issue with the implementation of =E2=80=98validate-guix-channel=E2=80=99 in commit 79ec651a286c71a3d4c72be33a1f80e76a560031, namely the fact that it opens and traverses the repository one extra time for this check. (The #:validate-pull mechanism is integrated with =E2=80=98latest-channel-instan= ces=E2=80=99 precisely to avoid this cost.) Here=E2=80=99s my proposal to do that: https://issues.guix.gnu.org/66793 Ludo=E2=80=99. PS: We should define rules for =E2=80=9CReviewed-by=E2=80=9D tags because I= don=E2=80=99t think I LGTM=E2=80=99d commit 79ec651a286c71a3d4c72be33a1f80e76a560031 (?).